Commit graph

44109 commits

Author SHA1 Message Date
Susucre
2944dab01d clean workaround in ReturnToHandAttachedEffect 2024-04-25 22:09:51 +02:00
Susucre
fe604382f8 sync zcc 2024-04-25 21:49:34 +02:00
Susucre
36d6547bf8
Modal double-faced cards - fixed game error on usage with some replacement effects (example: Diluvian Primordial, closes #12176) (#12184) 2024-04-25 23:40:57 +04:00
Susucre
1ae48593a8 have separate turn events for extra beginning.
I did check the BEGINNING_PHASE_PRE usage, and found none that wanted to watch the extra beginning phases.

Of note, we may want to have separate 'beginning of turn'/'beginning of game' events, if there is ever a way to skip beginning phases.
2024-04-25 18:58:32 +02:00
Susucre
ff4bd9b430 fix Obeka, Splitter of Seconds' extra phase calling beginning of turn method 2024-04-25 12:16:37 +02:00
Susucre
110e9903f5 fix verify decklist referencing MB1 2024-04-25 12:15:45 +02:00
Susucre
c6d710f7d5 fix Calamity, Galloping Inferno (#12175)
fix #12175
2024-04-23 11:03:50 +02:00
xenohedron
9566e23d0b
Rework Mystery Booster and adjust some set classifications (#12138)
Mystery Booster rework:
* added images download support from scryfall (closes #11806);
* added virtual sets support (remix);
* fixed Commander set name (closes #12110);
2024-04-23 09:28:40 +04:00
Alexander Novotny
9f52c8946e
Allow multiple icons at the top right of player avatar (#12169) 2024-04-22 23:58:43 -04:00
Alexander Novotny
42906f519b
Fixed remembering self-referential choices (#12167)
* Fixed remembering self-referential choices

* Rename filtered message to auto answer message

* Always use auto answer message
2024-04-22 23:58:26 -04:00
jimga150
40143c648f
[REX] Implement Ian Malcolm, Chaotician (#12117)
* Start on Ian Malcolm, Chaotician, missing key effects

* fox ANY clause in DrawNthCardTriggeredAbility

* Get exile effect working

* Start using Evelyn, the Covetous code

* align exile effect

* align player clause

* align card type clause

* align counter check clause

* align mana clause

* add ownership clause

* remove redundant comments

* fix redundant mana clause description

* fix counter clause in mana cost effect

* fix active clause in mana effect

* use MageObjectReference to associate exiled cards with an Ian Malcolm instance

* optimize imports

* Start tests, failing currently

* fix test and add blink test

* fix signature of constructor

* fix order of super() call in checkTrigger

* clarify hash maps in watcher

* use correct AsThoughEffect

* document header of checkExile

* generalize modal and double faced cards for LKI fetch

* remove land played event for watcher

* Use custom MageIdentifier to filter usedMap
2024-04-22 23:58:05 -04:00
Alexander Novotny
f8f9b0caa0
Fix verify failures (#12168) 2024-04-22 09:58:28 -04:00
jimga150
28a1442899
Krark's Thumb - fixed that it can generates too many flip triggers (#12152)
---------

Co-authored-by: Susucre <34709007+Susucre@users.noreply.github.com>
2024-04-22 11:22:42 +04:00
Susucre
c0c05579ba fix client NPE if Radiation trigger in trigger order panel
The frameStyle was unexpectedly null when displaying the trigger in the view to choose trigger panels.
It was good on the stack so I missed that in initial implementation.

Bug showed up once there was another trigger on Beginning of Main Phase, for instance Coalition Relic.
The lack of frameStyle lead to a rendering NPE.
2024-04-21 18:52:46 +02:00
Susucre
a35078440a fix Nuclear Fallout 2024-04-21 17:23:37 +02:00
Susucre
2eb872c93e tweak PlayerPanel pixels 2024-04-21 11:19:13 +02:00
Oleg Agafonov
6ca94e11ff Case the Joint - fixed that it doesn't look at other players library (related to #12151); 2024-04-20 23:47:59 +04:00
Oleg Agafonov
5784bce025 Disciple of Caelus Nin - fixed that it doesn't ask other players to keep permanents (closes #12151); 2024-04-20 23:46:10 +04:00
Oleg Agafonov
f95a70dda4 Leafkin Avenger - fixed that it count opponent creatures, added card hint (closes #12146); 2024-04-20 23:40:50 +04:00
Susucre
dee0637496
fix and test Zirda's Companion legality (#12142) 2024-04-20 11:14:29 +02:00
jimga150
b2c52ff906
Dragon Cultist - fixed wrong damage count (#12149) 2024-04-19 21:19:31 +04:00
xenohedron
e095a76561 update Czech Republic -> Czechia (resolves #12143) 2024-04-19 01:18:38 -04:00
xenohedron
89bc08a840 adjust TokenImagesTest to not use MB1 2024-04-18 20:18:48 -04:00
Susucre
629ff68c64 fix VerifyTest 2024-04-18 21:11:17 +02:00
Susucre
9a21f24f2c [PIP] Implement Glowing One & Ingesting Radroach 2024-04-18 19:28:15 +02:00
Susucre
0da12c4bc2 fix Kess, Dissident Mage (#11924)
fix #11924
2024-04-18 17:56:31 +02:00
xenohedron
fc3551fc0a text improvements 2024-04-17 20:54:05 -04:00
RaelCappra
52530b173d
Update Banned & Restricted List, March 2024 (#12136)
* Modern: ban Violent Outburst

* Vintage: unrestrict Ponder
2024-04-17 20:26:17 -04:00
Matthew Wilson
b76a3ba889
gui: fix Saga DFC rendering (#12134) 2024-04-17 20:25:15 -04:00
jimga150
006f212b6b
[REX] Implement Indoraptor, the Perfect Hybrid (#12122)
* Implement Indoraptor, the Perfect Hybrid

* Add tests
2024-04-17 20:24:56 -04:00
jimga150
b0d7daa85e
[REX] Implement Grim Giganotosaurus (#12103)
* Implement Grim Giganotosaurus

* Refactor MonstrosityAbility to take cost adjuster

* Update Nemesis of Mortals' monstrous ability and add test for cost reduction
2024-04-17 20:24:37 -04:00
Susucre
9d7bf27d38
[PIP] Implement Rad Counters mechanic (#12087) 2024-04-17 20:04:17 +02:00
Susucre
11373fd75d fix Xanathar, Guild Kingpin (#12133)
fix #12133
2024-04-17 19:59:31 +02:00
Oleg Agafonov
92b722d3ca server: fixed bloated logs about table owner's invalid deck 2024-04-17 12:27:41 +04:00
Oleg Agafonov
a9372e93ff server: improved game stability on player's concede (related to #11460) 2024-04-17 12:21:11 +04:00
Oleg Agafonov
88eb35ebc7 code clean 2024-04-16 23:37:22 +04:00
Oleg Agafonov
e8e2f23284 server: improved server stability (#11285) and reworked triggers/playable logic (#8426):
* game: now all playable calculations done in game simulation, outside real game (no more freeze and ruined games by wrong Nyxbloom Ancient and other cards with wrong replacement dialog);
* game: fixed multiple problems with triggers (wrong order, duplicated calls or "too many mana" bugs, see #8426, #12087);
* tests: added data integrity checks for game's triggers (3 enabled and 3 disabled due current game engine logic);
2024-04-16 23:10:18 +04:00
Susucre
f68e435fc4 rework and test Phyrexian Ingester 2024-04-14 12:33:26 +02:00
Susucre
017286ed94
fix ContinuousEffect that access affectedObjectsSet before it is initialized (#12080) 2024-04-13 16:50:06 +02:00
Susucre
cce7f79d89 fix and test Lara Croft, Tomb Raider (#11945)
Fix #11945
2024-04-13 13:21:29 +02:00
Susucre
fc011ac7e0 fix Opposition Agent (#10576)
Fix #10576
2024-04-13 12:59:52 +02:00
jimga150
db9e849ac8
[REX] Implement Henry Wu, InGen Geneticist (#12106) 2024-04-13 12:22:58 +02:00
Susucre
607d55f16b
[OTC] Implement 2 cards, refactor some exile effects ("Gonti-like") (#12118)
[OTC] Implement Gonti, Canny Acquisitor
[OTC] Implement Dream Thief's Bandana
2024-04-13 12:21:05 +02:00
Susucre
c77634c843
separate 'you may play'|'you may cast' AsThoughtEffect approuvers
Also, reworked Gonti, Lord of Luxury and checks it now works properly with Zoetic Cavern.
2024-04-13 12:10:53 +02:00
xenohedron
31295eb645 followup fix to #12058 2024-04-12 23:24:56 -04:00
xenohedron
8394429a47 reminder text fixes 2024-04-12 22:43:35 -04:00
xenohedron
8853e7d875
refactor: clean up static filters for sacrifice targets (#12120)
* simplify sacrifice target filters, part 1

* minor cleanup

* adjust SacrificeXTargetCost

* adjust Arctic Merfolk

* more cleanup

* remove unused

* adjust filters not used for sacrifice

* fix Hew the Entwood

* fix Nahiri's Lithoforming

* remove unused

* remove another

* cleanup more

* fix MegatronDestructiveForce

* remove next

* next batch of replacements

* remove next

* rename filter to match text

* finish removing

* use existing static filter
2024-04-12 22:24:10 -04:00
xenohedron
5c9d1cd205 fix #12058 (check phased in for "control a commander") 2024-04-12 20:59:36 -04:00
xenohedron
1198192a13 more text adjustments 2024-04-12 20:45:53 -04:00
sandbo00
d011e70baf
[PIP] Implement Marcus, Mutant Mayor (#11999)
---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
2024-04-12 20:16:15 -04:00