Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

master #28

Closed
Failure wants to merge 0 commits from External/mage:master into master
pull from: External/mage:master
merge into: Failure:master
Conversation 0 Commits - Files changed -
Failure commented 2025-06-28 00:01:58 -07:00
Owner
Copy link
No description provided.
Failure added 556 commits 2025-06-28 00:02:06 -07:00 
* remove ConditionalTriggeredAbility

* a few small fixes

* merge fix

* simplify phrase handling

* add documentation

* a few text fixes

* update wording
* [FIC] Implement Tidus, Yuna's Guardian

* merge fix
- added commander decks support (close #5680);
- fixed and improved cards searching due selected colors (now it search by color identity instead mana cost);
- added non-strict search (enter multiple words in any order or case);
- added strict search (enter exact phrase inside quotes);
* added power level info in deck validation panel;
* added detail calculation info (hint with cards and their power levels);
* fixed that deck's edh power level ignore individual card's levels and used only commanders;
* removed outdated deck restrictions by commander colors;
* now players can really limit allowed decks by edh power level;
Fixes #12353
Fixes #13665
Missed in a4f22f21cf change
Fixes #13667
to find permanent from card after moved to battlefield
* [FIN] Implement Ancient Adamantoise

* change effect type

* add test
* add method for multiple coin flips

* [FIN] Implement Edgar, King of Figaro

* add extra note

* update coin flip logic

* add test
* [FIN] Implement Gogo, Master of Mimicry

* add test

* fix text

* move abstract method definition to interface where it belongs
* Update render mode selection

* changes render mode selection to a drop-down
* modes include MTGO, Image, Forced M15, Forced Retro
* debug card test panel updated with additional modes as well

* Update wording on tooltips and update debug panel combobox

* Update CardRenderMode to have id
(confirmed by test coverage)
Update effects that find a permanent from a card put to battlefield
* [FIC] Implement Banon, the Returners' Leader

* fix Banon data line
fixes a few bugs along the way:

[[Pilgrim and Justice]] & [[Pilgrim of Virue]] were incorrectly adding a "to you" to their damage clause.
[[Ajani's Aid]] was improperly a one-use prevention effect.

[[Story Circle]] and [[Prismatic Circle]] have not been refactor as it is not currently possible to have a proper filter for them. Would require a FilterSource with a 4-argument match most likely.
enable the two ignored after #11619
enable the two ignored after #11619
* rework effects with DoIfCostPaid and "do this only once each turn"

* [FIC] Implement G'raha Tia, Scion Reborn

* [FIC] Implement Emet Selch of the Third Seat

* rework Emet-Selch

* add test

* add static methods to handle whether ability was used this turn
- new tourney's single game mode allow to play tourneys/drafts with all players in one game without multiple rounds;
- it's allow to setup classic drafts with 1 vs 1 games and multiple rounds
- added AI opponents supported including draft bots from a public servers;
- GUI, table: added dynamic data support for Cube Types (no more depends on server's config names, part of #12050);
- server: replace multiple MTGO Vintage Cubes by single cube, updated to April 2025 (part of #12050);
- server: fixed table freeze on starting error (related to #11285);
- GUI, table: added better support of Cube From Deck (client/server side errors, additional info about loaded cards, etc);
* rework affinity implementation

* move filters
"When a [] enters, you may return this card from your graveyard to the battlefield enchanting that creature"
Adds OneShotNonTargetEffect and PutCountersTargetCost
Fixes the target timing of spells/abilities, as non-targets should be chosen on resolution.
Small fix of enabling TargetSource to choose/target a Command Object
fixes #13717
Attempting to replicate #13716 bug without result.
Assuming there was a counter replacement effect in place missing in the bug report.
fixes #13722
Zenos yae Galvus was not letting you choose a creature when it entered, because getPermanentEntering returned null due to Zenos already being in play.
* update saga rules

* update test

* update test
* refactor SourceHasCounterCondition to be an IntCompareCondition

* add comment for arguments
also adjust Courageous Resolve

---------

Co-authored-by: xenohedron <12538125+xenohedron@users.noreply.github.com>
---------

Co-authored-by: xenohedron <12538125+xenohedron@users.noreply.github.com>
related to #13734
move findTargetingStackObject from CardUtil to Game, so saved data can be cleared with short living lki

add test cases
- fixed game errors with source related filters (related to #13713);
- fixed game freeze in hand's cards selection (related to #13290);
- fixed game freeze in target amount selection with X=0 (related to #13290);
add test
Adds target and/or target adjuster to cards whose abilities have the word "target", cards A-G.
Creates SourceDealsNoncombatDamageToOpponentTriggeredAbility and DefineByTriggerTargetAdjuster
Create AttacksPlayerWithCreaturesTriggeredAbility, and tests for that ability via Soaring Lightbringer.
Implement Echoing Assault.
- refactor: removed outdated/unused code from AI, battlefield score, targeting, etc;
- ai: removed all targeting and filters related logic from ComputerPlayer;
- ai: improved targeting with shared and simple logic due effect's outcome and possible targets priority;
- ai: improved get amount selection (now AI will not choose big and useless values);
- ai: improved spell selection on free cast (now AI will try to cast spells with valid targets only);
- tests: improved result table with first bad dialog info for fast access (part of #13638);
Adds target and/or target adjuster to cards whose abilities have the word "target", cards H-R.
fix EffectKeyValue text, NestOfScarabs
Add X value to effects for CycleTriggeredAbility, use with ValorsFlagship and SharkTyphoon, add test
Adds target and/or target adjuster to cards whose abilities have the word "target", cards S-Z.
Add `spellCast` value to `CastSpellPaidBySourceTriggeredAbility`.
filters should be declared `private static final`
Cyclone effect full text replacement
use game default BlockedAttackerWatcher
- refactor: migrated AI's target amount code to shared selection logic;
- ai: fixed game freezes on some use cases;
- tests: added AI's testable dialogs for target amount;
- tests: improved load tests result table, added game cycles stats;
- Dwarven Catapult - fixed game error on usage;
Failure closed this pull request 2025-07-19 22:34:16 -07:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Failure/foul-magics#28
No description provided.
Delete branch "External/mage:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?