Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions
43210 commits 5 branches 220 tags 1.1 GiB
Commit graph

763 commits

Author SHA1 Message Date
Matthew Wilson
f8d15cd6ba
[MKM] Implement Cases (#11713) 
* Implementing "case" mechanic

* [MKM] Implement Case of the Burning Masks

* [MKM] Implement Case of the Filched Falcon

* [MKM] Implement Case of the Crimson Pulse

* [MKM] Implement Case of the Locked Hothouse

* Address PR comments

* some minor adjustments

* adjustments to hints

---------

Co-authored-by: Matthew Wilson <matthew_w@vaadin.com>
Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
 2024-01-28 23:41:23 -05:00
xenohedron
391ddf267b even more text fixes 2024-01-27 21:18:25 -05:00
Evan Kranzler
99c2ffa231
Implementing "collect evidence" mechanic (#11671) 
* [MKM] Implement Axebane Ferox

* add exile to cost, fix text

* add targeting message copied from crew ability

* [MKM] Implement Forensic Researcher

* [MKM] Implement Izoni, Center of the Web

* implement requested changes

* merge fix

* [MKM] Implement Sample Collector

* [MKM] Implement Evidence Examiner

* [MKM] Implement Surveillance Monitor

* [MKM] Implement Vitu-Ghazi Inspector

* [MKM] Implement Crimestopper Sprite

* [MKM] Implement Urgent Necropsy

* [MKM] Implement Analyze the Pollen

* implement requested changes

* add can pay cost check to counter unless pays effect

* fix test failure

* add tests

* fix prompt message
 2024-01-27 20:26:14 -05:00
Matthew Wilson
784a5fb1e4
Fix Sanctuary Blade ability causing a trigger (#11682) 
* Fix Sanctuary Blade ability causing a trigger

* Remove unnecessary logic and correct test

* Re-add strict choose mode

---------

Co-authored-by: Matthew Wilson <matthew_w@vaadin.com>
 2024-01-20 13:20:17 -05:00
theelk801
1a8dce83d0 rename face-up/face-down events 2024-01-17 15:56:11 -05:00
theelk801
c0de1cec19 fix test failure 2024-01-17 15:51:54 -05:00
theelk801
9d8991f5af [MKM] Implement Gadget Technician 2024-01-17 15:11:12 -05:00
xenohedron
aa642324d7
refactor: sacrifice permanent triggered abilities (#11655) 
* refactor constructors in SacrificePermanentTriggeredAbility

enables general use

* refactor some custom classes

* reorder method signature, add docs

* refactor another batch of custom classes

* cleanup remaining custom classes
 2024-01-14 19:57:11 -05:00
jimga150
068f5db976
[PIP] Implement Mr. House, President and CEO (#11610) 
* move Cybernetic Datasmith's robot token to RobotCantBlockToken since Mr. House has a more generic version

* Update tokens database
 2024-01-06 15:09:14 -05:00
xenohedron
518407be73 fix regression: Michiko Konda, Truth Seeker 
missing a check in SourceDealsDamageToYouTriggeredAbility::checkTrigger

added test
 2024-01-03 01:14:46 -05:00
jimga150
53d62c7f44
[LCC] Implement Pantlaza, Sun-Favored (#11590) 2023-12-31 14:24:55 -05:00
xenohedron
9e1645a1bc text fixes 2023-12-06 23:14:58 -05:00
theelk801
62aad2bc25 [MKM] Implement Curious Cadaver 2023-12-06 18:21:49 -05:00
xenohedron
37722a58c2 more watcher cleanup 2023-11-29 20:32:36 -05:00
xenohedron
f7d70a7b11 refactor: AttackedThisTurnWatcher is a default watcher 
close #10982
 2023-11-29 20:27:30 -05:00
xenohedron
05e2cf11e7
refactor: replacement effects don't use apply method now (#11484) 2023-11-28 11:17:28 +04:00
ssk97
2abe61643c
[LTC] Implementations part 2/4 (#11470) 
* Aragorn, Hornburg Hero
* Minas Morgul, Dark Fortress
* Rohirrim Chargers
 2023-11-27 23:41:20 -05:00
Oleg Agafonov
99cbddb8b8
Merge pull request #11431 from Susucre/lci-mana-tracking 
[LCI] Implement Thousand Moons Smithy // Barracks of the Thousand and Brass's Tunnel-Grinder // Tecutlan, the Searing Rift
 2023-11-25 17:13:54 +03:00
xenohedron
81f97c3b0e fix more text 2023-11-25 02:59:06 -05:00
xenohedron
109547a1ad lots of text fixes 2023-11-23 01:54:51 -05:00
xenohedron
1c6c68e1a4 some text fixes 2023-11-23 01:54:51 -05:00
xenohedron
1816c8ad73 many the text fixes 2023-11-19 21:37:37 -05:00
xenohedron
8f89253b58
refactor triggers checking batch damage for one player (#11435) 2023-11-19 16:51:54 -05:00
Susucre
f45c9e8ee9 [LCI] Implement Thousand Moons Smithy // Barracks of the Thousand 2023-11-19 17:54:57 +01:00
xenohedron
5c83bbe970 refactor Quartzwood Crasher; Goro-Goro and Satoru 
to use DealCombatDamageControlledTriggeredAbility
 2023-11-08 23:28:12 -05:00
xenohedron
e122e9d512 various and sundry text fixes 2023-11-04 18:41:56 -04:00
xenohedron
ebf71941a9
cleanup EntersBattlefieldAllTriggeredAbility and subclasses (#11372) 
* comment out rule override to use generated text instead

* new ETB Opponent trigger class

* text improvements

* update ETB cast trigger

* remove controlledtext parameter

* more text improvements

* more fixes

* lots of other fixes

* most of the remaining fixes

* fix halana text

* fix smoke shroud text

* improve text gen

* remove rule param from constructors

* minor adjustments

* whenever a player puts

* final fixes

* standardize when/whenever phrase generation
 2023-10-31 21:00:45 -04:00
xenohedron
e802db32d3 fix Discover text 2023-10-30 01:26:55 -04:00
Susucre
bcd8687285 [LCI] Implement Poetic Ingenuity 2023-10-28 18:46:53 +02:00
Susucre
27b8d3e198
[LCI] Implement Deeproot Pilgrimage (#11350) 2023-10-26 18:06:10 +02:00
Susucre
5996cfbce2
[MIR] Implement Teferi's Imp (#11326) 2023-10-22 14:34:45 +02:00
Susucre
9c17b72892 refactor trigger from Aeon Chronicler and its cycle 2023-10-22 14:05:47 +02:00
xenohedron
59929d2860 new SourceDealsDamageToYouTriggeredAbility 
fix #11262

test coverage provided by FlamebladeAngelTest
 2023-10-20 21:48:35 -04:00
Susucre
dd1852352a
[WHO] Implement Regenerations Restored (#11312) 2023-10-16 20:38:34 +02:00
Oleg Agafonov
06138ab3d3 AI: refactor PassAbility usage, added additional runtime checks 2023-10-14 15:57:19 +04:00
xenohedron
2013895530 lots of text fixes 2023-10-13 23:27:44 -04:00
xenohedron
519ecb35c1 Implement [APC] Suppress 2023-10-13 23:27:44 -04:00
xenohedron
fa49ffd27f fix siege defeated trigger to be optional 2023-10-11 20:53:09 -04:00
theelk801
09dbdccfb2 [WHO] Implement Clara Oswald 2023-10-10 15:17:45 -04:00
xenohedron
87756a5cfa text fixes 2023-10-09 23:52:57 -04:00
xenohedron
d7afa37893
Remove superfluous addManaCost method (#11288) 
* no need to specify mana cost, just add cost

* handle all mana costs through addcost method only

* eliminate another constructor

* more constructor cleanup
 2023-10-09 15:25:19 -04:00
xenohedron
4e2a5bd5a9
Cleanup activated ability constructors (#11283) 
* simplify LoyaltyAbility constructors

* remove unused constructors in ActivatedAbilityImpl

* cleanup

* remove null rule setting

* another unused constructor

* fix escape ability reminder text

* escape text adjustment

* simplify Trigons, remove Costs constructor

* rework Villainous Ogre, remove another class and constructor

* fix test using wrong text for trigon ability
 2023-10-08 22:55:31 -04:00
xenohedron
25e559dd9d
fix Blightwing Bandit (#11282) 2023-10-08 17:53:49 -04:00
Susucre
8e1ef15b70
[LCI] Implement Ojer Axonil, Deepest Might (#11195) 
* [LCI] Implement Ojer Axonil, Deepest Might

* add tests

* Alter text generation on ActivateIfConditionActivatedAbility to handle "and as a sorcery"
 2023-10-08 17:52:36 -04:00
xenohedron
c8e2282a79
some more text improvements (#11258) 
* text on Eldrazi Spawn token

* refactor: return Ability instead of void

* cleanup assigning null to staticText

* cleanup Mimic cycle and GainAbilitySourceEffect

adjust Groundling Pouncer

* remove hardcoded rule param from SpellCastControllerTriggeredAbility

* fix #11257
 2023-10-05 22:04:02 -04:00
xenohedron
cd6c5aa7ac
improve usability of Rebound ability (#11261) 
* remove boilerplate template comments

* fix Rebound, now need to choose only once

* fix text: Harmless Assault
 2023-10-05 22:03:23 -04:00
Susucre
7c454fb24c
Rework AsThough handling to allow choosing/affecting a specific alternate cast (#11114) 
* Rework AsThoughEffect

* some cleanup of MageIdentifer

* refactor ActivationStatus

* fix bolas's citadel

* fix a couple of the Alternative Cost being applied too broadly.

* fix Risen Executioneer

* allow cancellation of AsThough choice.

* fix One with the Multiverse

* cleanup cards needing their own MageIdentifier

* last couple of fixes

* apply reviews for cleaner code.

* some more cleanup
 2023-10-02 18:42:54 -04:00
xenohedron
4e561b6254
text generation improvements (#11203) 
* update ETB trigger effect text gen

* set replace for common abilities

* fix remaining

* rename method, cleanup

* more fixes, better logic
 2023-09-25 21:51:51 -04:00
xenohedron
1b9bcb92e6 improve targetMap usage, naming, docs per review 2023-09-24 00:22:21 -04:00
xenohedron
48d7d07f93 reimplement Fractured Loyalty 2023-09-22 23:38:16 -04:00