Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

master #40

Merged
Failure merged 242 commits from External/mage:master into master 2025-09-18 08:48:11 -07:00
Conversation 0 Commits 242 Files changed 630 +15838 -2561
Failure commented 2025-09-18 08:47:18 -07:00
Owner
Copy link
No description provided.
Failure added 242 commits 2025-09-18 08:47:35 -07:00 
* update SacrificeAttachmentCost to work with canPaySacrificeCost

* update SacrificeXTargetCost to use canPaySacrificeCost

* update SacrificeXManaValueCost to use canPaySacrificeCost and getMaxValue

* update Phyrexian Dreadnought to use canPaySacrificeCost

* enable testNahiriSacrificePrevented test
- Infinity
- Stone
* remove periods from camel case name
* Esoteric Duplicator test demonstrates fix. Sculpting steel token was not coming back as an Esoteric Duplicator
* deck: added Bitter Triumph, Fable of the Mirror-Breaker, and Slickshot Show-off to Store Championships set

* added Monstrous Rage and Trinket Mage to Wizards Play Network 2025 set

* add Year of the Snake 2025 expansion set

* add Year of the Dragon 2024 expansion set

* deck: add Dragon and Snake tokens for PL24 and PL25

* add Year of the Dragon 2024 and Year of the Snake 2025 expansion sets

* add Reflection of Kiki-Jiki to Store Championships set

* hasBasicLands true for Year of the Dragon 2024 and Year of the Snake 2025

* Update URLs and Land rarity

* add MagicFest 2024 expansion set

* add Love Your LGS 2024 expansion set

* add MKM Standard Showdown expansion set

* Set Full Art Lands to Full Art

* Add new expansion sets: MagicFest 2024, MKM Standard Showdown, and Love Your LGS 2024

* Fix Error

* Add new expansion sets: MagicFest 2023 and 30th Anniversary History Promos

* Add new expansion sets: Love Your LGS 2022 and Regional Championship Qualifiers 2022

* Add Love Your LGS 2020 set

* Add new cards to PURL

* Update MagicFest 2025 set: add new cards and reorder existing entries

* Add Magiccon Cards
* SLP Poster Cards to FULL_ART

* Full_ART Fixes for SLD

* FULL_ART LTR

* EOE FULL_ART

* DSC FULL_ART

* SLD Rervsible FULL_ART
* AKR FULL_ART

* DFT FULL_ART

* FIN FULL_ART

* P08 FULL_ART

* PANA FULL_ART

* PF19 FULL_ART

* PF20 FULL_ART

* PL22 FULL_ART

* PRM FULL_ART

* USG RETRO

* Add UGL_FULL_ART_BASIC to isRetroFrame

* SPM FULL_ART
* Add promoTypes and isTextless fields to MtgJsonCard; enhance VerifyCardDataTest for full art validation

* whitespace fixes

* Add null check

* Split Retro and FullArt to seperate Test

* Refactor VerifyCardDataTest to consolidate full art setting checks for poster promoType and textless cards

* Add validation for full art lands in VerifyCardDataTest

* Remove duplicate checks in checkWrongCardsDataInSets and add "not use" checks
single trigger for multiple tokens
* Add Daily Bugle Breaking News

* Fix verify errors
* refactor ExileGraveyardAllTargetPlayerEffect to allow multiple targets

* [SPM] implement The Death of Gwen Stacy

* change ExileGraveyardAllTargetPlayerEffect to do one batch movement
* create common TargetsDamageTargetsEffect

* [SPM] implement Superior Terrific Team-Up

* fix band together second target predicate

* remove unnecessary checks in TargetsDamageTargetsEffect
* update RemoveCountersSourceCost, Gwen Stacy, and Price of Betrayal

* added support for choosing multiple counters to RemoveCountersSourceCost

* changed Price of Betrayal to use player.getMultiAmount method

* added REMOVE_COUNTERS to MultiAmountType

* create common RemoveUpToAmountCountersEffect and update cards

* update default target wording on RemoveUpToAmountCountersEffect
* change opponents filter to check oponents of drawing player instead of cards controller

* check for player and controller range
* Update card entries to use FULL_ART_USE_VARIOUS

* Add additional cards
Now only creatures get the "Must block Maarika" hint in their tooltip on mouseover
* refactor exile method names, add comments

* fix card effects checking exile with filter to process ObjectSourcePlayerPredicates

* fix card effects checking exile to respect range of influence
* Implement The Fourth Doctor

* Fix triggered ability

* Change hint and PlayFromTop effect in The Fourth Doctor

* null check

* whitespace fix

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
This reverts commit 5f22d4e5cd.
* [FIN] Implement Summon: Brynhildr

* cleanup of common classes and constructors

---------

Co-authored-by: xenohedron <12538125+xenohedron@users.noreply.github.com>
(regression from #12619, like #13215)
Failure merged commit 466f6ed385 into master 2025-09-18 08:48:11 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Failure/foul-magics#40
No description provided.
Delete branch "External/mage:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?