Commit graph

3946 commits

Author SHA1 Message Date
ssk97
ec4c79e0e0
Fix copying subabilities to no longer duplicate them (#11399)
* Fix Subability copy bug (fix #10526 )

* Cards which copy abilities of other cards should not copy subabilities.

* Enable previously-failing tests

* Find more addAbility that should be done without subabilities

* Add documentation to addAbility function

* Add warning about not using basic addAbility when copying from a source

* Invert withSubabilities to fromExistingObject
2023-11-12 19:57:39 -05:00
xenohedron
933d694b08 implement [LCI] Market Gnome 2023-11-09 21:42:57 -05:00
xenohedron
ded7eeeaa8 align DISCOVERED event to naming convention
no need for custom event class
2023-11-09 20:44:52 -05:00
xenohedron
9eeaf9cae1 fix text
fix Jade Seedstones craft cost
2023-11-09 00:39:40 -05:00
xenohedron
5c83bbe970 refactor Quartzwood Crasher; Goro-Goro and Satoru
to use DealCombatDamageControlledTriggeredAbility
2023-11-08 23:28:12 -05:00
xenohedron
4a250c48a5 implement [LCI] Kutzil, Malamet Exemplar 2023-11-08 23:09:39 -05:00
xenohedron
87a313e89c reminder text adjustment: bloodthirst 2023-11-08 22:27:34 -05:00
Jeff Wadsworth
3b90880fa3 Fixed #11381
The rest of these types of cards need to be fixed as well.
2023-11-07 17:09:56 -06:00
Jeff Wadsworth
b1e7e589ee Refactored Ent's Fury 2023-11-07 10:20:26 -06:00
Oleg Agafonov
ddc1ec8ef8 performance: improved CPU/memory usage with copy of cost's targets (related to #11285), added runtime check for wrong targets usage 2023-11-07 02:47:48 +04:00
Oleg Agafonov
d6c858ecaf performance: added day/night performance test for transform ability (disabled by default, see DayNightTest, related to #11285), added day/night rules ref 2023-11-07 01:25:15 +04:00
Oleg Agafonov
70c79fd6a6 performance: improved CPU usage in games with big amount of permanents (related to #11285) 2023-11-07 01:14:07 +04:00
Susucre
2f3161e83d [LCI] Implement Abuelo's Awakening 2023-11-05 17:11:21 +01:00
Susucre
ee60325c07 [LCI] Implement Preacher of the Schism 2023-11-05 15:38:02 +01:00
xenohedron
e27ceec5e8 fix reminder text 2023-11-04 18:41:56 -04:00
xenohedron
e122e9d512 various and sundry text fixes 2023-11-04 18:41:56 -04:00
xenohedron
26605220f7 cleanup custom source untapped conditions 2023-11-04 18:41:56 -04:00
xenohedron
595a1d6f14 add UNTAPPED option to AttachedToTappedCondition 2023-11-04 18:41:56 -04:00
xenohedron
35ec41d8e0 more text adjustments 2023-11-04 18:41:56 -04:00
xenohedron
6695358060 fixes 2023-11-04 18:41:56 -04:00
Susucre
357ebec523 fix Fungal Fortitude text 2023-11-04 18:41:30 +01:00
Susucre
674661b605 [LCI] Implement Fungal Fortitude 2023-11-04 17:10:35 +01:00
ssk97
52bb2c5d71
[WHO] added Ace's Baseball Bat, consolidate related code (#11387)
* TalruumPiper use MustBeBlockedByAllSourceEffect

* Both of Bident Of Thassa's abilities can be made generic

* Goblin Diplomats use generic class (with custom text)

* create MustBeBlockedByAtLeastOneAttachedEffect common effect

* Add Ace's Baseball Bat
2023-11-04 14:19:21 +04:00
xenohedron
987d49520a implement [LCI] Sage of Days 2023-11-04 00:14:53 -04:00
xenohedron
daecbe2071 fix #11385 - triggers once per turn
even if another effect would cause additional triggers
2023-11-03 20:52:36 -04:00
Oleg Agafonov
5b49fa4cc2 choose mode improves:
- fixed broken cards with once per turn choose (example: Galadriel, Light of Valinor, closes #11362);
- fixed cheat to skip required mode by cancel button (example: Black Market Connections, closes #11149, closes #10611);
- fixed empty modes list if nothing available to choose;
- improved compatibility with max modes and other modification effects;
- fixed that non-valid modes can be selected in some use cases;
2023-11-02 17:57:55 +04:00
xenohedron
d3cc3aa96d implement [LCI] Zoetic Glyph 2023-11-01 23:28:07 -04:00
xenohedron
33781ac614 text fixes 2023-11-01 23:28:07 -04:00
Evan Kranzler
595955a3cc
Add finality counters (#11379)
* [LCI] Implement Soulcoil Viper

* add finality counter test

* fix bug, add extra test

* [LCI] Implement Uchbenbak, the Great Mistake
2023-11-01 22:08:57 -04:00
Alexander Novotny
87921494b8
Improve trigger auto ordering and aura attachment (Lynde QOL fixes) (#10648)
* Lynde trigger references objects

* Changed triggered ability auto-order to care about targets

* Copy card test

* When a copy effect comes in as a copy of an aura,
it checks if it's already attached before asking player to attach

* add comments and null check per review

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
2023-11-01 21:40:04 -04:00
ssk97
38dd582adc
fix Learn effect to not get lesson cards from exile (#11374) 2023-11-01 21:39:43 -04:00
Susucre
bc335b949b [LCI] Implement Curator of Sun's Creation 2023-11-01 20:12:49 +01:00
xenohedron
ebf71941a9
cleanup EntersBattlefieldAllTriggeredAbility and subclasses (#11372)
* comment out rule override to use generated text instead

* new ETB Opponent trigger class

* text improvements

* update ETB cast trigger

* remove controlledtext parameter

* more text improvements

* more fixes

* lots of other fixes

* most of the remaining fixes

* fix halana text

* fix smoke shroud text

* improve text gen

* remove rule param from constructors

* minor adjustments

* whenever a player puts

* final fixes

* standardize when/whenever phrase generation
2023-10-31 21:00:45 -04:00
theelk801
688003c8e0 [LCI] Implement Gargantuan Leech 2023-10-30 21:40:20 -04:00
theelk801
1388972d4c [LCI] Implement Nicanzil, Current Conductor 2023-10-30 21:16:44 -04:00
xenohedron
32310455cb implement [LCI] Dusk Rose Reliquary 2023-10-30 19:29:16 -04:00
xenohedron
92e089663f fix more text 2023-10-30 19:24:10 -04:00
xenohedron
e802db32d3 fix Discover text 2023-10-30 01:26:55 -04:00
PurpleCrowbar
30b1ef5491
[WHO] Implement The Master, Multiplied (#11356) 2023-10-29 21:42:02 +00:00
xenohedron
69fbfe8fd6 fix some text 2023-10-29 02:21:54 -04:00
xenohedron
9b7fe2fcf6 new MoveCountersFromTargetToSourceEffect 2023-10-28 19:07:03 -04:00
xenohedron
1d93c310c3 implement [LCI] Explorer's Cache
create common MoveCountersFromSourceToTargetEffect

amend
2023-10-28 19:07:03 -04:00
xenohedron
ad66b91642 fix #11353 (InvestigateTargetEffect)
add some test cases
2023-10-28 16:54:27 -04:00
xenohedron
9733786e5d add GameEvent.EventType.EXPLORE
add tests for explore multiple times
2023-10-28 14:43:25 -04:00
Susucre
bcd8687285 [LCI] Implement Poetic Ingenuity 2023-10-28 18:46:53 +02:00
Susucre
cd9f9c9f05
[LCI] Implement the Mother Lode (#11351)
refactor DiscoverEffect to call a static doDiscover that returns the discovered card.
2023-10-28 16:49:57 +02:00
theelk801
fb0917c4e6 [LCI] Implement Enterprising Scallywag 2023-10-28 10:04:33 -04:00
Oleg Agafonov
b7ce9c80f0 refactor: improved ability's modes code (related to #11333) 2023-10-28 15:46:03 +04:00
Evan Kranzler
bc4aa6931f
Ready for review: Implement Craft mechanic (#11352)
* [LCI] Implement Spring-Loaded Sawblades / Bladewheel Chariot

* [LCI] Implement Sunbird Standard / Sunbird Effigy

* card filter needs to have an owner predicate

* [LCI] Implement Throne of the Grim Captain / The Grim Captain

* make default constructor for craft with artifact

* dedupe some code

* refactor constructors for simplicity

* add currently failing test
2023-10-27 22:32:11 -04:00
Susucre
c6441b31a5 [LCI] Implement Get Lost 2023-10-27 17:38:14 +02:00