Commit graph

41897 commits

Author SHA1 Message Date
Susucre
95deeafa86
fix [CLB] Baba Lysaga counting of card types dynamically (#10796) 2023-08-13 20:43:58 -04:00
Susucre
accb7c63bf
fix [CLB] Call to the Void (#10795) 2023-08-13 20:43:13 -04:00
Susucre
8457ce31c5
fix the CardViewer not displaying tokens (#10789) 2023-08-13 14:10:48 -04:00
theelk801
2b18dc432c [CMM] add all variants 2023-08-13 12:54:22 -04:00
xenohedron
3386ea117d Implement [40K] Dark Apostle; Sloppity Bilepiper 2023-08-13 01:17:51 -04:00
xenohedron
6fafbf0d93 new NextSpellCastHasAbilityEffect
cleanup Wand of the Worldsoul, Flockchaser Phantom to use it

text adjustments for gain abilities
2023-08-13 01:17:51 -04:00
xenohedron
817e1a813a put getCount method in SpellsCastWatcher and use it where applicable 2023-08-13 01:17:51 -04:00
xenohedron
7d170ef902 make SpellsCastWatcher a default game watcher 2023-08-13 01:17:51 -04:00
Sean Walsh
dfb337671b
[40K] Implement Belisarius Cawl (#10064)
* Implement Belisarius Cawl

* minor cleanup

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
2023-08-13 00:54:01 -04:00
xenohedron
baef93d0ec text fix: Mystic Barrier 2023-08-13 00:51:35 -04:00
Susucre
07ee4661e7
[CMM] Implement Teyo, Geometric Tactician (#10736)
* [CMM] Implement Teyo, Geometric Tactician

* rework as a RestrictionEffect (common class with Mystic Barrier; Pramikon, Sky Rampart)

* add checkMayAttackDefender test

* more Pramikon tests
2023-08-12 19:02:23 -04:00
Matt M
e49020e490
[CLB] Implemented Jade Orb of Dragonkind (#10286)
* Working with oneshot

* Swap to dual effects

* adjust tests

* adjust custom class names, fix text order

* comparison fix, null check, access modifiers

---------

Co-authored-by: Zelane <zelane@hollow.tech>
Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
2023-08-12 18:25:46 -04:00
Susucre
23cc483a09
Tests: Add Rarity Verify Test out of mtgjson data. (#10782)
* Tests: Add Rarity Verify Test out of mtgjson data.

* skip some of the Special rarity.

* remove skip (fixed in master)
2023-08-12 16:16:22 -04:00
Susucre
2d53668c96
[LTC] Implement Gilraen, Dunedain Protector (#10728)
* [LTC] Implement Gilraen, Dunedain Protector

* add tests on Gilraen

* apply review
2023-08-12 16:16:02 -04:00
Susucre
eef8f508e4
[CMM] Implement Demon of Fate's Design (#10737)
* refactor SacrificeCostManaValue to be an enum.

* [CMM] Implement Demon of Fates Design

* Add Unit Tests, including one bug on alternative cost.

* fix alternativeCosts made from dynamicCost returning that they were not activated when paid.

* fix small issues, add hint

* cleanup tests and add a couple

* Capitalize enum instances

* Minor fixes

* simplify the ContinuousEffect

* use the ConditionPermanentHint made for the Demon

* fix text
2023-08-12 15:49:06 -04:00
Susucre
0ce21d12a5
fix more rarity mismatches per mtgjson (#10784) 2023-08-12 15:48:52 -04:00
xenohedron
936a3edeb9 fix rarity in MP2 (Amonkhet Invocations) 2023-08-12 15:43:26 -04:00
xenohedron
696c209222 fix OGW booster generation 2023-08-12 15:24:36 -04:00
Susucre
2e08e86de7
Fix wrong rarities in sets files (#10783) 2023-08-12 13:30:31 -04:00
xenohedron
db209d129a
fix Snow-Covered Island rarity [J22] 2023-08-12 12:15:57 -04:00
theelk801
de29698667 [J22] add all variants 2023-08-12 08:58:50 -04:00
theelk801
2ea443b77b [LTR] add all variants 2023-08-12 08:57:07 -04:00
xenohedron
b7d2be077c
add game param to card type checks missing it (#10781) 2023-08-12 01:20:33 -04:00
Sean Walsh
d68c5ac0aa
[J22] Implement Ogre Battlecaster (#10053)
* Implement Ogre Battlecaster

* adjustments

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
2023-08-12 01:20:21 -04:00
Sean Walsh
681524ae0f
[J22] Implement Runadi, Behemoth Caller (#10034)
* Implement Runadi, Behemoth Caller

* remove comment

* adjustments

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
2023-08-12 01:20:07 -04:00
xenohedron
b0f7f0c78c Implement [J22] Mild-Mannered Librarian
closes #10031
2023-08-11 23:21:10 -04:00
xenohedron
a8d86e1587 text adjustment 2023-08-11 23:07:22 -04:00
xenohedron
98ca664b23 add LTR basic land arts 2023-08-11 22:06:36 -04:00
xenohedron
36a8a81ef1 make LTR draftable 2023-08-11 21:59:26 -04:00
xenohedron
568d68e520 fix some CMM rarities 2023-08-11 21:06:35 -04:00
xenohedron
7839c6cbff
Implement [CMM] Hatchery Sliver; fix Replicate ability (#10694)
* Implement [CMM] Hatchery Sliver

* limit ReplicateAbility to only its linked instance

* Add test for multiple instances of replicate

* add another test
2023-08-11 20:41:45 -04:00
names-are-hrad
5468e2f7e5
update modern/legacy banlists (#10779)
https://magic.wizards.com/en/news/announcements/august-7-2023-banned-and-restricted-announcement

Co-authored-by: MrMoo <>
2023-08-11 08:57:48 -04:00
Vivian Greenslade
040a9779b5
[LTR] Implement Forge Anew (#10777)
* implements Forge Anew with unit tests

* fixes equip effect and adjusts test

* fixes effect to only apply on controller's turns

* changed test location to set

* fixes comparison, fixes wording of text to match oracle text
2023-08-11 00:00:09 -04:00
xenohedron
178e408ac5 fix Samwise the Stouthearted 2023-08-09 23:29:17 -04:00
xenohedron
02108f6a62 fix Living Breakthrough 2023-08-09 23:26:30 -04:00
Vivian Greenslade
bfb3998fab
Fix Misstep; Pollen Lullaby; Icebreaker Kraken (#10776)
* fixes issues with noted cards and standardizes code formatting, adds tests to confirm bug is fixed

* updates tests to use StrictChooseMode

* cleans up effect implementation for listed cards

* adds comments for choices, fixes mistake in Misstep test

* updates filters, removes unnecessary text being set
2023-08-09 20:45:06 -04:00
PurpleCrowbar
6ea286eb89 Add CMM token images 2023-08-10 01:10:17 +01:00
PurpleCrowbar
d9a23d505a
Add image number support for command objects (#10774) 2023-08-10 00:47:32 +01:00
Grath
08bf721790
Fix Oliphaunt imports 2, this time with feeling. 2023-08-09 16:36:22 -04:00
Grath
c81625aa69
Fix imports
The perils of distracted coding.
2023-08-09 16:09:23 -04:00
Grath
c826c111bc
Fix Oliphaunt to be creatures you control. 2023-08-09 15:37:47 -04:00
Artemis Kearney
722627baa2
Create new "custom options" button/dialog, consolidate game-modifying options there (#10768)
* create CustomOptionsDialog; update NewTournamentDialog to use it

* add custom options button to new table/tournament dialogs

* fix buffer time in new table dialog

* further UI improvements

- move multiplayer options back out to NewTableDialog
- hide multiplayer options when all are disabled
- rearrange other options for consistency

* update button label to show number of active custom options

* remove commented-out code
2023-08-08 01:37:38 -04:00
xenohedron
00340a3bda
fix null SetTargetPointer (#10772) 2023-08-08 01:37:14 -04:00
Artemis Kearney
4d72e790dc
bugfix: hide Packs: label for constructed rather than hiding panel twice (#10771) 2023-08-07 16:54:30 -04:00
xenohedron
35a5cc48a7
Improve DealsCombatDamageEquippedTriggeredAbility (#10767)
* improve variable name

* add test for Jitte trample damage

* fix duplicated triggers when trampling over to player

* bring corresponding ability into alignment

* adjust authorship, comment
2023-08-06 23:04:53 -04:00
Artemis Kearney
9ba0da00ff
Basic groundwork for extra decks (contraptions, attractions) (#10378)
* extra deck cards not counted in deck size

* extra deck handling in deckbuilder

* move responsibility for extraDeckCard boolean to CardImpl

* remove redundant field copy
2023-08-06 21:06:32 -04:00
Artemis Kearney
978ebfc873
add UI for buffer time feature the right way (#10764)
* add UI for buffer time feature the right way

* save buffer time values
2023-08-06 20:00:55 -04:00
sprangg
287df7af21
Wait 2 seconds before making the draft pick for a timed out player (#10733)
* The draft session waits for 5 seconds before making the pick for the timed out player

* Formatting

* Renamed constant

* Tweak

* If the draft pick's timeout value would increase the client's pick's timer, don't set it (might happen if the client or server is lagging)

* Lowered BOOSTER_LOADING_INTERVAL and AUTOPICK_BUFFER

---------

Co-authored-by: sprangg <a@b.c>
2023-08-06 20:00:42 -04:00
theelk801
456ea87107 finish reverting my ill-advised refactor 2023-08-06 19:28:16 -04:00
theelk801
3313f7affb Revert "simplify vanishing implementation"
This reverts commit 399b65effb.
2023-08-06 19:25:05 -04:00