Commit graph

48758 commits

Author SHA1 Message Date
theelk801
dbd07b9031 and when the elk saw the breadth of his domain, he wept, for there was no more ConditionalInterveningIfTriggeredAbility to refactor 2025-06-12 19:58:54 -04:00
theelk801
59f7126f64 all refactoring ConditionalInterveningIfTriggeredAbility and no play makes the elk a dull boy 2025-06-12 19:56:43 -04:00
theelk801
79a2f80563 listening to Pet Sounds on repeat while I refactor ConditionalInterveningIfTriggeredAbility 2025-06-12 19:56:43 -04:00
theelk801
cdcda710c8 people keep asking me if I'm refactoring ConditionalInterveningIfTriggeredAbility, and I haven't really had an answer. but now yeah, I'm thinking I'm refactoring ConditionalInterveningIfTriggeredAbility 2025-06-12 19:56:43 -04:00
Grath
0f93ecdb6b Add missing target to Intimidation Tactics 2025-06-12 17:48:43 -04:00
Grath
0d888a85d2 Add missing choose to Memories Returning. 2025-06-11 23:50:31 -04:00
theelk801
94009318b7 I am once again refactoring ConditionalInterveningIfTriggeredAbility 2025-06-11 12:49:31 -04:00
theelk801
9fb082d656 I can stop refactoring ConditionalInterveningIfTriggeredAbility whenever I want 2025-06-11 09:58:16 -04:00
theelk801
15d4ca2edc I have a fever and the only prescription is more refactoring ConditionalInterveningIfTriggeredAbility 2025-06-10 14:40:43 -04:00
theelk801
cc2d234d58 oh boy here I go refactoring ConditionalInterveningIfTriggeredAbility again 2025-06-10 11:30:43 -04:00
theelk801
d80e0402dd even more refactoring of ConditionalInterveningIfTriggeredAbility 2025-06-09 18:53:44 -04:00
theelk801
c24627f175 more refactoring of ConditionalInterveningIfTriggeredAbility 2025-06-09 14:23:30 -04:00
theelk801
a35b6efb87 fix test failure 2025-06-09 12:43:48 -04:00
theelk801
1ae3392a5b [KHM] fix Rise of the Dread Marn counting noncreature permanents (fixes #13738) 2025-06-09 12:19:26 -04:00
theelk801
a895ac9803 some more refactoring of ConditionalInterveningIfTriggeredAbility 2025-06-09 12:06:11 -04:00
Jeff Wadsworth
c2daa00b74 Fixed #13729 2025-06-08 19:48:04 -05:00
Grath
e07a69710b
Fix Zenos yae Galvus and Shinryu, Transcendent Rival triggers. 2025-06-08 11:39:19 -04:00
Grath
a43846385a Use code from getCurrentSourceObjectZoneChangeCounter to lookup ZCC of actual permanent rather than ability's ZCC which is, unexpectedly, statically set to 0 by design. 2025-06-08 11:20:47 -04:00
xenohedron
47f2a4fbe5 remove some unneeded filter classes, add static filters
related to #13734
2025-06-08 01:52:14 -04:00
xenohedron
663ada11d1 minor linting 2025-06-08 00:58:45 -04:00
xenohedron
50acfad59c remove unnecessary method that missed source param 2025-06-08 00:57:07 -04:00
Grath
341f73ff7e Fix Zenos yae Galvus and Shinryu, Transcendent Rival triggers. 2025-06-08 00:54:31 -04:00
xenohedron
4e929dfbbd remove unused class 2025-06-08 00:48:53 -04:00
padfoothelix
4bc30b4b8e
[WHO] Implement The Curse of Fenric (#13718)
---------

Co-authored-by: xenohedron <12538125+xenohedron@users.noreply.github.com>
2025-06-07 23:10:34 -04:00
padfoothelix
f94e570f6d
[WHO] Implement Everybody Lives! (#13369)
also adjust Courageous Resolve

---------

Co-authored-by: xenohedron <12538125+xenohedron@users.noreply.github.com>
2025-06-07 23:10:20 -04:00
Evan Kranzler
0e179ccc1f
Refactor SourceHasCounterCondition to be an IntCompareCondition (#13724)
* refactor SourceHasCounterCondition to be an IntCompareCondition

* add comment for arguments
2025-06-07 21:03:21 -04:00
Evan Kranzler
c7f2263ddb
Update rules for Sagas (#13728)
* update saga rules

* update test

* update test
2025-06-07 21:02:26 -04:00
Susucre
8495d6a74e fix and test [FIN] Zack Fair 2025-06-07 20:09:47 +02:00
theelk801
baa52bc617 more refactoring of ConditionalInterveningIfTriggeredAbility 2025-06-07 12:28:14 -04:00
theelk801
24c9d5509e [NCC] rework Life of the Party 2025-06-07 11:43:27 -04:00
Oleg Agafonov
933750be95 tests: verify fix 2025-06-07 09:10:49 +04:00
Oleg Agafonov
1112c9516d other: added getMultiAmount testable dialogs in cheat menu (part of #13638) 2025-06-07 08:50:29 +04:00
Grath
ee1dc74b90 Add missing player.choose to Shadow, Mysterious Assassin. 2025-06-06 20:36:57 -04:00
Oleg Agafonov
d5dc85a54c GUI, deck: improved bracket level calculations (added all levels to validator panel, improved stats and visual, part of #13341) 2025-06-06 23:06:49 +04:00
jmlundeen
f511b85e3c Fix verify error 2025-06-06 12:10:53 -05:00
Oleg Agafonov
d465c9fb82 GUI, deck: improved bracket level calculations (added all infinite combos list and spellbook downloader, part of #13341) 2025-06-06 18:56:03 +04:00
Susucre
1fb4cecd6b fix [FIN] Summon: Leviathan 2025-06-06 16:09:35 +02:00
Grath
173da04c33 Fix ChooseCreatureEffect when used with non-AsEntersBattlefield.
Zenos yae Galvus was not letting you choose a creature when it entered, because getPermanentEntering returned null due to Zenos already being in play.
2025-06-05 23:45:02 -04:00
theelk801
d952e3b2ce refactor more cards using ConditionalInterveningIfTriggeredAbility 2025-06-05 12:13:59 -04:00
Oleg Agafonov
d861f67232 server: fixed that's server can't start on some wrong config settings (part 2) 2025-06-05 03:03:25 +04:00
Susucre
9de731b522 fix release config 2025-06-04 23:04:32 +02:00
theelk801
a7851f0f71 fix verify failure 2025-06-04 16:32:11 -04:00
Oleg Agafonov
17cefacea7 serve: fixed that's server can't start on some wrong config settings 2025-06-05 00:17:28 +04:00
theelk801
2bb26521c5 fix test failure 2025-06-04 16:07:39 -04:00
theelk801
d05d3bbc97 refactor some instances of ConditionalInterveningIfTriggeredAbility 2025-06-04 14:56:12 -04:00
theelk801
5fcd99ba44 fix test failures 2025-06-04 11:23:10 -04:00
theelk801
b21fe38de2 refactor some abilities to use TriggeredAbility:: withInterveningIf 2025-06-04 09:00:10 -04:00
theelk801
562bd9ffeb rework some effects to use CardUtil::getEffectValueFromAbility 2025-06-04 08:35:08 -04:00
Steven Knipe
bccbb2ee8e Rename DamagedPlayerControlsTargetAdjuster to ThatPlayerControlsTargetAdjuster 2025-06-03 20:09:21 -07:00
theelk801
d4f1d42c3e [BLB] fix implementation of Clement, the Worrywort 2025-06-03 22:04:51 -04:00