ssk97
d806a6a3be
Counter text improvements (plus a Magus Lucea Kane gameplay fix) ( #11503 )
...
* Improve text generation for some counter abilities
* Magus Lucea Kane must apply to permanent spells (bugfix, related to #11440 )
* Further improve text generation of counter text
* Text improvements to a couple cards
* Graft text improvements
* Further remove unused variable
* Be consistent on Backup ability setup, revert Thalia's Lieutenant (filter reuse means it doesn't work)
* Thalia's Lieutenant original text was slightly wrong, fixed
2023-12-03 21:42:16 -05:00
Oleg Agafonov
eaa510b265
GUI: added restriction card icon to permanent (contains all applied restrictions and requirements, #7471 )
2023-12-03 00:01:47 +04:00
xenohedron
264b73355a
refactor: improved targets that find a [type1] card and/or a [type2] card ( #11497 )
2023-12-01 19:26:30 +04:00
ssk97
f3e310cfd3
Fixed tags cost and MageObjectReference usage ( #11500 )
...
* Fix costs tag clearing while permanent still on the battlefield
* Improved version of game.getPermanentOrLKIBattlefield with MageObjectReference
* Improve documentation
2023-12-01 19:24:39 +04:00
xenohedron
35f4a898f9
Small rework for autochoosing color of mana to add ( #11495 )
...
fix #11494
2023-12-01 00:49:42 -05:00
xenohedron
b4a58a339d
Merge pull request #11492 from xenohedron/clean-watchers
...
refactor: align game default watchers with usage
2023-12-01 00:49:11 -05:00
Jeff Wadsworth
9131347698
Fixed #11491
2023-11-30 22:23:48 -06:00
xenohedron
201c1ef443
(can't remove PlanarRollWatcher without test rework)
2023-11-30 01:00:48 -05:00
xenohedron
6155f2d403
remove DamageDoneWatcher from default watchers
2023-11-30 00:59:21 -05:00
xenohedron
c164d70135
remove PlayersAttackedThisTurnWatcher from default watchers
2023-11-30 00:56:32 -05:00
xenohedron
1f764515f6
merge MorbidWatcher with CreaturesDiedWatcher
2023-11-30 00:11:10 -05:00
xenohedron
1ac4fe4e4a
add doc comments for usage of default watchers
2023-11-29 20:57:12 -05:00
xenohedron
a4cc086775
cleanup usages of BlockedAttackerWatcher
2023-11-29 20:43:17 -05:00
xenohedron
cd439ab8c8
remove another game default watcher with one usage
2023-11-29 20:40:57 -05:00
xenohedron
f801c9851e
move watchers used only in Arboria effect
2023-11-29 20:37:47 -05:00
xenohedron
37722a58c2
more watcher cleanup
2023-11-29 20:32:36 -05:00
xenohedron
f7d70a7b11
refactor: AttackedThisTurnWatcher is a default watcher
...
close #10982
2023-11-29 20:27:30 -05:00
xenohedron
9fbdede64b
text cleanup: additional combat phase
2023-11-28 22:20:49 -05:00
Jeff Wadsworth
70069f2937
Fixed #11451
2023-11-28 17:13:15 -06:00
xenohedron
395d858056
text fix
2023-11-28 17:28:38 -05:00
xenohedron
05e2cf11e7
refactor: replacement effects don't use apply method now ( #11484 )
2023-11-28 11:17:28 +04:00
xenohedron
02eafaf062
simplify text gen for DamageCantBePreventedEffect
2023-11-27 23:47:10 -05:00
ssk97
2abe61643c
[LTC] Implementations part 2/4 ( #11470 )
...
* Aragorn, Hornburg Hero
* Minas Morgul, Dark Fortress
* Rohirrim Chargers
2023-11-27 23:41:20 -05:00
Oleg Agafonov
3a92d67d10
tests: added verify test to check miss of controlled filter in equip abilities (related to #11473 );
2023-11-27 23:08:23 +04:00
Oleg Agafonov
6e3fe7ec46
Cascade and other "cast spell without paying" abilities - added card popup support for casting card ( closes #11355 )
2023-11-27 00:49:37 +04:00
Oleg Agafonov
99cbddb8b8
Merge pull request #11431 from Susucre/lci-mana-tracking
...
[LCI] Implement Thousand Moons Smithy // Barracks of the Thousand and Brass's Tunnel-Grinder // Tecutlan, the Searing Rift
2023-11-25 17:13:54 +03:00
Oleg Agafonov
fe3230f489
game: fixed game error with Berserker's Frenzy and other cards (miss copyable class in watcher);
2023-11-25 17:43:18 +04:00
Oleg Agafonov
63290d3ed6
GUI: fixed not working card popup near screen border, improved card popup for chat and choose dialogs;
2023-11-25 17:27:59 +04:00
xenohedron
81f97c3b0e
fix more text
2023-11-25 02:59:06 -05:00
xenohedron
867a8f54b0
fix #11456 (Become Brutes)
...
CreateRoleAttachedTargetEffect changed to use all targets, not just first
2023-11-25 02:20:11 -05:00
xenohedron
47197f7c39
implement [LCC] Xavier Sal, Infested Captain
...
adjustments/docs in RemoveCounterCost
2023-11-25 01:49:19 -05:00
Oleg Agafonov
53add71826
Improved network stability and other related fixes:
...
* server: fixed that a critical errors ignored in user commands threads (now it will be added to the logs);
* network: fixed frozen user responses in some use cases;
* network: fixed accidental and incorrect user responses (only latest response will be used now);
* network: improved freeze logs, added problem method name and code's line number;
* cheats: removed outdated deck and card load logic (only init.txt commands supports now);
* cheats: fixed wrong priority after add card dialog (closes #11437 );
* cheats: improved stability and random errors on cheat executes (related to #11437 );
* docs: added details on network and thread logic, human feedback life cycle, etc (see HumanPlayer, ThreadExecutorImpl);
2023-11-24 21:22:16 +04:00
xenohedron
dd459c484f
followup text fixes
2023-11-23 01:54:51 -05:00
xenohedron
109547a1ad
lots of text fixes
2023-11-23 01:54:51 -05:00
xenohedron
a7de73723f
BecomesCreatureAllEffect text adjust / simplify
2023-11-23 01:54:51 -05:00
xenohedron
1c6c68e1a4
some text fixes
2023-11-23 01:54:51 -05:00
Oleg Agafonov
75958e3710
refactor: improved and reorganized client-server api, added additional logs, fixed miss admin checks for some commands
2023-11-23 09:12:02 +04:00
ssk97
e43e918c67
Conditional mana - fixed that some mana cant be used for paying “counter unless” cost and other things ( #11447 )
...
* Add tests for conditional mana usage with soft counterspells
* Fix "to cast" conditions on common ManaCondition classes
* Add fix to all remaining ManaCondition classes
* SimpleActivatedAbilityConditionalMana is tested to pay for a soft counterspell activated ability
* Remove now-unused imports
2023-11-23 01:37:45 +04:00
ssk97
2cc9957753
Costs Tag Tracking part 4: Convoke ( #11446 )
...
* Switch Convoke to using costs tag system
* Add Convoke copy/clone tests
* update author name on sufficiently changed files
* Remove now-unused CONVOKED event
2023-11-23 01:31:56 +04:00
xenohedron
4977fea307
Merge pull request #11417 from ssk97/TagTracking3_KeywordAbilities
...
Costs Tag Tracking part 3: Most keyword abilities
2023-11-20 21:28:40 -05:00
Daniel Cowman
8a007c9953
Fix conditional "must be blocked if able" ( #11436 )
...
* Add missing overrides to ConditionalRequirementEffect.java
2023-11-19 21:49:19 -05:00
xenohedron
1816c8ad73
many the text fixes
2023-11-19 21:37:37 -05:00
xenohedron
8f89253b58
refactor triggers checking batch damage for one player ( #11435 )
2023-11-19 16:51:54 -05:00
Oleg Agafonov
6e99a3653a
Initiative abilities - added card hint with initiative info to all related cards ( closes #11424 );
...
tests: added verify test for miss initiative card hint;
gui: fixed wrong max amount of card hint windows;
2023-11-19 23:00:42 +04:00
Oleg Agafonov
225da087f9
Monarch abilities - added card hint with monarch info to all related cards ( #11424 );
2023-11-19 22:38:25 +04:00
Susucre
d159c45ff0
[LCI] Implement Brass's Tunnel Grinder // Tecutlan the Searing Rift
2023-11-19 18:27:35 +01:00
Susucre
f45c9e8ee9
[LCI] Implement Thousand Moons Smithy // Barracks of the Thousand
2023-11-19 17:54:57 +01:00
Oleg Agafonov
74862c83b2
Merge fix
2023-11-19 19:28:04 +04:00
Oleg Agafonov
27c9543f62
The Ring Emblem - fixed not working 3rd effect with blocker sacrifice ( closes #11425 ), added docs and usage example for BLOCKER_DECLARED and CREATURE_BLOCKED game events
2023-11-19 19:16:55 +04:00
Steven Knipe
0058c2fb94
Use deepCopyObject in PlayerImpl
2023-11-19 00:33:56 -08:00
