master #67

Merged
Failure merged 46 commits from External/mage:master into master 2026-07-05 21:52:11 -07:00
Owner
No description provided.
* Fantasticar token

* [MSC] Implement The Fantasticar

* Apply suggestions from code review

Co-authored-by: Muz <muz@users.noreply.github.com>

* Code review cleanup

* Fantasticar token fixup

* Fix Fantasticar not counting for its 4 noncreature
spells count trigger if it became a creature on the
battlefield, by means of a custom watcher

---------

Co-authored-by: Muz <muz@users.noreply.github.com>
Fix Sword of the Meek trigger with Elesh Norn
- copy abilities: fixed that flickering copied tokens can affect original permanents (example: rooms or saga, close #14409, #14548);
- non-modal double faced cards: fixed wrong mana value for back sides, for copied permanents (#15471);
- modal double faced cards: fixed wrong mana value for copied permanents (close #15415, #15471);
- refactor: simplified rooms code and removed some code hacks;
- refactor: improved docs;
For better onboarding and shared settings for new devs with local or
online environment.

It's a pre-configured dev container image with all java, script, build,
and debug tools. It's also **use xmage's code formating (intellij idea
style)**. More details about dev containers here: https://containers.dev

You can use dev containers from local machine or any cloud services like
GitHub Codespaces. It's the most easiest and fastest way to project
onboard and start to developing.

If you need your own tools like AI then copy to new folder and modify
locally.

Warning: if build or run fails then search all
<groupId>org.openjfx</groupId> and update version to 17.0.19 for
compatibility with Java 25.

How-to use:
1. Install Docker, VS Code and extension Dev Containers
(ms-vscode-remote.remote-containers)
2. Open project's root folder and confirm VS Code to open it by
container
3. Run mvn install -DskipTests on first open to generate all files
4. Run tests, debug, or run client and server as usual, see wiki page:
https://github.com/magefree/mage/wiki/Setting-up-your-Development-Environment#visual-studio-code-vsc
5. GUI client available by web-browser at http://localhost:6080

P.S. Wiki page also updated with same instructions
Update comment on Token Copy Flicker test to reference GH issue, clarify that test is passing
Some checks failed
Java CI with Maven / build (pull_request) Has been cancelled
e204a3e0c9
Failure merged commit 7d7ddd39ec into master 2026-07-05 21:52:11 -07:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Failure/foul-magics!67
No description provided.