Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases 14 Packages Activity Actions

download-on-fly #62

Merged
Failure merged 56 commits from download-on-fly into master 2026-04-05 22:03:21 -07:00
Conversation 0 Commits 56 Files changed 103 +3193 -185
Failure commented 2026-04-05 21:59:23 -07:00
Owner
Copy link
No description provided. 
The issue seems to be that `ManaCondition.apply()` is called at multiple
points: first passing the entire `ManaCosts` of the overall cost, then
passing each individual `ManaCost` sub-cost.  The first call is
effectively just checking whether the conditional mana can contribute
towards paying the cost at all.  So we can just allow it there, and then
filter more granularly during the follow-up calls where each sub-cost is
checked.

Fixes f0ca05e
Fixes https://github.com/magefree/mage/issues/9796
Fix Jegantha, the Wellspring mana payment calculations
These three were not working since they were calling the deprecated
`Abilities.removeIf`.  Replacing with equivalent
`Permanent.removeAbility` calls fixes the issue.

Co-authored-by: matoro <matoro@users.noreply.github.com>
Co-authored-by: balazskristof <20043803+balazskristof@users.noreply.github.com>
Reviewed-on: #63
Failure merged commit e142b386a4 into master 2026-04-05 22:03:21 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Failure/foul-magics!62
No description provided.