master #60

Merged
Failure merged 11 commits from External/mage:master into master 2026-03-25 22:10:56 -07:00
Owner
No description provided.
Not `getChoice()`, this can't be tested since it breaks for human
players only where the hint text (e.g. "(me)") is appended.

Fixes 1056e4c
Creature type choice to string must use `getChoiceKey()`
This seems to be two bugs in one.  First, `getPlayerId()` refers to the
controller of the ability source in `ObjectSourcePlayerPredicate`, so we
should refer to `getObject().getControllerId()` instead.

Secondly, it seems that by the time this predicate is evaluated, the
dying creature has left the battlefield already, so the greatest power
would be calculated from among remaining creatures controlled by that
player (or `Integer.MIN_VALUE` otherwise).  That's fine, we still know
to match if our power is greather than or equal to it.

Fixes: 867fa64156
Fixes: https://github.com/magefree/mage/issues/14395

Co-authored-by: matoro <matoro@users.noreply.github.com>
[SOS] Implement Pull from the Grave
Some checks failed
Java CI with Maven / build (pull_request) Has been cancelled
91548d024d
Failure merged commit 371c7f8d69 into master 2026-03-25 22:10:56 -07:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Failure/foul-magics!60
No description provided.