Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

master #10

Merged
Failure merged 7 commits from External/mage:master into master 2024-12-27 16:18:30 -08:00
Conversation 0 Commits 7 Files changed 15 +319 -41
Failure commented 2024-12-27 16:18:16 -08:00
Owner
Copy link
No description provided.
Failure added 7 commits 2024-12-27 16:18:20 -08:00 
* fix a bug in Sharae of Numbing Depths which caused the ability to trigger when owner's permanents got tapped.

* Fix Sharae of Numbing Depths
trigger on combat damage only, regression from #13066
refactor: fixed that Defiant Vanguard depends on debug data;
Handle the case where a 'must be blocked if able' creature is attacking but there aren't enough available creatures to block it.
* [refactor/bugfix] use rule 802.2a where appropriate.

Many effects which relied on getDefendingPlayerId would fail if the attacking creature had been removed from combat before they resolved, in which case the defending player ID would be null. This fixes these issues.

* Add test for removing attacking creature with Defending Player triggered ability.

Change allowFormer to be true by default, reduce falses to only necessary cases.
Failure merged commit e69dd75c8f into master 2024-12-27 16:18:30 -08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Failure/foul-magics#10
No description provided.
Delete branch "External/mage:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?