Commit graph

18 commits

Author SHA1 Message Date
xenohedron
faeca638de refactor: clean up some superfluous null filters in optionals 2024-11-30 14:27:15 -05:00
xenohedron
44893028f5
refactor: Constructor access modifier cleanup (#11644)
* ContinuousRuleModifyingEffectImpl

* OneShotEffect

* ContinuousEffectImpl

* fix CRLF

* *EffectImpl

* *Effect

* DoIfCostPaid

* cleanup token copy constructors -> private

* fix build error from misspelled class name
2024-01-13 00:53:22 -05:00
Oleg Agafonov
a9152e886f refactor: improved ContinuousRuleModifying effects:
* removed unused apply methods;
* added miss overrides of checksEventType (related to wrong event usage, see 5f2edde20c).
2023-09-22 21:32:55 +04:00
Susucre
de687c7f0c
refactor: Clean all copy constructors in cards starting C (#11123) 2023-09-08 23:55:31 -04:00
Evan Kranzler
deb29c0659 replaced instances of Optional::of with Optional::ofNullable (fixes #9183) 2022-06-29 18:32:15 -04:00
Evan Kranzler
015444d00f [2X2] various text fixes 2022-06-29 17:36:16 -04:00
Alex Vasile
919f320086 Made hint optional for Equip 2022-02-06 21:10:37 -05:00
Oleg Agafonov
07ddad6e48 Game: fixed rare bugs in some cards after rollback or cancel actions:
* Cumulative upkeep cost - fixed that it can lost payed state (cards: Aboroth, Karplusan Minotaur, Psychic Vortex, Sheltering Ancient);
 * Effects - fixed that it can lost selected targets or other settings (cards: Citadel of Pain, Crimson Honor Guard, Curfew, Leveler, Mana Cache, Monsoon, Paradigm Shift, Saprazzan Bailiff);
 * Exile all cards from graveyard ability - fixed that it can lost targets (example: Agent of Erebos);
 * Melee ability - fixed that it can lost targets (example: Adriana, Captain of the Guard).
2021-07-07 16:51:53 +04:00
Evan Kranzler
56603ffcd2 refactored card copy methods to be private 2021-02-02 17:07:37 -05:00
Oleg Agafonov
db239a1055 Refactor: replaced sourceId by source and introduced source param in some methods; 2020-12-12 20:23:19 +04:00
Ingmar Goudt
09dd9d5a26 include more player null checks 2018-12-31 00:56:03 +01:00
igoudt
c456a1961e add more isActivePlayer and isAttachedTo calls 2018-07-09 21:25:04 +02:00
GrayedFox
3953f3dbdd
remove all MIT copyright notices from files 2018-06-02 17:59:49 +02:00
Evan Kranzler
a6e51e592b Changed all card classes to final
I was tired of the "overridable method call in constructor" warning and card classes should be final anyway
2018-05-21 10:53:44 -04:00
Evan Kranzler
245bf2f2df Refactored subtypes to enum 2017-09-07 21:18:19 -04:00
LevelX2
cd6c7623ed * Added missing imports, imports reorg. 2017-07-23 16:29:29 +02:00
fireshoes
55b433ae36 [AKH] Added 3/27 spoilers to mtg-cards-data.txt. Implemented several of the new cards. 2017-03-28 22:25:29 -05:00
spjspj
21d6e9161d spjspj - Curse of Vengeance + Conqueror's Flail C16 2016-10-31 00:25:28 +11:00