Commit graph

1816 commits

Author SHA1 Message Date
chesse20
e8892badf1
Fix perpetual use toughness as power of Walking bulwark (#10138)
* attempted fix

* super constructors work like this?

* better use of super and java

* try this again

* fix un-needed code

* remove commented code

* missed some

* Simplify Constructors
2023-05-02 19:59:17 -04:00
Oleg Agafonov
e848f85e81 BecomesCreatureTargetEffect - improved text generation 2023-04-30 18:11:57 +04:00
xenohedron
3df7f6940d
More text fixes (#10296)
* Fix text: Tattoo Ward (and similar "doesn't remove {this}")

* Fix text: Demoralize

* Fix text: Keep Watch

* Fix Slithery Stalker (ability is not optional)

* Fix text: Rain of Filth
2023-04-30 09:55:43 -04:00
Oleg Agafonov
f86cf176d7 Tokens rework:
- added reminder / helper tokens support (example: Copy, Morph, Day // Night, related to #10139);
 - added verify checks for reminder tokens;
 - added images download for reminder tokens;
2023-04-27 19:05:31 +04:00
xenohedron
0e1e6a0f21
Text fixes (cantrips with line break) (#10284)
* Fix text: Teleportal, Weapon Surge, Mizzium Skin

* Fix text: Cantrips with line break (early sets)

* Fix text: Cantrips with line break (later sets)

* Fix text: {tap} in strings, capitalization of gained abilities, misc
2023-04-27 19:05:11 +04:00
Evan Kranzler
726e289646
Implement DFC tokens for Incubate (#10231)
* remove incubate skip

* initial implementation of DFC tokens

* separate incubator back face to separate class

* small refactor to token copy function

* token copies now have back faces as well

* effects which modify token copies now correctly apply to both faces

* add skip for exception

* tokens now enter transformed correctly

* [MOC] remove skip for incubate

* fix verify failure
2023-04-27 19:03:25 +04:00
xenohedron
9abaa75bd4
Various text fixes (#10251)
* Fix text: Invigorate (fixes #8708) - override

* Fix text: sacrifice multiple permanents (as cost)

* Fix text: Coral Colony - override and add hint

* Fix text: Corpse Harvester (fixes #7837) - override

* Fix text: Solitary Camel, Sidewinder Naga

* Fix text: Malicious Advice

* Fix text: Ray of Command

* Fix text: Retreat to Hagra

* Fix reminder text for "End the turn."

* Fix text: Elspeth, Undaunted Hero

* Fix text: Gideon, Champion of Justice

* Fix text generation for condition: no counters

* Fix text: PhantasmalSphere

* Fix text: Retaliation

* Fix text generation for additional cost: discard X cards

* Fix text: Soul Separator

* Fix text: Thundermaw Hellkite

* Fix text: Torment of Hailfire

* Fix text: Twilight Prophet

* Fix text: ETB cantrips next turn's upkeep

* Fix text: Venser's Journal
2023-04-25 23:30:00 +04:00
xenohedron
1780972f71
Refactor to clean up base P/T setting and fix text generation (#10264)
* Adjust constructors to simplify

* Refactor to remove duration parameter for CDA (always end of game)

* Fix warnings

* Druid Class not CDA

* Entropic Specter fixup

* Further constructor simplification

* Analogous simplification for setting power only

* Analogous simplification for setting toughness only

* Remove superfluous parameter

* Set fields final
2023-04-24 17:43:18 +04:00
theelk801
22946bb35e [MOC] Implement Path of the Schemer 2023-04-23 17:13:31 -04:00
theelk801
7fc5943b07 [MOC] Implement Path of the Animist 2023-04-23 17:13:31 -04:00
theelk801
9385a31c4a [LTR] Implement Frodo, Sauron's Bane 2023-04-23 10:55:12 -04:00
theelk801
30a530cff0 [LTR] Implement Gollum, Patient Plotter 2023-04-23 10:00:01 -04:00
Oleg Agafonov
1dc7dcc94c Fixed images info copy in morph and other copy abilities 2023-04-21 11:39:03 +04:00
Oleg Agafonov
689b93d005 Refactor: improved choose cards method to use source param (fixed NPE like #10233, #9974 and other bugs with choose cards) 2023-04-21 11:02:57 +04:00
xenohedron
ba461d9af0
Fix Alloy Golem color set duration (#10195) 2023-04-20 18:23:46 -04:00
xenohedron
68b3fc80e9
Fix Vapor Snare effect (#10188)
* Fix Vapor Snare and refactor "unless you return a land" effects to use correct static filter

* Fix capitalization of return to hand cost

* Fix capitalization of sacrifice unless pays effect
2023-04-20 18:22:59 -04:00
theelk801
c4ebe4ae8b [MOC] various text fixes 2023-04-18 18:34:57 -04:00
amoscatelli
6059422afc
[J22] Implement Alandra, Sky Dreamer (#10219)
* Alandra Sky Dreamer
DrawSecondCardTriggeredAbility refactored into DrawCardTriggeredAbility
DynamicValue support for DrawCardTriggeredAbility
DynamicValue support for BoostAllOfChosenSubtypeEffect

* cardNumber as int
static use of cardwatcher

* removing spaces

* FaerieMastermind and ZimoneAndDina using the new generic DrawCardTriggeredAbility

* AlandraSkyDreamer and DrawCardTriggeredAbility test

* renaming DrawCardTriggeredAbility to DrawNthCardTriggeredAbility

* merging the boost effects into a single ability

* merging two effects to the same ability

* text added to effects

---------

Co-authored-by: drago <drago@192.168.1.72>
2023-04-17 09:12:18 -04:00
theelk801
c025349791 [MOM] Implement Vorinclex 2023-04-14 21:09:22 -04:00
theelk801
dd91a58c85 [MOM] Implement Elesh Norn 2023-04-14 20:12:25 -04:00
theelk801
8d7b73151c [MOM] various text fixes 2023-04-13 22:44:42 -04:00
Evan Kranzler
947351932b
Ready for Review: Implementing Battles (#10156)
* add types and subtypes

* add startingDefense attribute

* [MOM] Implement Invasion of Ravnica / Guildpact Paragon

* fix two small errors

* refactor various instances of "any target"

* fully implement defense counters

* battles can now be attacked

* [MOM] Implement Invasion of Dominaria / Serra Faithkeeper

* [MOM] Implement Invasion of Innistrad / Deluge of the Dead

* [MOM] Implement Invasion of Kaladesh / Aetherwing, Golden-Scale Flagship

* [MOM] Implement Invasion of Kamigawa / Rooftop Saboteurs

* [MOM] Implement Invasion of Karsus / Refraction Elemental

* [MOM] Implement Invasion of Tolvada / The Broken Sky

* simplify battle info ability

* fix verify failure

* some more fixes for attacking battles

* [MOM] Implement Invasion of Kaldheim / Pyre of the World Tree

* [MOM] Implement Invasion of Lorwyn / Winnowing Forces

* [MOM] Implement Invasion of Moag / Bloomwielder Dryads

* [MOM] Implement Invasion of Shandalar / Leyline Surge

* [MOM] Implement Invasion of Belenon / Belenon War Anthem

* [MOM] Implement Invasion of Pyrulea / Gargantuan Slabhorn

* [MOM] Implement Invasion of Vryn / Overloaded Mage-Ring

* [MOM] Implement Marshal of Zhalfir

* [MOM] Implement Sunfall

* implement protectors for sieges

* partially implement siege defeated trigger

* fix verify failure

* some updates to blocking

* [MOM] Implement Invasion of Mercadia / Kyren Flamewright

* [MOM] Implement Invasion of Theros / Ephara, Ever-Sheltering

* [MOM] Implement Invasion of Ulgrotha / Grandmother Ravi Sengir

* [MOM] Implement Invasion of Xerex / Vertex Paladin

* add initial battle test

* fix verify failure

* [MOM] Implement Invasion of Amonkhet / Lazotep Convert

* [MOM] update spoiler

* update how protectors are chosen

* update text

* battles can't block

* add control change test

* rename battle test for duel

* add multiplayer test

* [MOM] Implement Invasion of Alara / Awaken the Maelstrom

* [MOM] Implement Invasion of Eldraine

* [MOM] Implement Invasion of Ergamon / Truga Cliffhanger

* [MOM] Implement Invasion of Ixalan / Belligerent Regisaur

* battles now cast transformed (this is super hacky but we need to refactor TDFCs anyway)

* add TODO

* add ignore for randomly failing test

* a few small fixes

* add defense to MtgJsonCard (unused like loyalty)

* implement ProtectorIdPredicate

* small fixes
2023-04-13 20:03:16 -04:00
Oleg Agafonov
01caeed298 Merge fix 2023-04-13 17:06:22 +04:00
theelk801
312cff0c0f [MOM] various text fixes 2023-04-11 09:32:31 -04:00
Sean Walsh
7db278bdf1
Implement Brazen Cannonade, and new UntilEndOfNextCombatStep duration (#10047) 2023-04-10 20:36:21 -04:00
theelk801
eb27c30409 [MOC] Implement Blight Titan 2023-04-09 09:09:01 -04:00
Evan Kranzler
b3245e0238
Revert "[J22] Implement Alandra, Sky Dreamer and refactor of DrawSecondCardTriggeredAbility (#10092)" (#10193)
This reverts commit 0ebaeb20c7.
2023-04-08 21:42:50 -04:00
theelk801
f409a72221 [MOM] Implement Enduring Bondwarden 2023-04-05 09:30:17 -04:00
theelk801
b4e2059a61 [MOM] Implement Ozolith, the Shattered Spine 2023-04-04 19:31:17 -04:00
theelk801
96cf6b2927 [MOM] Implement Elvish Vatkeeper 2023-04-04 08:16:37 -04:00
theelk801
df5f124966 [MOM] Implement Merciless Repurposing 2023-04-02 16:00:58 -04:00
amoscatelli
0ebaeb20c7
[J22] Implement Alandra, Sky Dreamer and refactor of DrawSecondCardTriggeredAbility (#10092)
DrawSecondCardTriggeredAbility refactored into DrawCardTriggeredAbility
DynamicValue support for DrawCardTriggeredAbility
DynamicValue support for BoostAllOfChosenSubtypeEffect

Co-authored-by: drago <drago@192.168.1.72>
2023-04-01 23:45:18 +04:00
Oleg Agafonov
b632d89caa Refactor: fixed wrong usage of getSourceObjectIfItStillExists (fixed error "cannot be cast to Permanent"); 2023-03-26 13:10:00 +04:00
Oleg Agafonov
a15a0daa04 Fixed potential NPE errors in getPhase usage (fixed Berserker's Frenzy, etc) 2023-03-25 16:01:27 +04:00
Oleg Agafonov
a7ab25a5b5 * Your opponents can't cast - fixed game error on some usage (NPE fix) 2023-03-25 15:14:02 +04:00
Oleg Agafonov
22552ede47 * Goad all ability: fixed game error in some use cases (NPE fix) 2023-03-25 14:54:40 +04:00
Oleg Agafonov
a7480aeab1 * Game: fixed random sort order of choices in choose dialogs 2023-03-21 03:11:55 +04:00
PurpleCrowbar
bd2678242d Improve grammar and written clarity on Commander zone replacement effect. Still works with Oathbreaker 2023-03-15 03:49:26 +00:00
bobwoco
6102ccee53
* Clash ability - fixed that some clash cards can broke the server (#10097)
Co-authored-by: Ethan Ward <ethanandrewward@gmail.com>
2023-03-05 11:29:46 +04:00
Merlingilb
716e7dc18d
Fixed Sith Manipulator: added new effect to send target permanent to owners library (#9800)
Co-authored-by: Daniel Eberhard <daniel.h.e@gmx.de>
2023-03-04 16:51:36 +04:00
Oleg Agafonov
409f4eb36c
Merge pull request #9814 from Merlingilb/add-set-expansion-star-wars-rise-of-skywalker
Added set expansion star wars "rise of skywalker"
2023-03-04 16:48:38 +04:00
Oleg Agafonov
930d18a77d * Alluring Siren - fixed that it forced to attack any player instead controller (#9939, #9963) 2023-02-25 16:21:07 +04:00
Sean Walsh
4f82cc0287
[ONE] Implement Bladehold War-Whip (#10022) 2023-02-21 03:10:04 +00:00
PurpleCrowbar
c0dfa160b1 Fix some string builder issues 2023-02-13 13:10:10 +00:00
Grath
7172027cde
[CLB] Implement Minthara, Merciless Soul (#9972) 2023-02-12 19:24:23 +00:00
PurpleCrowbar
b0384dc09c Fix build verify 2023-02-09 18:46:19 +00:00
PurpleCrowbar
f697f92a63
[ONE] Implement Vraska, Betrayal's Sting (#9933) 2023-02-09 18:19:30 +00:00
Grath
a151e979e5
[ONE] Implement Tekuthal, Inquiry Dominus (#9921) 2023-01-28 18:21:34 -05:00
theelk801
a10180f30d simplify proliferate effect 2023-01-28 10:18:24 -05:00
bobwoco
7b8dd44e7a
Fix Mistmeadow Witch behavior when flickering itself; also fixes #8504 (#9880)
Co-authored-by: Ethan Ward <ethanandrewward@gmail.com>
2023-01-27 21:07:45 -06:00