Commit graph

11 commits

Author SHA1 Message Date
Susucre
b672fd6da5
refactor: clean package-private copy constructors in cards starting A to G (#11125) 2023-09-08 23:55:54 -04:00
Alex Vasile
a2162ec3e7
Refactor: private fields and performance tweaks (#9625)
1a. Make `costs`, `manaCosts`, and `manaCostsToPay` private in `AbilityImpl` with access through getters/setters 
1b. fix cost adjuster for imprinted cards affected by the above

2a. Lazy instantiation for rarely used `data` field in `TargetPointerImpl`

3a. Pre-allocate certain array sizes in `Modes` and `CostsImpl`

4a. Make `manaTemplate` private in `BasicManaEffect`, copy when passing outside the class 
4b. Don't copy `manaTemplate` in copy constructor since it doesn't change 
4c. Add comments explaining copy usage for `manaTemplate` 
4d. Remove redundant variable assignment and make fields final 

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
2023-08-27 17:58:19 -04:00
Evan Kranzler
56603ffcd2 refactored card copy methods to be private 2021-02-02 17:07:37 -05:00
igoudt
9f06046f22 add isOwned and isControlled methods. remove some null-checks, remove some unnecessary casts 2018-07-04 14:24:11 +02:00
GrayedFox
3953f3dbdd
remove all MIT copyright notices from files 2018-06-02 17:59:49 +02:00
Evan Kranzler
a6e51e592b Changed all card classes to final
I was tired of the "overridable method call in constructor" warning and card classes should be final anyway
2018-05-21 10:53:44 -04:00
LevelX2
a84dc233c3 * Cleaned up some unnecessary checks for FlashbackAbility due to the old Flashback implementation. 2018-05-01 01:11:47 +02:00
LevelX2
cd6c7623ed * Added missing imports, imports reorg. 2017-07-23 16:29:29 +02:00
fireshoes
55b433ae36 [AKH] Added 3/27 spoilers to mtg-cards-data.txt. Implemented several of the new cards. 2017-03-28 22:25:29 -05:00
JOAC69
59f88047e4 Modify cards 2016-10-04 20:06:28 -05:00
JOAC69
4b8d31e5f4 Move cards 2016-10-04 19:58:48 -05:00
Renamed from Mage.Sets/src/mage/sets/ninthedition/DefenseGrid.java (Browse further)