Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions
41645 commits 5 branches 220 tags 1.1 GiB
Commit graph

1983 commits

Author SHA1 Message Date
Susucre
aa71f0ba8a
Refactor DoIfCostPaid; Inform player on cost not paid. (#10942) 2023-08-26 17:29:30 -04:00
xenohedron
4d03deda12
Revert "[WOE] Implement The End (#10921)" (#11040) 
This reverts commit fe93d68b1c.
 2023-08-26 17:28:09 -04:00
xenohedron
66cc15ed4b
Cleanup copy methods (#11038) 
* remove System.out.println
* Card copy() covariant return
* Effect copy() covariant return
* Cost copy() covariant return
* Ability copy() covariant return
* ContinuousEffect copy() covariant return
 2023-08-26 16:47:54 -04:00
Susucre
fe93d68b1c
[WOE] Implement The End (#10921) 2023-08-26 16:45:51 -04:00
xenohedron
ed4a1bf33f [WOE] text fixes 2023-08-26 00:02:40 -04:00
Susucre
7a93681112
fix Tree of Redemption (#11024) 2023-08-25 21:11:08 -04:00
Susucre
8e36a178a5
[WOE] Implement Pollen-Shield Hare (#10932) 
* [WOE] Implement Pollen-Shield Hare

* apply review

---------

Co-authored-by: Evan Kranzler <theelk801@gmail.com>
 2023-08-24 21:20:13 -04:00
Susucre
493cb811d5
[WOE] Implement Gruff Triplets (#10791) 
* [WOE] Implement (Leaked) Gruff Triplets

* fix name predicate

* remove unecessary file with wrong predicate

---------

Co-authored-by: Evan Kranzler <theelk801@gmail.com>
 2023-08-24 18:26:11 -04:00
Susucre
5cedc3258a
Cleanup now that server is no longer sending MageObject in ClientMessage (#10986) 2023-08-24 14:22:03 +04:00
xenohedron
6624e141c6 cleanup GainAbilityTargetEffect 
remove unused parameters

strip reminder text
 2023-08-24 00:51:47 -04:00
Susucre
c047829614
[WOE] Implement Devouring Sugarmaw (#10969) 
* [WOE] Implement Devouring Sugarmaw

* fix adventure cost

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
 2023-08-23 20:38:26 -04:00
ssk97
a756529e05
Fix casting commander transformed (#10790) 
Remove CastCommanderAbility and instead apply the modification directly
 2023-08-24 03:30:09 +04:00
Susucre
65dba6c92d
[WOE] Implement Cheeky House-Mouse (#10945) 2023-08-22 23:14:04 -04:00
Susucre
4d3daaa5fa
[WOE] Implement Rotisserie Elemental (#10944) 2023-08-22 20:19:25 -04:00
xenohedron
4af977289e
refactor effects "you may cast... from... graveyard... exile it instead" (#10926) 
* cleanup exiling cast spells

* common class MayCastTargetThenExileEffect

* fix zcc check

* add test suite
 2023-08-21 00:26:09 -04:00
xenohedron
e02df1353a
cleanup discard effects (#10924) 
* change text generation to use target

* remove a constructor

* condense another constructor

* condense numberCardsToDiscard constructors

* fully remove TargetController

* chaining for optional parameter

* new LookTargetHandChooseDiscardEffect
 2023-08-20 13:30:44 -04:00
xenohedron
035913988a
refactor: standardize to CantAttackYouAllEffect (#10923) 
* adjust CantAttackYouAllEffect text, check permanent is planeswalker

* switch 3 cards to main class, remove redundant class
 2023-08-20 13:28:37 -04:00
jbureau88
77d0d3c07e
Implement [BOT] Optimus Prime; adjust Bolster effect (#10129) 
* Added implementation for Optimus Prime

* Added setCardName text and switch case for activateAlternateOrAdditionalCosts as disturb instead of default

* Fixed doubling effect bug

* Add only regular card number

* Added back alternate card for Optimus Prime and fixed Autobot Leader colors

* Convert before return from graveyard

* Convert before return from graveyard

* Fix images

* Resolve conflict with master

* don't manually set trigger phrase

* add additional effect capability to BolsterEffect, adjust text, flatten logic

* adjust Optimus Prime, Hero

* reimplement Optimus Prime, Autobot Leader

* add test

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
 2023-08-20 13:28:17 -04:00
Susucre
43de68afe3
[WOE] Implement Stroke of midnight (refactor together similar effects) (#10834) 
* [WOE] Implement Stroke of Midnight

* refactor similar effects together.

* add tests (and fix a bug)

---------

Co-authored-by: Evan Kranzler <theelk801@gmail.com>
 2023-08-18 18:27:36 -04:00
theelk801
8753c94488 [WOC] Implement Gylwain, Casting Director 2023-08-18 15:26:38 -04:00
Susucre
8ad37e19b8
[WOE] Implement Decadent Dragon (#10852) 
Grouped together a few Gonti-like look effect.

Co-authored-by: Evan Kranzler <theelk801@gmail.com>
 2023-08-18 15:13:13 -04:00
Evan Kranzler
b892562b95
Fixing aura token creation (#10858) 
* rework aura token creation

* add missing copy constructor

* add message for token if unable to be created

* add a few extra role tests
 2023-08-18 13:25:48 -04:00
Susucre
6a66b0d709
[WOE] Implement Virtue of Knowledge (#10855) 2023-08-18 09:24:51 -04:00
Susucre
7d82b6b1be
[WOE] Implement Restless Spire (#10846) 2023-08-18 09:15:59 -04:00
Evan Kranzler
b20bdcede7
WIP: Implement Role mechanic (#10816) 
* [WOE] Implement Embereth Veteran

* add SBA for role tokens

* [WOE] Implement Cursed Courtier

* [WOE] Implement Conceited Witch

* [WOE] Implement Besotted Knight

* [WOE] Implement Syr Armont, the Redeemer

* [WOE] Implement Living Lectern

* add role test

* [WOE] Implement Lord Skitter's Blessing

* [WOE] Implement Faunsbane Troll

* [WOE] Implement Twisted Fealty

* [WOC] Implement Ellivere of the Wild Court

* [WOE] Implement Monstrous Rage

* [WOE] Implement Spellbook Vendor

* add verify skips

* extra fix
 2023-08-17 10:18:21 -04:00
xenohedron
6814efd87f fix the ability text in a useful place instead 2023-08-16 23:19:05 -04:00
xenohedron
64db75576e text fixes and ability rule improvements 2023-08-16 22:44:53 -04:00
Susucre
92f0f84b23
[LGN] Rework Whipgrass Entangler (#10802) 
* Rework Whipgrass Entangler

Made a class for "Ability linked with an Effect", that also takes responsability of manually calling its effect's newId method.

* apply review & cleanup
 2023-08-15 22:40:25 -04:00
theelk801
e8e243db8c Revert "[WOE] Implement Embereth Veteran" 
This reverts commit bd1b657e24.
 2023-08-15 21:02:01 -04:00
theelk801
bd1b657e24 [WOE] Implement Embereth Veteran 2023-08-15 21:01:22 -04:00
xenohedron
3386ea117d Implement [40K] Dark Apostle; Sloppity Bilepiper 2023-08-13 01:17:51 -04:00
xenohedron
6fafbf0d93 new NextSpellCastHasAbilityEffect 
cleanup Wand of the Worldsoul, Flockchaser Phantom to use it

text adjustments for gain abilities
 2023-08-13 01:17:51 -04:00
Susucre
07ee4661e7
[CMM] Implement Teyo, Geometric Tactician (#10736) 
* [CMM] Implement Teyo, Geometric Tactician

* rework as a RestrictionEffect (common class with Mystic Barrier; Pramikon, Sky Rampart)

* add checkMayAttackDefender test

* more Pramikon tests
 2023-08-12 19:02:23 -04:00
Susucre
2d53668c96
[LTC] Implement Gilraen, Dunedain Protector (#10728) 
* [LTC] Implement Gilraen, Dunedain Protector

* add tests on Gilraen

* apply review
 2023-08-12 16:16:02 -04:00
Susucre
eef8f508e4
[CMM] Implement Demon of Fate's Design (#10737) 
* refactor SacrificeCostManaValue to be an enum.

* [CMM] Implement Demon of Fates Design

* Add Unit Tests, including one bug on alternative cost.

* fix alternativeCosts made from dynamicCost returning that they were not activated when paid.

* fix small issues, add hint

* cleanup tests and add a couple

* Capitalize enum instances

* Minor fixes

* simplify the ContinuousEffect

* use the ConditionPermanentHint made for the Demon

* fix text
 2023-08-12 15:49:06 -04:00
xenohedron
b0f7f0c78c Implement [J22] Mild-Mannered Librarian 
closes #10031
 2023-08-11 23:21:10 -04:00
xenohedron
a8d86e1587 text adjustment 2023-08-11 23:07:22 -04:00
xenohedron
7839c6cbff
Implement [CMM] Hatchery Sliver; fix Replicate ability (#10694) 
* Implement [CMM] Hatchery Sliver

* limit ReplicateAbility to only its linked instance

* Add test for multiple instances of replicate

* add another test
 2023-08-11 20:41:45 -04:00
xenohedron
127b7be9b0
more unrelated text fixes (#10761) 
* some text fixes [LTR] [LTC] [CMM]

* another batch of text fixes

* followup fixes

* unrelated cleanup

* fix corresponding ability text in test
 2023-08-05 20:53:43 -04:00
Susucre
fa77261e3a
Add more missing copy constructors. (#10758) 2023-08-05 20:53:32 -04:00
Susucre
9979208f05
[LTC] Implement Champions of Minas Tirith (#10726) 
repurposed (and renamed) CantAttackYouEffect.java, that was actually not used.
 2023-08-04 21:20:55 -04:00
Susucre
894d557952
Add additional copy test to check copy of effects/abilities (#10754) 
* add further copy test

* add more missing copy constructors/methods
 2023-08-04 20:10:23 -04:00
Susucre
f75b1c9f0a
Code cleanup: protect all copy constructors (#10750) 
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
 2023-08-04 19:34:58 -04:00
xenohedron
63706942db simplify DoIfClashWonEffect 2023-08-03 22:12:46 -04:00
Susucre
4d3b944b65
Fix Clash effect causing NullPointerExceptions (#10742) 2023-08-03 22:11:59 -04:00
Susucre
04845072ea
[LTC] Implement Field-Tested Frying Pan (#10721) 2023-08-01 09:51:19 -04:00
Susucre
241226cd83
[LTC] Implement Summons of Saruman (#10720) 
* [LTC] Implement Summons of Saruman

* fix constructor for Assault on Osgiliath

* fix verify failure

* refactoring a couple more Amass X
 2023-08-01 09:51:06 -04:00
Susucre
40e508ac19
Refactor Devour ability; [LTC] Implement Feasting Hobbit (#10708) 
* [LTC] Implement Feasting Hobbit

Refactor DevourEffect and its text generation, to be more permissive in the future.

* change DevourAbility to have the constructor parameters of DevourEffect

* only pluralize when there is more than 1 devoured permanent.

* added more unit tests than there are cards with devour

* public -> private filter of Caprichrome.
 2023-08-01 09:49:32 -04:00
Susucre
e724166569
[LTC] Implement Cavern-Hoard Dragon (#10724) 2023-07-31 23:53:06 -04:00
Susucre
d61e454e77
[LTC] Implement Of Herbs and Stewed Rabbit (#10718) 2023-07-31 23:52:28 -04:00