Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions
41213 commits 5 branches 220 tags 1.1 GiB
Commit graph

3688 commits

Author SHA1 Message Date
Susucre
9979208f05
[LTC] Implement Champions of Minas Tirith (#10726) 
repurposed (and renamed) CantAttackYouEffect.java, that was actually not used.
 2023-08-04 21:20:55 -04:00
Susucre
894d557952
Add additional copy test to check copy of effects/abilities (#10754) 
* add further copy test

* add more missing copy constructors/methods
 2023-08-04 20:10:23 -04:00
Susucre
4ebfd79005
refactor DefendingPlayerControlsCondition (#10749) 2023-08-04 20:10:08 -04:00
Susucre
f75b1c9f0a
Code cleanup: protect all copy constructors (#10750) 
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
 2023-08-04 19:34:58 -04:00
Susucre
5c58e28f9b
Fix King of the Oathbreaker (#10747) 2023-08-04 18:37:11 -04:00
Susucre
9889baa0bc
Fix game freeze caused by TotalPermanentsManaValue hint copy (#10751) 2023-08-04 18:09:43 -04:00
Susucre
b9a2278d4f
fix VanishingUpkeepAbility missing a copy for a field (#10755) 2023-08-04 18:09:05 -04:00
xenohedron
63706942db simplify DoIfClashWonEffect 2023-08-03 22:12:46 -04:00
Susucre
4d3b944b65
Fix Clash effect causing NullPointerExceptions (#10742) 2023-08-03 22:11:59 -04:00
ssk97
b144cb6f03
Minor Backup fixes, add tests (#10732) 
* Backup is not optional and its effect should be BoostCreature, not Detriment

* Add tests for Backup ability

* Add Mirror-Shield Hoplite source test

* Use Strict mode for the hoplite source test
 2023-08-03 00:26:33 -04:00
xenohedron
ec3bb197fb various text fixes 2023-08-02 22:54:35 -04:00
Susucre
04845072ea
[LTC] Implement Field-Tested Frying Pan (#10721) 2023-08-01 09:51:19 -04:00
Susucre
241226cd83
[LTC] Implement Summons of Saruman (#10720) 
* [LTC] Implement Summons of Saruman

* fix constructor for Assault on Osgiliath

* fix verify failure

* refactoring a couple more Amass X
 2023-08-01 09:51:06 -04:00
Susucre
1c5829f16b
[LTC] Implement Rapacious Guest (#10719) 2023-08-01 09:50:45 -04:00
Susucre
0938a5cd72
[LTC] Implement Eomer, King of Rohan (#10713) 2023-08-01 09:50:16 -04:00
Susucre
40e508ac19
Refactor Devour ability; [LTC] Implement Feasting Hobbit (#10708) 
* [LTC] Implement Feasting Hobbit

Refactor DevourEffect and its text generation, to be more permissive in the future.

* change DevourAbility to have the constructor parameters of DevourEffect

* only pluralize when there is more than 1 devoured permanent.

* added more unit tests than there are cards with devour

* public -> private filter of Caprichrome.
 2023-08-01 09:49:32 -04:00
Susucre
e724166569
[LTC] Implement Cavern-Hoard Dragon (#10724) 2023-07-31 23:53:06 -04:00
Susucre
61a6657127
[LTC] Implement Crown of Gondor (#10722) 2023-07-31 23:52:43 -04:00
Susucre
d61e454e77
[LTC] Implement Of Herbs and Stewed Rabbit (#10718) 2023-07-31 23:52:28 -04:00
Susucre
378fd2743e
[LTC] Implement Taunt from the Rampart (#10717) 2023-07-31 23:52:15 -04:00
Susucre
67407a8780
[LTC] Implement Motivated Pony (#10716) 2023-07-31 23:51:59 -04:00
Susucre
63d9061f6a
[LTC] Implement Assemble the Entmoot (#10711) 
* [LTC] Implement Assemble the Entmoot

* rename ControllerGotLifeCount -> ControllerGainedLifeCount
 2023-07-31 23:50:29 -04:00
Oleg Agafonov
8d938926b6 refactor: improved usage of one time turn modifications (skip step, extra turn, etc) 2023-07-31 20:16:28 +04:00
Susucre
fbc0cd61dd
[LTC] Implement Banquet Guests (#10706) 
* make a StaticFilter for "a food"

* [LTC] Implement Banquet Guests

Made a Static Filters for controlled food, with the next eldraine set we'll certaintly see more of that.

* future proof static text for mulitplier > 2
 2023-07-30 19:26:26 -04:00
Susucre
53b270fc36
[CMM] Implement Rukarumel, Biologist (#10703) 2023-07-30 19:26:11 -04:00
Susucre
263b01e702
[CMM] rework Narci, Fable Singer (#10699) 
* easy fix first

* use targetPointer in Narci effect.
 2023-07-29 13:46:40 -04:00
Susucre
f476c6864b
[CMM] Implement Onakke Oathkeeper (#10693) 
* [CMM] Implement Onakke Oathkeeper

* take authorship of new file

* cleanup and extend CantAttackYouUnlessPayAllEffect.

* further cleanup

* cleanup

* add Duration to CantAttackYouUnlessPayAllEffect constructors, cleanup two more text generation.

* fix duration text
 2023-07-29 13:46:00 -04:00
Susucre
792be8a859
[BOT] Implement Starscream, Power Hungry // Starscream, Seeker Leader (#10674) 2023-07-29 13:45:39 -04:00
Susucre
4856c65443
[BOT] Implement Megatron, Tyrant // Megatron, Destructive Force (#10666) 
* [BOT] Implement Megatron, Tyrant // Megatron, Destructive Force

* fix verify test.

* cleanup AbilityCastMode for Disturb & MoreThanMeetsTheEye

* cleanup unecessary checks.

* fix duration of silence static effect

* fix Disturb tests
 2023-07-29 13:45:09 -04:00
Susucre
16094a9311
[CMM] Implement Ghoulish Impetus (#10687) 2023-07-28 21:27:55 -04:00
Susucre
b79964530e
[CMM] Implement Narci, Fable Singer (#10685) 2023-07-28 21:27:40 -04:00
Susucre
286696800e
[CMM] Implement Omarthis, Ghostfire Initiate (#10681) 
ManifestEffect now takes a DynamicValue
 2023-07-28 21:27:29 -04:00
Susucre
50989970cb
[CMM] Implement Cacophony Unleashed (#10689) 2023-07-28 19:33:35 -04:00
Susucre
a8bba53adf
[CMM] Implement Desecrate Reality (#10684) 2023-07-28 19:33:08 -04:00
xenohedron
ba8ed9fcac Fix LKI handling in AttachedPermanentPowerCount 2023-07-28 00:55:42 -04:00
xenohedron
367cf9169c Implement [LTC] Lothlorien Blade 2023-07-27 23:42:45 -04:00
Susucre
c4f13be87f
[CMM] Implement Nyxborn Behemoth (#10670) 
* [CMM] Implement Nyxborn Behemoth

Regroup the different dynamic values for "total mana value of [FILTER]" under a shared class.

* refactor hints inside TotalPermanentsManaValue

* apply review on TotalPermanentsManaValue->copy
 2023-07-27 12:50:47 -04:00
Susucre
bc403fd6fe
[LTC] Implement Mirkwood Trapper (#10665) 2023-07-27 00:23:58 -04:00
xenohedron
a096c0a7c3 adjust game log messages for damage can't be prevented 2023-07-26 09:53:54 -04:00
xenohedron
6b23cd25f9 text adjustments and typo fixes 2023-07-25 00:57:41 -04:00
xenohedron
ff27fc1ce1 improve Suspend reminder text 2023-07-22 21:28:34 -04:00
xenohedron
3886075dac
Update common effect class text generation (A-C) (#10651) 2023-07-21 22:55:47 -04:00
theelk801
5f01f973cb [CMM] Implement Ugin's Mastery 2023-07-21 20:19:47 -04:00
theelk801
564a24f7a3 [CMM] Implement Lazotep Sliver 2023-07-21 20:08:15 -04:00
xenohedron
ad86a52ba4 update some text generation logic 2023-07-19 20:38:48 -04:00
xenohedron
f944408252 fix text: BecomesColorTargetEffect 2023-07-19 20:26:20 -04:00
PurpleCrowbar
6a244c09a7
[LTC] Implement Shelob, Dread Weaver (#10645) 2023-07-18 05:46:54 +01:00
Susucre
8128e9935d
add Renown hint (similar to Monstrous one) (#10644) 2023-07-17 20:03:19 -04:00
xenohedron
fa72e243e9
Text generation improvements for triggered abilities (#10638) 2023-07-17 20:03:01 -04:00
Susucre
0c7965a725
Fix Pyrrhic Revival not adding -1/-1 counters on returned creatures. (#10626) 
* Add (failing) unit test on Pyrrhic Revival

* fix PyrrhicRevival

reworked ReturnFromGraveyardToBattlefieldWithCounterTargetEffect to support having multiple cards in its targetPointer.

added test for Persist (the card from mh2).

* refactor & cleanup

* add myself as author, the effect was remade.
 2023-07-17 20:02:49 -04:00