Oleg Agafonov
88eb35ebc7
code clean
2024-04-16 23:37:22 +04:00
Oleg Agafonov
e8e2f23284
server: improved server stability ( #11285 ) and reworked triggers/playable logic ( #8426 ):
...
* game: now all playable calculations done in game simulation, outside real game (no more freeze and ruined games by wrong Nyxbloom Ancient and other cards with wrong replacement dialog);
* game: fixed multiple problems with triggers (wrong order, duplicated calls or "too many mana" bugs, see #8426 , #12087 );
* tests: added data integrity checks for game's triggers (3 enabled and 3 disabled due current game engine logic);
2024-04-16 23:10:18 +04:00
Susucre
f68e435fc4
rework and test Phyrexian Ingester
2024-04-14 12:33:26 +02:00
Susucre
017286ed94
fix ContinuousEffect that access affectedObjectsSet before it is initialized ( #12080 )
2024-04-13 16:50:06 +02:00
Susucre
cce7f79d89
fix and test Lara Croft, Tomb Raider ( #11945 )
...
Fix #11945
2024-04-13 13:21:29 +02:00
Susucre
fc011ac7e0
fix Opposition Agent ( #10576 )
...
Fix #10576
2024-04-13 12:59:52 +02:00
jimga150
db9e849ac8
[REX] Implement Henry Wu, InGen Geneticist ( #12106 )
2024-04-13 12:22:58 +02:00
Susucre
607d55f16b
[OTC] Implement 2 cards, refactor some exile effects ("Gonti-like") ( #12118 )
...
[OTC] Implement Gonti, Canny Acquisitor
[OTC] Implement Dream Thief's Bandana
2024-04-13 12:21:05 +02:00
Susucre
c77634c843
separate 'you may play'|'you may cast' AsThoughtEffect approuvers
...
Also, reworked Gonti, Lord of Luxury and checks it now works properly with Zoetic Cavern.
2024-04-13 12:10:53 +02:00
xenohedron
31295eb645
followup fix to #12058
2024-04-12 23:24:56 -04:00
xenohedron
8394429a47
reminder text fixes
2024-04-12 22:43:35 -04:00
xenohedron
8853e7d875
refactor: clean up static filters for sacrifice targets ( #12120 )
...
* simplify sacrifice target filters, part 1
* minor cleanup
* adjust SacrificeXTargetCost
* adjust Arctic Merfolk
* more cleanup
* remove unused
* adjust filters not used for sacrifice
* fix Hew the Entwood
* fix Nahiri's Lithoforming
* remove unused
* remove another
* cleanup more
* fix MegatronDestructiveForce
* remove next
* next batch of replacements
* remove next
* rename filter to match text
* finish removing
* use existing static filter
2024-04-12 22:24:10 -04:00
xenohedron
5c9d1cd205
fix #12058 (check phased in for "control a commander")
2024-04-12 20:59:36 -04:00
xenohedron
1198192a13
more text adjustments
2024-04-12 20:45:53 -04:00
sandbo00
d011e70baf
[PIP] Implement Marcus, Mutant Mayor ( #11999 )
...
---------
Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
2024-04-12 20:16:15 -04:00
xenohedron
f3fccfbd8a
refactor: use setter method and private field
2024-04-12 20:11:04 -04:00
xenohedron
577a3708fc
adjust some text, cleanup some variable access
2024-04-12 20:08:26 -04:00
Alexander Novotny
8271686cb4
[PIP] Implement Shaun, Father of Synths ( #12109 )
...
* Added method to set triggered abilities to optional
* TokenCopy effect now copies permanentModifier
* Implemented Shaun, Father of Synths
* remove TODO
* Made `setOptional` chainable
2024-04-12 19:41:58 -04:00
jimga150
96939b31eb
Implement [REX] Owen Grady, Raptor Trainer ( #12094 )
2024-04-12 19:41:27 -04:00
Cameron Merkel
b141fdea2c
[PIP] Implement The Motherlode, Excavator ( #12076 )
2024-04-12 19:41:11 -04:00
Cameron Merkel
3aa3e0671f
[PIP] Implement Veronica, Dissident Scribe ( #12113 )
2024-04-12 23:47:43 +02:00
Susucre
6b3db829fa
[OTC] Implement Discreet Retreat
2024-04-12 19:28:32 +02:00
Susucre
bf131fff79
[OTC] Implement Orochi Soul-Reaver
2024-04-12 19:28:32 +02:00
theelk801
a248c23458
[OTC] fix Greywater's Fixer giving unearth rather than encore
2024-04-12 11:40:28 -04:00
Susucre
5fb1651403
fix small bugs in two cards
...
Fix #12112
2024-04-12 15:44:17 +02:00
Susucre
72a2e32d1c
fix 514.3a, give player priority on cleanup when something happened ( #12115 )
2024-04-12 15:31:53 +02:00
Oleg Agafonov
f1791a3c70
Merge fix
2024-04-11 23:02:25 +04:00
Oleg Agafonov
34dac7877d
fixed empty targets in EachOpponentPermanentTargetsAdjuster (related to #11886 )
2024-04-11 22:46:26 +04:00
Oleg Agafonov
367defd995
tests: added tests for non-stack delayed trigger and details docs about problem
2024-04-11 22:46:25 +04:00
Oleg Agafonov
7fa4648316
refactor: code clean
2024-04-11 22:46:25 +04:00
Susucre
0d1df0ec47
[PIP] Implement James, Wandering Dad
2024-04-11 19:55:05 +02:00
Susucre
94c33eeb5d
[PIP] Implement Junk Jet
2024-04-11 19:55:00 +02:00
Susucre
49b00d13d8
[PIP] Implement Elder Arthur Maxson
2024-04-11 19:30:12 +02:00
Susucre
e741a453bf
[PIP] Implement Nuclear Fallout
2024-04-11 19:16:36 +02:00
Susucre
68cacc78fc
[PIP] Implement Contaminated Drink
2024-04-11 19:07:36 +02:00
Susucre
1e08c42c24
[PIP] Implements Nightkin Ambusher
2024-04-11 19:07:25 +02:00
PurpleCrowbar
5d73901ad3
Simplify Power Fist and Westgate Regent
2024-04-11 13:44:09 +01:00
Susucre
8a29dcc735
fix Obeka, Splitter of Seconds ( #12085 )
...
Now adding BeginningPhases with all but Upkeep skipped.
Previously upkeep steps were added during combat phase, which was incorrect.
fix #12085
2024-04-11 13:24:56 +02:00
Susucre
add0fa4f58
cleanup some new cards
2024-04-11 11:24:46 +02:00
jimga150
50e8a3b530
[REX] Implement Blue, Loyal Raptor ( #12099 )
2024-04-11 00:37:18 -04:00
xenohedron
8bf75ed000
text fixes
2024-04-11 00:34:19 -04:00
jimga150
51b1ab4cb6
Implement [REX] Compy Swarm ( #12101 )
2024-04-10 23:43:37 -04:00
jimga150
444a15df5d
Implement [REX] Cresting Mosasaurus ( #12100 )
2024-04-10 23:43:06 -04:00
jimga150
40b1dcc526
Fix DestroyPlaneswalkerWhenDamagedTriggeredAbility ( #12093 )
2024-04-10 23:42:44 -04:00
jimga150
1eda4aaad4
Fix AAT-1's ability trigger check ( #12068 )
2024-04-10 23:42:37 -04:00
Susucre
113630c1ab
fix Deep Gnome Terramancer triggering out of extra lands played
2024-04-10 20:52:18 +02:00
Oleg Agafonov
c3862e7196
server: improved server stability after some memory overflow errors (card not found errors, related to #11285 );
2024-04-10 22:35:48 +04:00
Oleg Agafonov
6e0ef77f96
server: removed useless info message about disconnect stats, improved games/tourney stats;
2024-04-10 22:20:21 +04:00
Oleg Agafonov
7817a5cac6
deck improves:
...
* gui: removed public deck hash info;
* gui: improved xmage dck-file - now it correctly load a card's amount (related to files from third party services);
* server: fixed wrong cheating warning on deck construction (closes #11877 );
* refactor: removed outdated hash code and calculations;
* other: added docs, added multiple deck hash tests;
2024-04-10 22:18:07 +04:00
Oleg Agafonov
889c1125e8
refactor: improved deck import, added docs and miss tests for dek-files;
2024-04-10 21:55:43 +04:00
