xenohedron
35f4a898f9
Small rework for autochoosing color of mana to add ( #11495 )
...
fix #11494
2023-12-01 00:49:42 -05:00
ssk97
e43e918c67
Conditional mana - fixed that some mana cant be used for paying “counter unless” cost and other things ( #11447 )
...
* Add tests for conditional mana usage with soft counterspells
* Fix "to cast" conditions on common ManaCondition classes
* Add fix to all remaining ManaCondition classes
* SimpleActivatedAbilityConditionalMana is tested to pay for a soft counterspell activated ability
* Remove now-unused imports
2023-11-23 01:37:45 +04:00
Oleg Agafonov
0bf4b63bcf
refactor: additional improves for mana choice in some cards, related to Naked Singularity from 81039d6e72
2023-09-23 06:39:01 +04:00
Susucre
96a2c277b2
clean some of the most frequent copy constructor / copy method ( #11053 )
2023-08-30 19:48:03 -04:00
Susucre
44fcf3553d
Rework Manaforge Cinder to have a Mana Ability ( #10929 )
2023-08-21 22:40:58 -04:00
Susucre
f75b1c9f0a
Code cleanup: protect all copy constructors ( #10750 )
...
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
2023-08-04 19:34:58 -04:00
Susucre
0255761d67
[LTR] Implement The Grey Havens ( #10493 )
2023-06-22 20:06:10 -04:00
Evan Kranzler
10076c6d8d
[40K] Implemented Nexos
2022-10-22 17:35:42 -04:00
Oleg Agafonov
5fb6670b81
dev: removed outdated dependency (fixed build warning);
2022-10-10 15:50:49 +04:00
Alex W. Jackson
0bf03d1f92
Fix #9636
2022-10-09 11:40:39 -04:00
Alex Vasile
55a6acba22
Refactor: Significant speed-up for ManaOptions ( #9233 )
2022-10-04 00:08:20 -04:00
Alex Vasile
19a896df57
Refactoring and cleaning up based on previous commit
2022-08-12 21:33:20 -04:00
Alex Vasile
c0c5c63284
Fixed "One mana of any color" abilities from allowing you to make {C}. Closes #9351 .
2022-08-12 21:33:02 -04:00
Alex Vasile
ebdb6b53a4
Replace Overriden getTriggerPhrase() with setTriggerPhrase() usage ( #9343 )
2022-08-08 23:28:46 -04:00
Alex Vasile
015cdf3136
Revert "Added missing fields to many copy constructors. ( #8957 )" ( #8999 )
...
This reverts commit 82708e4273
2022-05-25 12:57:24 -06:00
Alex Vasile
82708e4273
Added missing fields to many copy constructors. ( #8957 )
2022-05-25 09:51:18 -06:00
Alex Vasile
5e26066b24
- Improving performance Mana.toString().
...
- Slightly improved performance of getPossiblePayCombinations().
- Flattened getNetMana slightly.
For #7710 .
2022-05-16 21:03:39 -06:00
Evan Kranzler
80e11b2052
(WIP) Replacing blocking/blocked by predicates ( #8729 )
...
* replaced blocking/blocked by predicates
* added test for knight of dusk (currently fails)
* added source parameter to filters and everything else that needs it
* some changes to various predicates
* test fix
* small changes to filter code
* merge fix
* fixed a test failure
* small change to Karn, Scion of Urza
* removed sourceId from filter methods and other similar places
* added new getobject method to fix some test failures
* a few more fixes
* fixed merge conflicts
* merge fix
2022-03-23 18:45:02 -04:00
Evan Kranzler
a87b28f348
[MID] various text fixes
2021-09-26 14:34:32 -04:00
Oleg Agafonov
33380f09c2
Improved canActivate support:
...
* added support of non controller activates in ActivatedManaAbility (mayActivate);
* removed custom code from ActivatedManaAbility;
* removed custom code from Mana Cache;
* added additional comments;
2021-08-21 10:52:00 +04:00
Oleg Agafonov
b073ff8617
Pay {0} - fixed that it doesn't work for alternative cost (related to b6a3f7edc1);
2021-08-06 18:17:13 +04:00
Evan Kranzler
214b688fdb
Update effects and abilities which involve tapping permanents for mana ( #7679 )
...
Abilities which use trigger from or replace tapping for mana now save the permanent in case it leaves the battlefield.
fixes #7671 , fixes #7770
* Merge fix and additional comments, Winter's Night fixed
Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2021-07-22 05:09:07 +04:00
Evan Kranzler
ca80806400
Reworking triggered ability text generation to allow for ability words and flavor words to be added more easily ( #8010 )
...
* refactor all instances of getRule in triggered abilities using new getTriggerPrefix method
* updated triggered ability rules generation
* renamed method
* fixed a test failure
* some more refactoring
* simplified some instances of ability word usage
2021-07-15 07:46:38 -04:00
Evan Kranzler
572104b8fc
Reworking card types in preparation for implementing Grist, the Hunger Tide ( #7899 )
...
Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2021-07-09 07:28:43 +04:00
Ingmar Goudt
96d026e4af
remove explicit null checks, match(..) checks on null itself by instanceof calls
2021-04-28 20:53:50 +02:00
Evan Kranzler
05a7c83a77
if you're having text problems I feel bad for you son, I've got 99 problems and they're all text-related and I've only dealt with a small amount of them
2021-04-18 18:17:38 -04:00
Evan Kranzler
326c17fe4d
[STX] various text fixes
2021-04-17 18:22:43 -04:00
Oleg Agafonov
fbb08ab1a8
Devs: added todo with mana calculation freezes (Cascading Cataracts)
2021-04-02 11:32:35 +04:00
Evan Kranzler
2a42bec1f2
simplified various cards to use isInstantOrSorcery method
2021-03-22 20:01:20 -04:00
Oleg Agafonov
b6cb5cef9c
Refactor: removed default comment headers
2021-02-21 08:15:16 +04:00
Oleg Agafonov
dc0a29007c
Commanders improves:
...
* [KHM] fixed that some effects can't find mdf commanders on battlefield (example: Fierce Guardianship, #7504 );
* Oathbreaker: fixed that some cards that refer to commander can affects signature spells too;
2021-02-05 17:19:30 +04:00
Evan Kranzler
e18e3c79d4
[KHM] Implemented Glittering Frost
2021-01-13 18:02:25 -05:00
Oleg Agafonov
347a3b1e1a
* Jeweled Lotus - fixed that mana can't be used to cast commanders without normal mana ( #7272 );
2020-12-22 23:22:41 +04:00
Oleg Agafonov
4d362d7edc
* Copy spells - improved combo support with other abilities like Kicker or Entwine ( #7192 ):
...
* Now ZCC of copied spells syncs with source card or coping spell (allows to keep ability settings that depends on ZCC);
* Fixed bug that allows to lost kicked status in copied spells after counter the original spell or moves the original card (see #7192 );
* Test framework: improved support of targeting copy or non copy spells on stack;
2020-12-15 20:06:53 +04:00
Oleg Agafonov
35f5a8257b
Refactor: replaced sourceId by source and introduced source param in some methods (part 2);
2020-12-13 02:01:49 +04:00
Oleg Agafonov
db239a1055
Refactor: replaced sourceId by source and introduced source param in some methods;
2020-12-12 20:23:19 +04:00
LevelX2
d51acbf090
* Removed unused imports.
2020-08-22 11:51:34 +02:00
LevelX2
c48331f216
* Doubling Cube - Added support for possible mana calculation (related to #6698 ).
2020-08-18 00:22:53 +02:00
LevelX2
768f1bec4f
* Fixed available mana calculation for Cryptic Trilobite and Titans' Nest. Added some improvements for available mana calculation of conditional mana.
2020-08-16 01:16:52 +02:00
LevelX2
27b5c920f7
* Offering - Fixed handling of hybrid mana in casting costs of offered creatures ( fixes #6961 ).
2020-08-14 10:25:47 +02:00
LevelX2
457557852e
* Benthic Explorer - Fixed mana type calculation.
...
* DynamicManaEffect - Fixed mana type calculation.
Some code clean up.
2020-08-07 17:15:06 +02:00
Oleg Agafonov
83f7ae377a
Refactored restore state code, added additional error check for mana undo param;
2020-08-06 22:17:37 +04:00
Oleg Agafonov
3430013f8d
* Server: fixed that too much permanents or mana sources on battlefield can crush or slow down the server ( #6938 );
2020-08-04 05:36:43 +04:00
LevelX2
cbc1c02cde
* Fixed bug that caused some tests to fail introduced with 67dd45c1c7.
2020-08-03 08:32:26 +02:00
LevelX2
67dd45c1c7
* Added getProducableManaTypes method for mana effects to handle Squandered Resources or Reflecting Pool like abilities.
...
* Fixes to Soldevi Adnate, Skirge Familiar, Mana Web.
2020-08-02 10:51:22 +02:00
LevelX2
06968ad921
* Fixed a problem of available mana generation caused by order of usage of mana sourced with costs (example Coal Golem and then Dromar's Attendant - related to #6698 ).
2020-07-30 23:37:04 +02:00
LevelX2
b5c93cf2da
* Fixed available mana generation of Druids Repository, Workhouse, Iceberg, Krak Clan Ironworks, Rasputin Dreamweaver and Sirk Prospector ( #6698 ).
2020-07-28 01:03:33 +02:00
LevelX2
82a9726a35
* Fixed available mana generation of Virdian Joiner ( #6698 ).
2020-07-27 23:50:07 +02:00
LevelX2
4d43914673
* Morselhoarder - Fixed calculation of available mana and some cleanup to other mana abilities ( #6698 ).
2020-07-24 16:41:36 +02:00
LevelX2
653a2dd7b2
* Available mana calculation - Fixed a problem with repeatable mana converting abilities (e.g. Farrelite Priest) that were only considered once ( #6698 ).
2020-07-24 12:06:14 +02:00
