Susucre
16094a9311
[CMM] Implement Ghoulish Impetus ( #10687 )
2023-07-28 21:27:55 -04:00
Susucre
b79964530e
[CMM] Implement Narci, Fable Singer ( #10685 )
2023-07-28 21:27:40 -04:00
Susucre
286696800e
[CMM] Implement Omarthis, Ghostfire Initiate ( #10681 )
...
ManifestEffect now takes a DynamicValue
2023-07-28 21:27:29 -04:00
Susucre
50989970cb
[CMM] Implement Cacophony Unleashed ( #10689 )
2023-07-28 19:33:35 -04:00
Susucre
a8bba53adf
[CMM] Implement Desecrate Reality ( #10684 )
2023-07-28 19:33:08 -04:00
xenohedron
ba8ed9fcac
Fix LKI handling in AttachedPermanentPowerCount
2023-07-28 00:55:42 -04:00
xenohedron
367cf9169c
Implement [LTC] Lothlorien Blade
2023-07-27 23:42:45 -04:00
Susucre
c4f13be87f
[CMM] Implement Nyxborn Behemoth ( #10670 )
...
* [CMM] Implement Nyxborn Behemoth
Regroup the different dynamic values for "total mana value of [FILTER]" under a shared class.
* refactor hints inside TotalPermanentsManaValue
* apply review on TotalPermanentsManaValue->copy
2023-07-27 12:50:47 -04:00
Susucre
bc403fd6fe
[LTC] Implement Mirkwood Trapper ( #10665 )
2023-07-27 00:23:58 -04:00
xenohedron
a096c0a7c3
adjust game log messages for damage can't be prevented
2023-07-26 09:53:54 -04:00
xenohedron
6b23cd25f9
text adjustments and typo fixes
2023-07-25 00:57:41 -04:00
xenohedron
ff27fc1ce1
improve Suspend reminder text
2023-07-22 21:28:34 -04:00
xenohedron
3886075dac
Update common effect class text generation (A-C) ( #10651 )
2023-07-21 22:55:47 -04:00
theelk801
5f01f973cb
[CMM] Implement Ugin's Mastery
2023-07-21 20:19:47 -04:00
theelk801
564a24f7a3
[CMM] Implement Lazotep Sliver
2023-07-21 20:08:15 -04:00
xenohedron
ad86a52ba4
update some text generation logic
2023-07-19 20:38:48 -04:00
xenohedron
f944408252
fix text: BecomesColorTargetEffect
2023-07-19 20:26:20 -04:00
PurpleCrowbar
6a244c09a7
[LTC] Implement Shelob, Dread Weaver ( #10645 )
2023-07-18 05:46:54 +01:00
Susucre
8128e9935d
add Renown hint (similar to Monstrous one) ( #10644 )
2023-07-17 20:03:19 -04:00
xenohedron
fa72e243e9
Text generation improvements for triggered abilities ( #10638 )
2023-07-17 20:03:01 -04:00
Susucre
0c7965a725
Fix Pyrrhic Revival not adding -1/-1 counters on returned creatures. ( #10626 )
...
* Add (failing) unit test on Pyrrhic Revival
* fix PyrrhicRevival
reworked ReturnFromGraveyardToBattlefieldWithCounterTargetEffect to support having multiple cards in its targetPointer.
added test for Persist (the card from mh2).
* refactor & cleanup
* add myself as author, the effect was remade.
2023-07-17 20:02:49 -04:00
xenohedron
a5dbf30605
Fix #10631 (Forge, Neverwinter Charlatan)
2023-07-16 16:19:31 -04:00
xenohedron
1f9de03bf3
Lots of text fixes ( #10636 )
2023-07-16 14:55:59 -04:00
xenohedron
906e30a81b
GainAbilityAttachedEffect no longer includes reminder text on the attachment
2023-07-16 00:46:23 -04:00
xenohedron
481384a3c8
Text fixes [M10] [M11] [M12] [M13] [M14] [M15] [ORI] ( #10630 )
...
* Text fixes M10-ORI core sets, part 1
* Text fixes M10-ORI core sets, part 2
* Text fixes M10-ORI core sets, part 3
* another text fix
2023-07-16 00:35:18 -04:00
Susucre
b960b77774
Refactor name of minimum deck size (was startingHandSize) ( #10628 )
...
* Refactor: rename starting hand size, it was actually minimum deck size (40, 60 or 100 most of the time)
2023-07-16 01:45:19 +04:00
xenohedron
a7f78e8190
Clean up triggered ability text generation ( #10627 )
...
* move "or battle" to its own class
* move "or planeswalker" to its own class
* remove strange way of setting custom text
* finally remove getTriggerPhrase
* copy constructor visibility
* fix Vraska
2023-07-15 16:49:40 -04:00
xenohedron
ee29c38413
Clash adjustments ( #10616 )
...
* adjust clash effect
* Make clash not a singleton
* Add unit test for Clash effect
* fix test (skip init shuffling)
* Fix CLASHED event flag logic and add to unit test
* Additional test and comments
* comments in GameEvent
* param name typo
2023-07-14 23:15:01 -04:00
xenohedron
0d4c73b385
[LRW] [MOR] [SHM] [EVE] text fixes
2023-07-14 22:40:56 -04:00
xenohedron
aaf99a4c1a
followup fixes
2023-07-14 22:12:08 -04:00
xenohedron
ae9f920d87
more [LTR] text fixes / corrections
2023-07-14 21:58:33 -04:00
Susucre
2c505bbcac
[LTR] Implement King of the Oathbreakers ( #10619 )
...
* make a new BecomesTargetTriggeredAbility to filter on target permanents.
2023-07-14 21:32:23 -04:00
Susucre
2188c690c6
[LTR] Implement Eomer, Marshal of Rohan ( #10617 )
...
Also, small refactor adding EachTurn to the name of both `setTriggersOnce` and `setDoOnlyOnce`.
2023-07-14 21:32:00 -04:00
xenohedron
72ebe2b1f1
minor code cleanup triggered abilities
2023-07-14 20:30:09 -04:00
xenohedron
ef739688fb
remove unused duplicated effect class
2023-07-14 20:28:33 -04:00
xenohedron
792224d6dc
more followup text fixes
2023-07-14 02:12:57 -04:00
xenohedron
176a61190b
Followup text fixes
2023-07-14 01:59:27 -04:00
xenohedron
185fae28a4
Text fixes [10E]
2023-07-14 01:40:12 -04:00
xenohedron
eeffafcc62
Generalize UntapEnchantedEffect to UntapAttachedEffect
2023-07-13 00:28:03 -04:00
Susucre
6a9340f1aa
Introduce Duration.UntilYourNextUpkeepStep ( #10600 )
...
* add new Duration
* refactor cards with new Duration.
* fix both Durations and add unit tests.
* fix text
2023-07-12 19:40:27 -04:00
Susucre
14235b6320
Rework Ring-bearer implementation. Add GUI + gamelogs. ( #10596 )
...
* Fix Ring-bearer choosing & add some GUI + logs
* use a ring svg in a separate gold panel
* use a fontawesome svg
* add a couple null checks, group icon with commander
* rework rinbearer logic according to review
* fix typo in game log
* small fixes
2023-07-12 19:40:09 -04:00
Bobby McCann
09530f1cdb
[LTR] Implement Glamdring ( #10574 )
2023-07-12 19:39:31 -04:00
xenohedron
3f346d791c
fix file location in source tree
2023-07-10 06:32:04 -04:00
xenohedron
6c9079012c
Cleanup: source deals damage to {this}; mill cards ( #10603 )
...
* New common class for "Whenever a source deals damage to {this}, " which resolves #9340
* Merge `PutLibraryIntoGraveTargetEffect` with functionally identical `MillCardsTargetEffect`
* Text fix on `RevealDragonFromHandCost` noticed in #10593
* Text fix following up on #10594
2023-07-09 22:05:28 -04:00
Bobby McCann
73104f6705
[LTR] Implement Radagast the Brown; also resolves #9419 ( #10568 )
...
* Fix #9419 bug with EntersBattlefieldThisOrAnotherTriggeredAbility
* Add test for Radagast as well as Risen Reef and Caldaia Guardian
* Minor associated cleanup for EntersBattlefieldAllTriggeredAbility
* New PermanentEnteringBattlefieldManaValue
2023-07-09 22:04:45 -04:00
Susucre
39904d0ca3
[LTR] Implement Boromir, Warden of the Tower ( #10594 )
...
* [LTR] Implement Boromir, Warden of the Tower
* group trigger from Boromir and Lavinia
* fix trigger text
2023-07-09 16:42:29 -04:00
Susucre
f8b1ada369
Fix RevealTargetFromHandCost when no target in hand ( #10593 )
...
* [CSP] Fix the RevealTargetFromHandCost not allowing payment when no valid card to reveal
* cleanup text of cost
* fix martyr of bones text
* fix test using a Martyr of Sands
2023-07-09 16:42:16 -04:00
xenohedron
b86014a29c
Text fixes [CSP] ( #10599 )
...
* fix text: ExileFromHandCost
* fix text: CumulativeUpkeepAbility
* text fixes: individual CSP cards
* text fix followups
2023-07-09 02:14:42 -04:00
Oleg Agafonov
4ae5ca8421
docs: card hints usage improved
2023-07-09 02:21:56 +04:00
xenohedron
0fa971514a
code style: eliminate unnecessary static imports ( #10585 )
...
* SacrificeTargetCost(StaticFilters)
* remove import static mage.constants.Outcome
* remove import static mage.constants.Duration
* remove other import static
* a few more sacrifice filters
* simpler constructors
* remove import static mage.filter
* remove a few more import static
2023-07-08 13:08:28 -04:00