Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions
41772 commits 5 branches 220 tags 1.1 GiB
Commit graph

1758 commits

Author SHA1 Message Date
xenohedron
144b261fc2 another batch of text fixes 2023-09-07 02:22:16 -04:00
xenohedron
34b671bc83 cleanup add color/subtype attached effects 2023-09-07 02:22:16 -04:00
xenohedron
72be1856f7 describe targets: look at hand; can't be blocked 2023-09-07 02:22:16 -04:00
Oleg Agafonov
4b3a19b4d5 refactor: improved target usage, replaced setNotTarget by withNotTarget 2023-09-07 05:35:54 +04:00
Susucre
7b5139742f
[JUD] Fix Wormfang Turtle & Wormfang Newt (#11100) 
text generation & wrongly targetting
 2023-09-05 22:27:19 -04:00
Oleg Agafonov
8a65b0f149 refactor: removed netbeans's auto-generated comments 2023-09-02 16:05:29 +04:00
Susucre
344ff81a37
[WOE][WOC] Fixed card texts, fixed Free the Fae (#11098) 
* fix name compare when both full and small name are used
* fix Free the Fae, it is mandatory
 2023-09-02 15:40:40 +04:00
xenohedron
d6c690601d
Merge pull request #11031 from xenohedron/cleanup-7a-7b 
More SetBasePowerToughnessSourceEffect cleanup
 2023-08-31 00:29:59 -04:00
Oleg Agafonov
060b8f9dc9 backup ability: fixed wrong duration and discard in Streetwise Negotiator, added related tests and runtime/verify checks (related to #11068) 2023-08-31 07:29:05 +04:00
Oleg Agafonov
6768184e18 typo fixed (related to #11068), added backup ability docs 2023-08-31 06:06:47 +04:00
xenohedron
22961162ad text fixes related to recent updates 2023-08-30 20:54:27 -04:00
Vivian Greenslade
a65c2204ce
Rework CombatDamageByToughness effects (#11068) 
* split effect into three classes for convenience

* added static filter

* refactored cards using effect

* fixed issues as per PR comments

* changed predicate and fixed text

* added unit test, fixed text issues with Baldin

* set static text

* changed outcome

* added stop to test

* fixs issues as per PR comments
 2023-08-30 20:16:14 -04:00
Susucre
96a2c277b2
clean some of the most frequent copy constructor / copy method (#11053) 2023-08-30 19:48:03 -04:00
Susucre
fab00d2f27
[WOE] Implement Curse of the Werefox (#11009) 
* [WOE] Implement Curse of the Werefox

* apply review

* Fix aura (and equipment?) tokens not checking for protection on target

* fix targetting of reflexive trigger, by creating a custom fight effect.

* fix reflexive ability target.
 2023-08-30 19:16:22 -04:00
Susucre
2a5dd4103c
[WOE] Implement Ashiok, Wicked Manipulator (#10909) 
* [WOE] Implement Ashiok, Wicket Manipulator

* Add Ashiok's abilities

* basic pay life replacement tests

* many tests later

* add warning on token expecting watcher

* apply review

* rework text generation
 2023-08-30 19:15:56 -04:00
xenohedron
a427406d5f fix Sutured Ghoul 2023-08-29 23:33:59 -04:00
Susucre
fa778d352d
[WOE] Implement Elusive Otter (#11061) 2023-08-29 09:35:34 -04:00
xenohedron
476136b766 add logic to check zcc 2023-08-27 00:28:37 -04:00
xenohedron
2eab7836f6 cleanup SetBasePowerToughnessSourceEffect usages 2023-08-26 23:51:49 -04:00
xenohedron
ab0abcfd22 simplify SetBaseToughnessSourceEffect 
fix Duration.WhileOnBattlefield -> Duration.Custom in some effects
 2023-08-26 23:51:33 -04:00
xenohedron
33a859cb68 simplify SetBasePowerSourceEffect 2023-08-26 23:51:33 -04:00
xenohedron
c84fbfd00e new SetBasePowerToughnessPlusOneSourceEffect 2023-08-26 23:51:33 -04:00
xenohedron
5d0c1c96c8 remove sublayer parameter in SetBasePowerToughnessSourceEffect 2023-08-26 23:14:30 -04:00
xenohedron
dcca63b963 more text fixes! 2023-08-26 23:04:13 -04:00
xenohedron
70bf68a5a4 simplify constructors in GainAbilityAllEffect 2023-08-26 21:53:08 -04:00
xenohedron
869de1eac6
fix getText() overrides ignoring staticText (#11044) 
* fix text: SkipNextPlayerUntapStepEffect

* remove old copyright info

* individual card text fixes

* fix overrides ignoring staticText
 2023-08-26 20:47:02 -04:00
Susucre
52eaa600ba
text fixes [ALA] [CON] [ARB] (#11036) 
* Tweak verify for double cycling
* small fixes
* do not verify some GUI-related rules.
 2023-08-26 20:46:49 -04:00
Susucre
a9870b6ff8
text fixes [WOE] etc. (#11035) 
* Fix Callous Sell Sword text

* simple text fixes

* fix some target texts
 2023-08-26 19:34:49 -04:00
Susucre
c4e48a6f95
[WOE] Implement The End (without breaking morph tests this time) (#11041) 
* [WOE] Implement The End

* add cost reduction

* apply review

* fix tests looking for morphs
 2023-08-26 19:34:21 -04:00
Susucre
aa71f0ba8a
Refactor DoIfCostPaid; Inform player on cost not paid. (#10942) 2023-08-26 17:29:30 -04:00
xenohedron
4d03deda12
Revert "[WOE] Implement The End (#10921)" (#11040) 
This reverts commit fe93d68b1c.
 2023-08-26 17:28:09 -04:00
xenohedron
66cc15ed4b
Cleanup copy methods (#11038) 
* remove System.out.println
* Card copy() covariant return
* Effect copy() covariant return
* Cost copy() covariant return
* Ability copy() covariant return
* ContinuousEffect copy() covariant return
 2023-08-26 16:47:54 -04:00
Susucre
fe93d68b1c
[WOE] Implement The End (#10921) 2023-08-26 16:45:51 -04:00
xenohedron
ed4a1bf33f [WOE] text fixes 2023-08-26 00:02:40 -04:00
Susucre
7a93681112
fix Tree of Redemption (#11024) 2023-08-25 21:11:08 -04:00
Susucre
8e36a178a5
[WOE] Implement Pollen-Shield Hare (#10932) 
* [WOE] Implement Pollen-Shield Hare

* apply review

---------

Co-authored-by: Evan Kranzler <theelk801@gmail.com>
 2023-08-24 21:20:13 -04:00
Susucre
493cb811d5
[WOE] Implement Gruff Triplets (#10791) 
* [WOE] Implement (Leaked) Gruff Triplets

* fix name predicate

* remove unecessary file with wrong predicate

---------

Co-authored-by: Evan Kranzler <theelk801@gmail.com>
 2023-08-24 18:26:11 -04:00
xenohedron
6624e141c6 cleanup GainAbilityTargetEffect 
remove unused parameters

strip reminder text
 2023-08-24 00:51:47 -04:00
Susucre
c047829614
[WOE] Implement Devouring Sugarmaw (#10969) 
* [WOE] Implement Devouring Sugarmaw

* fix adventure cost

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
 2023-08-23 20:38:26 -04:00
ssk97
a756529e05
Fix casting commander transformed (#10790) 
Remove CastCommanderAbility and instead apply the modification directly
 2023-08-24 03:30:09 +04:00
Susucre
65dba6c92d
[WOE] Implement Cheeky House-Mouse (#10945) 2023-08-22 23:14:04 -04:00
Susucre
4d3daaa5fa
[WOE] Implement Rotisserie Elemental (#10944) 2023-08-22 20:19:25 -04:00
xenohedron
4af977289e
refactor effects "you may cast... from... graveyard... exile it instead" (#10926) 
* cleanup exiling cast spells

* common class MayCastTargetThenExileEffect

* fix zcc check

* add test suite
 2023-08-21 00:26:09 -04:00
xenohedron
e02df1353a
cleanup discard effects (#10924) 
* change text generation to use target

* remove a constructor

* condense another constructor

* condense numberCardsToDiscard constructors

* fully remove TargetController

* chaining for optional parameter

* new LookTargetHandChooseDiscardEffect
 2023-08-20 13:30:44 -04:00
xenohedron
035913988a
refactor: standardize to CantAttackYouAllEffect (#10923) 
* adjust CantAttackYouAllEffect text, check permanent is planeswalker

* switch 3 cards to main class, remove redundant class
 2023-08-20 13:28:37 -04:00
Susucre
43de68afe3
[WOE] Implement Stroke of midnight (refactor together similar effects) (#10834) 
* [WOE] Implement Stroke of Midnight

* refactor similar effects together.

* add tests (and fix a bug)

---------

Co-authored-by: Evan Kranzler <theelk801@gmail.com>
 2023-08-18 18:27:36 -04:00
theelk801
8753c94488 [WOC] Implement Gylwain, Casting Director 2023-08-18 15:26:38 -04:00
Susucre
8ad37e19b8
[WOE] Implement Decadent Dragon (#10852) 
Grouped together a few Gonti-like look effect.

Co-authored-by: Evan Kranzler <theelk801@gmail.com>
 2023-08-18 15:13:13 -04:00
Evan Kranzler
b892562b95
Fixing aura token creation (#10858) 
* rework aura token creation

* add missing copy constructor

* add message for token if unable to be created

* add a few extra role tests
 2023-08-18 13:25:48 -04:00
Susucre
6a66b0d709
[WOE] Implement Virtue of Knowledge (#10855) 2023-08-18 09:24:51 -04:00