Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

refactor: clean, added comments and todos to meld related code, fixed miss copy (related to #12544)

Browse source
This commit is contained in:
Oleg Agafonov 2024-07-01 22:43:58 +04:00
parent ddb7e21dc2
commit bccf323c0f
5 changed files with 36 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Mage/src/main/java/mage/cards/MeldCard.java
View file

@ -7,6 +7,7 @@ import mage.counters.Counter;
import mage.game.Game;
import mage.game.events.ZoneChangeEvent;
import mage.game.permanent.Permanent;
import mage.util.CardUtil;
import java.util.List;
import java.util.UUID;
@ -30,8 +31,8 @@ public abstract class MeldCard extends CardImpl {
protected MeldCard(final MeldCard card) {
super(card);
this.topHalfCard = card.topHalfCard;
this.bottomHalfCard = card.bottomHalfCard;
this.topHalfCard = CardUtil.deepCopyObject(card.topHalfCard);
this.bottomHalfCard = CardUtil.deepCopyObject(card.bottomHalfCard);
this.topLastZoneChangeCounter = card.topLastZoneChangeCounter;
this.bottomLastZoneChangeCounter = card.bottomLastZoneChangeCounter;
this.halves = new CardsImpl(card.halves);
@ -135,6 +136,7 @@ public abstract class MeldCard extends CardImpl {
boolean value = topLastZoneChangeCounter == topHalfCard.getZoneChangeCounter(game)
&& halves.contains(topHalfCard.getId());
if (!value) {
// TODO: sync code with deleting halfs ref smells bad - looks like melds have problems with zcc sync (topLastZoneChangeCounter)
halves.remove(topHalfCard);
}
return value;
@ -144,6 +146,7 @@ public abstract class MeldCard extends CardImpl {
boolean value = bottomLastZoneChangeCounter == bottomHalfCard.getZoneChangeCounter(game)
&& halves.contains(bottomHalfCard.getId());
if (!value) {
// TODO: sync code with deleting halfs ref smells bad - looks like melds have problems with zcc sync (bottomLastZoneChangeCounter)
halves.remove(bottomHalfCard);
}
return value;