Steven Knipe
660288dfd7
Use generics to ensure the correct class types stored inside the costs tags.
2023-11-17 02:37:06 -08:00
ssk97
ca80849249
game: fixed "if mana was spent to cast" abilities after leaves ( #11419 )
...
* ManaWasSpentCondition should use MageObjectReferences
2023-11-17 12:02:47 +04:00
Steven Knipe
193a19104c
Improved Altered Ego rules documentation
2023-11-16 23:35:09 -08:00
Tirth Bharatiya
44b8a0faf4
refactor: improved code to increase readability. ( #11418 )
...
Moved the cardViewEquals method from CardPanelRenderModeMTGO to CardView
Decomposed conditional to increase readability.
Changed the variable/constant names to increase the readability.
2023-11-17 10:47:53 +04:00
Steven Knipe
177f72c8d8
Altered ego X value should be separate
2023-11-16 18:21:02 -08:00
Steven Knipe
18600a53a9
Add new/Enable existing tests
2023-11-16 18:09:02 -08:00
Steven Knipe
77dd1711b5
Convert Kicker to costs tag system
2023-11-16 15:07:58 -08:00
Steven Knipe
1e76b59f4e
Convert Bargain/Entwine/Squad to costs tag system
2023-11-16 14:39:55 -08:00
Steven Knipe
ad873863fa
Convert SpellAbility keywords to costs tag system
2023-11-16 14:39:13 -08:00
Steven Knipe
f3d5faf199
Convert AlternativeSourceCostsImpl keywords to using the costs tag system
2023-11-16 14:37:38 -08:00
ssk97
bea33c7493
Costs Tag Tracking part 2: Tag system and X values, reworked deep copy code ( #11406 )
...
* Implement Costs Tag Map system
* Use Costs Tag Map system to store X value for spells, abilities, and resolving permanents
* Store Bestow without target's tags
Change functions for getting tags and storing the tags of a new permanent
* Create and use deep copy function in CardUtil, add Copyable<T> to many classes
* Fix Hall Of the Bandit Lord infinite loop
* Add additional comments
* Don't store null/empty costs tags maps (saves memory)
* Fix two more Watchers with Ability variable
* Add check for exact collection types during deep copy
* Use generics instead of pure type erasure during deep copy
* convert more code to using deep copy helper, everything use Object copier, add EnumMap
* fix documentation
* Don't need the separate null checks anymore (handled in deepCopyObject)
* Minor cleanup
2023-11-16 23:12:32 +04:00
PurpleCrowbar
72e30f1574
Fix Illithid Harvester assigning Horror subtype to unturnable TDFCs
2023-11-16 18:14:37 +00:00
PurpleCrowbar
4791bbb81f
Changed Cunning Rhetoric to exile cards to its own exile zone
2023-11-16 17:50:15 +00:00
Susucre
b538d4714c
[LCI] Implement Sunken Citadel
2023-11-16 11:51:10 +01:00
Susucre
0241a788a0
add a couple null check to Modes' value Key creation
...
normal game usage should have no issue, but the Pillar Custom mode
initializing a Delayed Trigger at game init can not have a real source set up.
Might revisit 'game init' trigger in a better way in the future.
For now this fix is enough to avoid a NPE using the Pillar game mode.
2023-11-16 11:08:11 +01:00
xenohedron
837d756746
fix text better
2023-11-15 23:27:58 -05:00
xenohedron
fe4ddc8d74
fix granted ability text on Blazing Torch
2023-11-15 23:07:08 -05:00
xenohedron
f6faad4c7b
align order of abilities on Wooden Stake
2023-11-15 23:07:07 -05:00
Oleg Agafonov
892b4ebd95
Merge pull request #11411 from tirth1/refactor-gameController
2023-11-16 04:43:47 +03:00
tirth1
83b5511d60
Refactored attemptToFixGame method inside GameController.
2023-11-15 19:52:48 -04:00
Evan Kranzler
791496d285
refactor vanishing ( #11408 )
2023-11-14 08:26:08 -05:00
PurpleCrowbar
df5020ed9c
Add hint to Biovisionary
2023-11-13 18:24:33 +00:00
theelk801
6f437f0389
remove temporary verify skip, fix failures
2023-11-13 10:42:32 -05:00
ssk97
ec4c79e0e0
Fix copying subabilities to no longer duplicate them ( #11399 )
...
* Fix Subability copy bug (fix #10526 )
* Cards which copy abilities of other cards should not copy subabilities.
* Enable previously-failing tests
* Find more addAbility that should be done without subabilities
* Add documentation to addAbility function
* Add warning about not using basic addAbility when copying from a source
* Invert withSubabilities to fromExistingObject
2023-11-12 19:57:39 -05:00
Susucre
3972e80860
fix Master's Manufactory colors
2023-11-10 18:12:40 +01:00
Susucre
68e2f74d13
update listing for new cards changelog
2023-11-10 17:33:50 +01:00
xenohedron
b521b6c123
fix verify failure
2023-11-10 00:13:48 -05:00
xenohedron
caacdc51ee
adjust LCI booster gen DFC rarity ratio
2023-11-09 23:47:47 -05:00
xenohedron
2dffe58e41
remove AI from beta server button in connect dialog
2023-11-09 23:33:52 -05:00
xenohedron
36201c6941
fix Twists and Turns DFC class
2023-11-09 23:31:24 -05:00
xenohedron
d937f7279e
fix Contested Game Ball
2023-11-09 22:05:22 -05:00
xenohedron
933d694b08
implement [LCI] Market Gnome
2023-11-09 21:42:57 -05:00
xenohedron
a5922457ad
implement [LCI] Contested Game Ball
2023-11-09 20:45:37 -05:00
xenohedron
ded7eeeaa8
align DISCOVERED event to naming convention
...
no need for custom event class
2023-11-09 20:44:52 -05:00
xenohedron
af05e6f940
add test coverage
2023-11-09 19:53:30 -05:00
theelk801
74988a1c23
remove Cat subtype from Rakshasa cards and add temporary verify skip
2023-11-09 11:43:11 -05:00
xenohedron
9eeaf9cae1
fix text
...
fix Jade Seedstones craft cost
2023-11-09 00:39:40 -05:00
xenohedron
ae4d4b6190
implement [LCI] Magmatic Galleon
2023-11-09 00:00:26 -05:00
xenohedron
5c83bbe970
refactor Quartzwood Crasher; Goro-Goro and Satoru
...
to use DealCombatDamageControlledTriggeredAbility
2023-11-08 23:28:12 -05:00
xenohedron
4a250c48a5
implement [LCI] Kutzil, Malamet Exemplar
2023-11-08 23:09:39 -05:00
xenohedron
87a313e89c
reminder text adjustment: bloodthirst
2023-11-08 22:27:34 -05:00
Jeff Wadsworth
3b90880fa3
Fixed #11381
...
The rest of these types of cards need to be fixed as well.
2023-11-07 17:09:56 -06:00
Jeff Wadsworth
b1e7e589ee
Refactored Ent's Fury
2023-11-07 10:20:26 -06:00
Oleg Agafonov
202f4b5112
Merge fix
2023-11-07 02:54:23 +04:00
Oleg Agafonov
ddc1ec8ef8
performance: improved CPU/memory usage with copy of cost's targets (related to #11285 ), added runtime check for wrong targets usage
2023-11-07 02:47:48 +04:00
Oleg Agafonov
d6c858ecaf
performance: added day/night performance test for transform ability (disabled by default, see DayNightTest, related to #11285 ), added day/night rules ref
2023-11-07 01:25:15 +04:00
Oleg Agafonov
70c79fd6a6
performance: improved CPU usage in games with big amount of permanents (related to #11285 )
2023-11-07 01:14:07 +04:00
Susucre
1f50f95f8b
fix verify tests
2023-11-06 20:39:32 +01:00
Oleg Agafonov
089ff267a7
tests: added additional check for Karn Liberated (related to #11081 )
2023-11-06 12:11:59 +04:00
Oleg Agafonov
dfbd6627e5
game: fixed miss watchers from second side of transformable cards ( closes #11329 );
2023-11-06 10:40:05 +04:00
