Commit graph

13110 commits

Author SHA1 Message Date
PurpleCrowbar
6ea286eb89 Add CMM token images 2023-08-10 01:10:17 +01:00
xenohedron
00340a3bda
fix null SetTargetPointer (#10772) 2023-08-08 01:37:14 -04:00
xenohedron
35a5cc48a7
Improve DealsCombatDamageEquippedTriggeredAbility (#10767)
* improve variable name

* add test for Jitte trample damage

* fix duplicated triggers when trampling over to player

* bring corresponding ability into alignment

* adjust authorship, comment
2023-08-06 23:04:53 -04:00
Artemis Kearney
9ba0da00ff
Basic groundwork for extra decks (contraptions, attractions) (#10378)
* extra deck cards not counted in deck size

* extra deck handling in deckbuilder

* move responsibility for extraDeckCard boolean to CardImpl

* remove redundant field copy
2023-08-06 21:06:32 -04:00
sprangg
287df7af21
Wait 2 seconds before making the draft pick for a timed out player (#10733)
* The draft session waits for 5 seconds before making the pick for the timed out player

* Formatting

* Renamed constant

* Tweak

* If the draft pick's timeout value would increase the client's pick's timer, don't set it (might happen if the client or server is lagging)

* Lowered BOOSTER_LOADING_INTERVAL and AUTOPICK_BUFFER

---------

Co-authored-by: sprangg <a@b.c>
2023-08-06 20:00:42 -04:00
theelk801
456ea87107 finish reverting my ill-advised refactor 2023-08-06 19:28:16 -04:00
theelk801
3313f7affb Revert "simplify vanishing implementation"
This reverts commit 399b65effb.
2023-08-06 19:25:05 -04:00
theelk801
44a2b06690 Revert "add workaround for vanishing issue"
This reverts commit 2f0077e3cf.
2023-08-06 19:25:00 -04:00
theelk801
2f0077e3cf add workaround for vanishing issue 2023-08-06 17:36:35 -04:00
theelk801
715fca1399 fix error 2023-08-06 15:17:56 -04:00
theelk801
399b65effb simplify vanishing implementation 2023-08-06 14:16:03 -04:00
theelk801
4a67507e2b [WHO] Implement The Eleventh Hour 2023-08-05 22:16:01 -04:00
xenohedron
127b7be9b0
more unrelated text fixes (#10761)
* some text fixes [LTR] [LTC] [CMM]

* another batch of text fixes

* followup fixes

* unrelated cleanup

* fix corresponding ability text in test
2023-08-05 20:53:43 -04:00
Susucre
fa77261e3a
Add more missing copy constructors. (#10758) 2023-08-05 20:53:32 -04:00
theelk801
8830fd0cc8 [WHO] Implement The Thirteenth Doctor 2023-08-05 13:44:40 -04:00
theelk801
aa1624dc1c [WHO] Implement Sarah Jane Smith 2023-08-05 13:30:40 -04:00
Susucre
0e5069ccc2
[LTC] Implement Gandalf, Westward Voyager (#10727)
* refactor and cleanup SpellCastControllerTriggeredAbility

* [LTC] Implement Gandalf, Westward Voyager

* throw on unexpected setTargetPointer
2023-08-04 22:26:25 -04:00
xenohedron
549c9cb863 new DefendingPlayerControlsAttachedAttackingPredicate
cleanup Heart-Piercer Bow
fix Lothlorien Blade
2023-08-04 22:14:53 -04:00
Susucre
9979208f05
[LTC] Implement Champions of Minas Tirith (#10726)
repurposed (and renamed) CantAttackYouEffect.java, that was actually not used.
2023-08-04 21:20:55 -04:00
Susucre
894d557952
Add additional copy test to check copy of effects/abilities (#10754)
* add further copy test

* add more missing copy constructors/methods
2023-08-04 20:10:23 -04:00
Susucre
4ebfd79005
refactor DefendingPlayerControlsCondition (#10749) 2023-08-04 20:10:08 -04:00
Susucre
f75b1c9f0a
Code cleanup: protect all copy constructors (#10750)
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
2023-08-04 19:34:58 -04:00
Susucre
5c58e28f9b
Fix King of the Oathbreaker (#10747) 2023-08-04 18:37:11 -04:00
Susucre
9889baa0bc
Fix game freeze caused by TotalPermanentsManaValue hint copy (#10751) 2023-08-04 18:09:43 -04:00
Susucre
b9a2278d4f
fix VanishingUpkeepAbility missing a copy for a field (#10755) 2023-08-04 18:09:05 -04:00
Susucre
f366f3097e
Fix Blaze of Glory (#10734)
* Rename DefendingPlayerControlsPredicate to explicitly indicate that the source must be attacking.

I did check all the cards, they all use the predicate inside an attack trigger, or under the condition that the source is attacking.

* Fix Blaze of Glory, rework False Orders with it.
2023-08-03 22:33:52 -04:00
xenohedron
63706942db simplify DoIfClashWonEffect 2023-08-03 22:12:46 -04:00
Susucre
4d3b944b65
Fix Clash effect causing NullPointerExceptions (#10742) 2023-08-03 22:11:59 -04:00
ssk97
b144cb6f03
Minor Backup fixes, add tests (#10732)
* Backup is not optional and its effect should be BoostCreature, not Detriment

* Add tests for Backup ability

* Add Mirror-Shield Hoplite source test

* Use Strict mode for the hoplite source test
2023-08-03 00:26:33 -04:00
Susucre
23781ecb37
[LTC] Implement Elrond of the White Council (#10731) 2023-08-03 00:26:19 -04:00
Susucre
5a6ee98b41
[LTC] Implement The Black Gate (#10725) 2023-08-03 00:25:54 -04:00
xenohedron
ec3bb197fb various text fixes 2023-08-02 22:54:35 -04:00
Susucre
04845072ea
[LTC] Implement Field-Tested Frying Pan (#10721) 2023-08-01 09:51:19 -04:00
Susucre
241226cd83
[LTC] Implement Summons of Saruman (#10720)
* [LTC] Implement Summons of Saruman

* fix constructor for Assault on Osgiliath

* fix verify failure

* refactoring a couple more Amass X
2023-08-01 09:51:06 -04:00
Susucre
1c5829f16b
[LTC] Implement Rapacious Guest (#10719) 2023-08-01 09:50:45 -04:00
Susucre
0938a5cd72
[LTC] Implement Eomer, King of Rohan (#10713) 2023-08-01 09:50:16 -04:00
Susucre
40e508ac19
Refactor Devour ability; [LTC] Implement Feasting Hobbit (#10708)
* [LTC] Implement Feasting Hobbit

Refactor DevourEffect and its text generation, to be more permissive in the future.

* change DevourAbility to have the constructor parameters of DevourEffect

* only pluralize when there is more than 1 devoured permanent.

* added more unit tests than there are cards with devour

* public -> private filter of Caprichrome.
2023-08-01 09:49:32 -04:00
Oleg Agafonov
3d3358cd05 game: turn modification improves:
- fixed miss phase changed events and logs in some use cases;
 - added source info in turn modification logs;
 - added game logs for take and lost control of the spell (example: Word of Command)
 - added game logs for skip step;
 - added game logs for extra step;
 - added game logs for skip phase;
2023-08-01 16:52:53 +04:00
Susucre
e724166569
[LTC] Implement Cavern-Hoard Dragon (#10724) 2023-07-31 23:53:06 -04:00
Susucre
61a6657127
[LTC] Implement Crown of Gondor (#10722) 2023-07-31 23:52:43 -04:00
Susucre
d61e454e77
[LTC] Implement Of Herbs and Stewed Rabbit (#10718) 2023-07-31 23:52:28 -04:00
Susucre
378fd2743e
[LTC] Implement Taunt from the Rampart (#10717) 2023-07-31 23:52:15 -04:00
Susucre
67407a8780
[LTC] Implement Motivated Pony (#10716) 2023-07-31 23:51:59 -04:00
Susucre
63d9061f6a
[LTC] Implement Assemble the Entmoot (#10711)
* [LTC] Implement Assemble the Entmoot

* rename ControllerGotLifeCount -> ControllerGainedLifeCount
2023-07-31 23:50:29 -04:00
Oleg Agafonov
8d938926b6 refactor: improved usage of one time turn modifications (skip step, extra turn, etc) 2023-07-31 20:16:28 +04:00
Susucre
4554fbc408
[LTC] Implement Denethor, Stone Seer (#10709)
* [LTC] Implement Denethor, Stone Seer

* rename game.damagePlayerOrPlaneswalker.

Reason being that It does actually damage any player or permanent.
2023-07-30 23:06:21 -04:00
Susucre
fbc0cd61dd
[LTC] Implement Banquet Guests (#10706)
* make a StaticFilter for "a food"

* [LTC] Implement Banquet Guests

Made a Static Filters for controlled food, with the next eldraine set we'll certaintly see more of that.

* future proof static text for mulitplier > 2
2023-07-30 19:26:26 -04:00
Susucre
53b270fc36
[CMM] Implement Rukarumel, Biologist (#10703) 2023-07-30 19:26:11 -04:00
Susucre
a53abeaf40
[CMM] Implement Descendants' Fury (#10700)
* [CMM] Implement Descendants' Fury

* various cleanup

* reset watcher on cleanup, in case of 'end the turn' during combat damage step
2023-07-30 19:25:43 -04:00
Susucre
263b01e702
[CMM] rework Narci, Fable Singer (#10699)
* easy fix first

* use targetPointer in Narci effect.
2023-07-29 13:46:40 -04:00