Commit graph

13110 commits

Author SHA1 Message Date
xenohedron
6820aa5ee1 fix #11783 (default card drawn hint only when applicable) 2024-03-23 17:17:09 -04:00
xenohedron
40b55f7a59 fix text gen typo 2024-03-23 01:08:58 -04:00
xenohedron
09a05c6069 adjust text gen 2024-03-23 00:51:49 -04:00
jimga150
50c75f05bd
[MAT] implemented Ob Nixilis, Captive Kingpin, refactored life lose and batches events (#11974) 2024-03-21 19:53:45 +04:00
Cameron Merkel
9474f67f5c
[PIP] Implement Nick Valentine, Private Eye (#11965) 2024-03-18 23:10:22 -04:00
xenohedron
5df392af64
fix face-down creature spells cost reduction to include disguise (#11962) 2024-03-18 23:09:52 -04:00
xenohedron
d5295b0de3
Improve handling of abilities that let you cast spells from not hand zone once per turn (#11946)
* fix name of existing test

* adjust class name

* generate text

* use common class for Danitha

* add test

* update Gisa and Geralf

* rework Cemetery Illuminator, add test

* simplify effects allowing play from top of library

* simplify common classes which were bloated to support a single card

* simplify another

* remove unused import from test

* rework to check spell ability

* add more test cases

* add test cases

* add failing test case

* common watcher and hint for "once each turn, you may cast..."

* fix Assemble the Players to check spell ability, add test

* apply same improvements to Johann, Apprentice Sorcerer
2024-03-18 23:09:31 -04:00
xenohedron
ca45c06f71
Merge branch 'master' into case-of-the-pilfered-proof 2024-03-18 01:24:26 -04:00
xenohedron
ae4cff1803 text fixes 2024-03-17 20:00:00 -04:00
ssk97
b9bfe2ba48
Megamorph abilities - fixed that face down creatures show megamorph instead morph status (#11957)
* Megamorph should appear as if it were Morph

* review comment
2024-03-18 03:58:02 +04:00
jimga150
67286aa1a0
Implement Damage Batch for Permanent event (#11841)
* implement [WHO] Donna Noble

* Changed trigger to DAMAGED_BATCH_FOR_PERMANENTS, check for need of separate targets

* fix short circuit operator

* simplify control path in paired damage trigger

* Initial commit, missing tests

* use CardUtil.getEventTargets

* Implement Donna Noble using DamagedBatchForOnePermanentEvent

* fix double-effect bug

* remove unnecessary custom effect

* Fix addSimultaneousDamage to avoid adding damage events to existing DamagedBatchForOnePlayerEvent instances when they shouldnt

* Add clarifying comment

* Incorporate batching of DAMAGED_BATCH_FOR_ONE_PERMANENT into if-else if tree to match new logic

* Add tests

* make ability inline

* Move DamageBatchTests

* Change batch events to take first event in constructor
2024-03-17 16:15:50 -04:00
xenohedron
56ba6b1072 fix some text 2024-03-14 23:13:56 -04:00
jimga150
b29a4e6349
Fix addSimultaneousDamage to avoid adding damage events to existing DamagedBatchForOnePlayerEvent instances when they shouldn't (#11943)
* Fix addSimultaneousDamage to avoid adding damage events to existing DamagedBatchForOnePlayerEvent instances when they shouldnt

* Add clarifying comment
2024-03-14 20:18:53 -04:00
xenohedron
e2e3149de0 fix #11938 - Snow-Covered Wastes
must be basic for deck validator
2024-03-14 00:30:55 -04:00
Oleg Agafonov
b746a601f2 docs: added additional comments for #11933 2024-03-12 11:13:43 +04:00
Cameron Merkel
a7f808afb6
Implement [MKM] Connecting the Dots; [PIP] Expert-Level Safe; related refactoring (#11922)
* Switch to common class for exiling top cards of your library

* Replace some custom classes with ReturnFromExileForSourceEffect; text-gen additions to that Effect

* Knowledge Vault: add tap cost to 1st ability, fix text on 3rd ability; Petradon: remove unused import

* [MKM] Implement Connecting the Dots

* [PIP] Implement Expert-Level Safe

* Set staticText in constructor

* Use {this} in Expert-Level Safe text

* Use createObjectRealtedWindowTitle for exile names

* Remove unnecessary field
2024-03-11 00:16:42 -04:00
skiwkr
3945528d40
[WHO] Implement Me, The Immortal (#11930) 2024-03-11 00:16:18 -04:00
xenohedron
8969e1a5de fix #11921 (Norn's Decree) and similar
fix Iron Mastiff

fix Tahngarth, First Mate
2024-03-09 21:43:01 -05:00
xenohedron
73e9b8da49 add 5 minute match timer option (closes #11925) 2024-03-09 21:37:17 -05:00
theelk801
59bf39f666 add sloth subtype, fix verify error 2024-03-09 17:54:54 -05:00
xenohedron
347f07ce81
Cleanup subtype filters that shouldn't limit to creatures (#11920)
* common Cohort Ability
2024-03-07 22:34:07 -05:00
Matthew Wilson
ba77ed000f
[MKM] Implement Illicit Masquerade (#11882) 2024-03-07 19:03:06 -05:00
PurpleCrowbar
e5759bbd9e
[PH17] Implement Inzerva, Master of Insights (#11774)
* Remove superfluous code from fateseal effect
2024-03-07 19:02:52 -05:00
tiera3
b6d1e2a93b
enforce deck validator limit for Once More with Feeling (#11913) 2024-03-06 18:48:54 -05:00
Cameron Merkel
fc5ee90bf8
[MKC] Implement Experiment Twelve, changes to TargetPermanentPowerCount (#11901) 2024-03-04 14:42:04 +04:00
xenohedron
9893032a36
rework Ghastly Conscription and Jeskai Infiltrator to common manifest code (#11898) 2024-03-03 21:16:46 -05:00
xenohedron
bce44f9cb9 fix some text 2024-03-03 21:03:27 -05:00
xenohedron
cfc6808dde
update Suspend Ability for optional casting (#11892)
* update Suspend Ability for optional casting

per latest rules update

* fix another test
2024-03-02 23:47:45 -05:00
xenohedron
5d0cd6837a add docs for ZONE_CHANGE_GROUP usage 2024-03-02 22:36:39 -05:00
Oleg Agafonov
11ddfa0087 Manifest abilities - improved combo support for MDF, split and other cards (related to #10803, part of #11873) 2024-03-02 14:49:17 +04:00
Oleg Agafonov
6cd8359fbd merge fix 2024-03-02 12:09:53 +04:00
Oleg Agafonov
00c3efedcf refactor: improved Manifest effects to use shared code, added docs, todos and tests for all simple usages (part of #11873) 2024-03-02 12:01:05 +04:00
Oleg Agafonov
55f1d36695 game: improved visible rules of face down cards, removed visible face up cost (part of #10653, #11884) 2024-03-01 16:47:59 +04:00
Oleg Agafonov
9ea3356b77 [WHO] implemented Disguise ability (new face down type, ability and token image, #10653) 2024-03-01 16:47:59 +04:00
PurpleCrowbar
c39c8be9b6 Fix investigate effect text 2024-03-01 00:11:30 +00:00
Oleg Agafonov
c8a9a1a9db game: improved game logs for faced-down spells and exiled cards - now it support popup hint to view card/permanent (part of #11884, related to #11881, #8781) 2024-03-01 02:08:25 +04:00
Oleg Agafonov
4334ac8987 refactor: added face down status to SpellAbilityCastMode (related to #11884); 2024-02-29 22:33:37 +04:00
Oleg Agafonov
734e2fae0f refactor: removed outdated or un-used code (part of #11873) 2024-02-29 07:50:13 +04:00
PurpleCrowbar
68bfe4fd6f Improve rule generation for DealsDamageToAPlayerAllTriggeredAbility 2024-02-29 02:57:39 +00:00
PurpleCrowbar
3aa44bc7ef Add MKC token images 2024-02-29 02:02:03 +00:00
PurpleCrowbar
c4668476b1 Fix SacrificedArtifactThisTurnCondition 2024-02-29 01:33:30 +00:00
Oleg Agafonov
e38a79f231
Face down images and cards rework (#11873)
Face down changes:
* GUI: added visible face down type and real card name for controller/owner (opponent can see it after game ends);
* GUI: added day/night button to view real card for controller/owner (opponent can see it after game ends);
* game: fixed that faced-down card can render symbols, abilities and other hidden data from a real card;
* images: added image support for normal faced-down cards;
* images: added image support for morph and megamorph faced-down cards;
* images: added image support for foretell faced-down cards;

Other changes:
* images: fixed missing tokens from DDD set;
* images: no more client restart to apply newly downloaded images or render settings;
* images: improved backface image quality (use main menu -> symbols to download it);
2024-02-29 01:14:54 +04:00
PurpleCrowbar
79e5a83ec9 [MKC] Implement Sophia, Dogged Detective 2024-02-28 15:50:36 +00:00
PurpleCrowbar
0d11a898fc
refactor: GainAbilityControlledSpellsEffect to enforce nonland card filter (#11871) 2024-02-27 22:42:52 -05:00
PurpleCrowbar
4235949c55 Add MKM token images 2024-02-28 01:07:04 +00:00
Cameron Merkel
9e587ca05d
[MKM] Implement Blood Spatter Analysis (#11863) 2024-02-27 17:30:17 -05:00
PurpleCrowbar
3486c57364
[MKC] Implement Printlifter Ooze (#11865) 2024-02-27 22:29:36 +00:00
PurpleCrowbar
90aa4f84b8 Add RVR token images 2024-02-26 15:53:32 +00:00
PurpleCrowbar
b847e9d0d7 Add LCC token images 2024-02-26 15:22:23 +00:00
PurpleCrowbar
ddcd54c0df
[BLB] Implement Byrke, Long Ear of the Law (#11860)
New common class DoubleCountersTargetEffect
2024-02-26 00:12:14 -05:00