Commit graph

49679 commits

Author SHA1 Message Date
Oleg Agafonov
fe18aa9f4a tests: added verify test for bad conditions with NPE on empty source param (disabled by default, related to #13752) 2025-06-14 17:43:52 +04:00
Susucre
d7bc249bfd fix [FIN] Hope Estheim (missing watcher) 2025-06-14 14:21:30 +02:00
Oleg Agafonov
361c320890 tests: added automated tests to run all possible dialogs under AI (WIP, part of #13643, improved testable dialogs from #13638); 2025-06-14 16:20:24 +04:00
Oleg Agafonov
6ad2cdaa78 AI: improved stability:
- fixed game errors with source related filters (related to #13713);
- fixed game freeze in hand's cards selection (related to #13290);
- fixed game freeze in target amount selection with X=0 (related to #13290);
2025-06-14 16:03:44 +04:00
Oleg Agafonov
e8342e1f11 refactor: improved usage of getSourceObjectZoneChangeCounter, added docs (part of #13737) 2025-06-14 15:31:24 +04:00
xenohedron
492c7c9db8 a bunch of unrelated text fixes 2025-06-14 01:53:56 -04:00
xenohedron
519a9e0c49 small text generation improvement 2025-06-14 01:00:42 -04:00
xenohedron
a223b3f89c fix #13749 (Mirror of Life Trapping) 2025-06-14 00:48:29 -04:00
xenohedron
1b8602bd15 improve text generation for intervening if triggers 2025-06-14 00:46:07 -04:00
xenohedron
76c0124052 tests: enable properties for verify check parameters 2025-06-14 00:34:32 -04:00
xenohedron
24f030fa71
fix #13523 (trigger on becomes the target of recast spell) (#13740)
move findTargetingStackObject from CardUtil to Game, so saved data can be cleared with short living lki

add test cases
2025-06-14 00:09:40 -04:00
Grath
030e8ae5d3 Fix Zone to match on Transpose 2025-06-13 21:34:32 -04:00
theelk801
d6709cd7e9 [ACR] fix Fall of the First Civilization not drawing enough cards 2025-06-13 19:22:20 -04:00
theelk801
b47e33a394 [ACR] fix Fall of the First Civilization not allowing nonlands to be chosen 2025-06-13 18:54:07 -04:00
Grath
e943c4bec8 Fix filter on Red XIII, Proud Warrior 2025-06-13 18:30:09 -04:00
Oleg Agafonov
eec4f0ac7e merge fix 2025-06-13 23:52:59 +04:00
Oleg Agafonov
62eb116124 merge fix 2025-06-13 23:43:55 +04:00
Oleg Agafonov
849aea5946 tests: added fuzzy testing (disabled by default, added random phased out permanents, part of #13748); 2025-06-13 23:09:05 +04:00
theelk801
58b5bb76f9 various text fixes 2025-06-13 13:44:33 -04:00
theelk801
60c8d7254b small fix 2025-06-12 20:39:19 -04:00
theelk801
90d51013ad Delete ConditionalInterveningIfTriggeredAbility.java 2025-06-12 19:59:15 -04:00
theelk801
dbd07b9031 and when the elk saw the breadth of his domain, he wept, for there was no more ConditionalInterveningIfTriggeredAbility to refactor 2025-06-12 19:58:54 -04:00
theelk801
59f7126f64 all refactoring ConditionalInterveningIfTriggeredAbility and no play makes the elk a dull boy 2025-06-12 19:56:43 -04:00
theelk801
79a2f80563 listening to Pet Sounds on repeat while I refactor ConditionalInterveningIfTriggeredAbility 2025-06-12 19:56:43 -04:00
theelk801
cdcda710c8 people keep asking me if I'm refactoring ConditionalInterveningIfTriggeredAbility, and I haven't really had an answer. but now yeah, I'm thinking I'm refactoring ConditionalInterveningIfTriggeredAbility 2025-06-12 19:56:43 -04:00
Grath
0f93ecdb6b Add missing target to Intimidation Tactics 2025-06-12 17:48:43 -04:00
Grath
0d888a85d2 Add missing choose to Memories Returning. 2025-06-11 23:50:31 -04:00
theelk801
94009318b7 I am once again refactoring ConditionalInterveningIfTriggeredAbility 2025-06-11 12:49:31 -04:00
theelk801
9fb082d656 I can stop refactoring ConditionalInterveningIfTriggeredAbility whenever I want 2025-06-11 09:58:16 -04:00
theelk801
15d4ca2edc I have a fever and the only prescription is more refactoring ConditionalInterveningIfTriggeredAbility 2025-06-10 14:40:43 -04:00
theelk801
cc2d234d58 oh boy here I go refactoring ConditionalInterveningIfTriggeredAbility again 2025-06-10 11:30:43 -04:00
theelk801
d80e0402dd even more refactoring of ConditionalInterveningIfTriggeredAbility 2025-06-09 18:53:44 -04:00
theelk801
c24627f175 more refactoring of ConditionalInterveningIfTriggeredAbility 2025-06-09 14:23:30 -04:00
theelk801
a35b6efb87 fix test failure 2025-06-09 12:43:48 -04:00
theelk801
1ae3392a5b [KHM] fix Rise of the Dread Marn counting noncreature permanents (fixes #13738) 2025-06-09 12:19:26 -04:00
theelk801
a895ac9803 some more refactoring of ConditionalInterveningIfTriggeredAbility 2025-06-09 12:06:11 -04:00
Jeff Wadsworth
c2daa00b74 Fixed #13729 2025-06-08 19:48:04 -05:00
Grath
e07a69710b
Fix Zenos yae Galvus and Shinryu, Transcendent Rival triggers. 2025-06-08 11:39:19 -04:00
Grath
a43846385a Use code from getCurrentSourceObjectZoneChangeCounter to lookup ZCC of actual permanent rather than ability's ZCC which is, unexpectedly, statically set to 0 by design. 2025-06-08 11:20:47 -04:00
xenohedron
47f2a4fbe5 remove some unneeded filter classes, add static filters
related to #13734
2025-06-08 01:52:14 -04:00
xenohedron
663ada11d1 minor linting 2025-06-08 00:58:45 -04:00
xenohedron
50acfad59c remove unnecessary method that missed source param 2025-06-08 00:57:07 -04:00
Grath
341f73ff7e Fix Zenos yae Galvus and Shinryu, Transcendent Rival triggers. 2025-06-08 00:54:31 -04:00
xenohedron
4e929dfbbd remove unused class 2025-06-08 00:48:53 -04:00
padfoothelix
4bc30b4b8e
[WHO] Implement The Curse of Fenric (#13718)
---------

Co-authored-by: xenohedron <12538125+xenohedron@users.noreply.github.com>
2025-06-07 23:10:34 -04:00
padfoothelix
f94e570f6d
[WHO] Implement Everybody Lives! (#13369)
also adjust Courageous Resolve

---------

Co-authored-by: xenohedron <12538125+xenohedron@users.noreply.github.com>
2025-06-07 23:10:20 -04:00
Evan Kranzler
0e179ccc1f
Refactor SourceHasCounterCondition to be an IntCompareCondition (#13724)
* refactor SourceHasCounterCondition to be an IntCompareCondition

* add comment for arguments
2025-06-07 21:03:21 -04:00
Evan Kranzler
c7f2263ddb
Update rules for Sagas (#13728)
* update saga rules

* update test

* update test
2025-06-07 21:02:26 -04:00
Susucre
8495d6a74e fix and test [FIN] Zack Fair 2025-06-07 20:09:47 +02:00
theelk801
baa52bc617 more refactoring of ConditionalInterveningIfTriggeredAbility 2025-06-07 12:28:14 -04:00