Commit graph

4122 commits

Author SHA1 Message Date
theelk801
6208adde58 Merge branch 'master' into refactor/multiple-names 2025-06-04 15:49:52 -04:00
theelk801
5fcd99ba44 fix test failures 2025-06-04 11:23:10 -04:00
Susucre
10695d555e fixes Phelia, Exuberant Shepherd return trigger
fixes #13722
2025-06-03 20:50:07 +02:00
xenohedron
e1d082d776 fix and test Combo Attack 2025-06-02 23:26:38 -04:00
theelk801
2ab7381b05 fix test failure 2025-06-02 17:33:30 -04:00
Evan Kranzler
5f59e45302
Merge branch 'master' into refactor/multiple-names 2025-06-02 17:15:42 -04:00
theelk801
c7006017ca [FIC] Implement Lifestream's Blessing 2025-06-02 09:56:43 -04:00
theelk801
b82d45c19e fix test failure 2025-06-01 21:41:49 -04:00
Susucre
1d7ef1ed03 add test for Betor, Ancestor's Voice
Attempting to replicate #13716 bug without result.
Assuming there was a counter replacement effect in place missing in the bug report.
2025-06-01 23:06:15 +02:00
Susucre
a445142d39 fix and test Font of Agonies
fixes #13717
2025-06-01 22:52:31 +02:00
Steven Knipe
20db2f0602 add SigardasSplendorTest, other test improvements 2025-06-01 13:27:33 -07:00
Susucre
cfd51d7dce
refactor: add FilterSource to match TargetSource (#13703)
Small fix of enabling TargetSource to choose/target a Command Object
2025-06-01 15:52:51 +02:00
Oleg Agafonov
8d7bd60061 Player under control - fixed that it doesn't hide opponent's hand after control lost (part of #13353); 2025-06-01 10:21:47 +04:00
Oleg Agafonov
71b0613355 tests: added verify check for wrong target tags usage, improved work with tagged targets (related to 8b2a81cb42) 2025-06-01 08:54:24 +04:00
ssk97
3223d99b2a
refactor: remove notTarget targets from abilities (#13651)
Adds OneShotNonTargetEffect and PutCountersTargetCost
Fixes the target timing of spells/abilities, as non-targets should be chosen on resolution.
2025-05-31 20:36:15 -07:00
Steven Knipe
8b29853e4c Fix Vault 13 test and card once zcc fix is merged 2025-05-31 19:29:21 -07:00
Evan Kranzler
a7dcd6988f
[FIC] Implement Locke, Treasure Hunter (#13695) 2025-05-31 13:42:39 -04:00
Susucre
2034b3fe59 cleanup CantBeCounteredControlledEffect 2025-05-31 17:43:25 +02:00
Susucre
6618f1d163 fix newly added test 2025-05-31 14:52:39 +02:00
Susucre
5c25beebbf add another test batch for Saga zcc-related 2025-05-31 14:50:34 +02:00
Susucre
7cdf068dc5 add more tests for zcc-related Sagas 2025-05-31 14:12:13 +02:00
Oleg Agafonov
f2826cc676
GUI, table: added drafts with single multiplayer and multiple 1vs1 games support (#13701)
- new tourney's single game mode allow to play tourneys/drafts with all players in one game without multiple rounds;
- it's allow to setup classic drafts with 1 vs 1 games and multiple rounds
- added AI opponents supported including draft bots from a public servers;
2025-05-31 10:39:23 +04:00
Evan Kranzler
9e2a1a59e0
[FIC] Implement G'raha Tia, Scion Reborn, rework DoIfCostPaid and "do only once" effects (#13660)
* rework effects with DoIfCostPaid and "do this only once each turn"

* [FIC] Implement G'raha Tia, Scion Reborn

* [FIC] Implement Emet Selch of the Third Seat

* rework Emet-Selch

* add test

* add static methods to handle whether ability was used this turn
2025-05-30 21:28:11 -04:00
Susucre
2bbc2cba00 add TODO to new @Ignore 2025-05-31 03:02:02 +02:00
Susucre
8336bedf83 add even more saga tests
enable the two ignored after #11619
2025-05-31 00:10:09 +02:00
Susucre
9852f1b3d4 add more saga tests
enable the two ignored after #11619
2025-05-30 23:01:12 +02:00
Susucre
0fd2a9303f test The Phasing of Zhalfir ; small tweak to TestPlayer to not count phased out permanents 2025-05-30 22:08:46 +02:00
Susucre
8262a43a71 add tests for Urza's Saga and The Triumph of Anax 2025-05-30 21:58:59 +02:00
Susucre
d57b99d6e4 implement [MIR] Shadowbane 2025-05-30 20:31:36 +02:00
Susucre
b13efab236 refactor one-use prevention effect for a chosen source
fixes a few bugs along the way:

[[Pilgrim and Justice]] & [[Pilgrim of Virue]] were incorrectly adding a "to you" to their damage clause.
[[Ajani's Aid]] was improperly a one-use prevention effect.

[[Story Circle]] and [[Prismatic Circle]] have not been refactor as it is not currently possible to have a proper filter for them. Would require a FilterSource with a 4-argument match most likely.
2025-05-30 19:23:41 +02:00
Susucre
ba395c8385
implement [FIC] Edgar, Master Machinist (#13676) 2025-05-30 15:11:43 +02:00
Susucre
0ac37617d1
implement [FIN] Sorceress's Schemes (#13694) ; small refactor of TargerCard 2025-05-30 14:51:31 +02:00
xenohedron
341479c36b fix and test Stern Judge 2025-05-29 01:24:43 -04:00
Evan Kranzler
abb88e9527
[FIN] Implement Gogo, Master of Mimicry (#13686)
* [FIN] Implement Gogo, Master of Mimicry

* add test

* fix text

* move abstract method definition to interface where it belongs
2025-05-27 22:01:53 -04:00
Evan Kranzler
136988de29
[FIN] Implement Edgar, King of Figaro, rework coin flips (#13672)
* add method for multiple coin flips

* [FIN] Implement Edgar, King of Figaro

* add extra note

* update coin flip logic

* add test
2025-05-27 21:56:23 -04:00
Evan Kranzler
e1f4e9db59
[FIN] Implement Ancient Adamantoise (#13670)
* [FIN] Implement Ancient Adamantoise

* change effect type

* add test
2025-05-27 21:56:07 -04:00
theelk801
85d85a4b17 [FIN] Implement Memories Returning 2025-05-27 16:58:24 -04:00
Susucre
43c45238d0
refactor and test 'greatest [quality] among [permanent filter]' (#13666) 2025-05-25 18:58:53 +02:00
Susucre
0b6a2b2546 refactor and test 'Scry X' effects
Fixes #13667
2025-05-25 17:53:06 +02:00
Susucre
a4f22f21cf fix split cards interaction with Feather, the Redeemed and the like
Fixes #12353
Fixes #13665
2025-05-25 16:06:44 +02:00
Oleg Agafonov
e320bf241c GUI, game: added source info in "choose number/amount" dialogs, added auto-choose for single possible value (part of #13638); 2025-05-17 21:18:45 +04:00
theelk801
748c428202 fix test failures 2025-05-16 15:01:30 -04:00
Susucre
a9af84f533
implement [FIN] Vivi Ornitier ; limit mana computation for "only once per turn" abilities (#13639)
fixes #10930
2025-05-16 19:45:01 +02:00
Oleg Agafonov
66db821437 refactor: combined announceX methods in one, improved X message and selection for AI (part of #10330) 2025-05-16 19:34:57 +04:00
Oleg Agafonov
133e4fe425
other: reworked target selection: (#13638)
- WIP: AI and multi targets, human and X=0 use cases, human and impossible targets use cases;
- improved stability and shared logic (related to #13606, #11134, #11666, continue from a53eb66b58, close #13617, close #13613);
- improved test logs and debug info to show more target info on errors;
- improved test framework to support multiple addTarget calls;
- improved test framework to find bad commands order for targets (related to #11666);
- fixed game freezes on auto-choice usages with disconnected or under control players (related to #11285);
- gui, game: fixed that player doesn't mark avatar as selected/green in "up to" targeting;
- gui, game: fixed small font in some popup messages on big screens (related to #969);
- gui, game: added min targets info for target selection dialog;
- for devs: added new cheat option to call and test any game dialog (define own dialogs, targets, etc in HumanDialogsTester);
- for devs: now tests require complete an any or up to target selection by addTarget + TestPlayer.TARGET_SKIP or setChoice + TestPlayer.CHOICE_SKIP (if not all max/possible targets used);
- for devs: added detail targets info for activate/trigger/cast, can be useful to debug unit tests, auto-choose or AI (see DebugUtil.GAME_SHOW_CHOOSE_TARGET_LOGS)
2025-05-16 13:55:54 +04:00
theelk801
1a62ea36bb [FIN] Implement Zanarkand, Ancient Metropolis 2025-05-11 11:45:42 -04:00
Susucre
826830b905 Implement [FIC] Hildibrand Manderville 2025-05-09 18:40:10 +02:00
Evan Kranzler
5a7d6805e0
[WHO] Implement Barbara Wright (#13602)
* [WHO] Implement Barbara Wright

* add test

* add more tests

* update reminder text
2025-05-08 12:38:10 -04:00
Susucre
f90350c0c5 Implement [40K] Lucius the Eternal 2025-05-07 22:31:10 +02:00
Oleg Agafonov
a53eb66b58 other: reworked target selection (now it use same logic and methods in all places), fixed AI and selection freezes in some use cases (related to #13606, #11285) 2025-05-07 17:34:36 +04:00