Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions
foul-magics/Mage/src/main/java/mage/cards
History
Alex Vasile a2162ec3e7
Refactor: private fields and performance tweaks (#9625) 
1a. Make `costs`, `manaCosts`, and `manaCostsToPay` private in `AbilityImpl` with access through getters/setters 
1b. fix cost adjuster for imprinted cards affected by the above

2a. Lazy instantiation for rarely used `data` field in `TargetPointerImpl`

3a. Pre-allocate certain array sizes in `Modes` and `CostsImpl`

4a. Make `manaTemplate` private in `BasicManaEffect`, copy when passing outside the class 
4b. Don't copy `manaTemplate` in copy constructor since it doesn't change 
4c. Add comments explaining copy usage for `manaTemplate` 
4d. Remove redundant variable assignment and make fields final 

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
2023-08-27 17:58:19 -04:00
..
basiclands Code cleanup: protect all copy constructors (#10750) 2023-08-04 19:34:58 -04:00
decks Basic groundwork for extra decks (contraptions, attractions) (#10378) 2023-08-06 21:06:32 -04:00
mock Basic groundwork for extra decks (contraptions, attractions) (#10378) 2023-08-06 21:06:32 -04:00
repository Basic groundwork for extra decks (contraptions, attractions) (#10378) 2023-08-06 21:06:32 -04:00
AdventureCard.java Reworking effects which allow casting spells from a selection of cards (ready for review) (#8136) 2022-03-09 08:03:54 -05:00
AdventureCardSpell.java Reworking effects which allow casting spells from a selection of cards (ready for review) (#8136) 2022-03-09 08:03:54 -05:00
AdventureCardSpellImpl.java Refactor: private fields and performance tweaks (#9625) 2023-08-27 17:58:19 -04:00
ArtRect.java
Card.java Refactor: private fields and performance tweaks (#9625) 2023-08-27 17:58:19 -04:00
CardGraphicInfo.java
CardImpl.java Basic groundwork for extra decks (contraptions, attractions) (#10378) 2023-08-06 21:06:32 -04:00
Cards.java Add documentation to Cards and CardsImpl (#9019) 2023-07-02 18:20:28 -04:00
CardSetInfo.java Change supertype method in constructors (#10361) 2023-05-12 20:45:07 -04:00
CardsImpl.java Code cleanup: protect all copy constructors (#10750) 2023-08-04 19:34:58 -04:00
CardWithHalves.java Reworking effects which allow casting spells from a selection of cards (ready for review) (#8136) 2022-03-09 08:03:54 -05:00
ExpansionSet.java Fix wrong extra cards in 10E boosters 2023-06-11 23:10:47 -04:00
FrameStyle.java Add in decreasing rectangle spiral for paper original dual lands 2021-08-12 00:21:41 +10:00
LevelerCard.java moved addAbilities method into the only class that uses it to make my IDE's autocomplete less annoying 2022-04-25 09:09:29 -04:00
MeldCard.java Code cleanup: protect all copy constructors (#10750) 2023-08-04 19:34:58 -04:00
ModalDoubleFacedCard.java rename classes (#10383) 2023-05-17 18:49:30 -04:00
ModalDoubleFacedCardHalf.java rename classes (#10383) 2023-05-17 18:49:30 -04:00
ModalDoubleFacedCardHalfImpl.java Code cleanup: protect all copy constructors (#10750) 2023-08-04 19:34:58 -04:00
Sets.java Tokens and command objects reworked (part 1 of 2): 2023-05-08 02:15:07 +04:00
SplitCard.java GUI: fixed that some split cards show a fuse rule (#10217) 2023-04-15 14:32:36 +04:00
SplitCardHalf.java Reworking effects which allow casting spells from a selection of cards (ready for review) (#8136) 2022-03-09 08:03:54 -05:00
SplitCardHalfImpl.java Code cleanup: protect all copy constructors (#10750) 2023-08-04 19:34:58 -04:00
SubCard.java Reworking effects which allow casting spells from a selection of cards (ready for review) (#8136) 2022-03-09 08:03:54 -05:00