master #26

Merged

Failure merged 336 commits from External/mage:master into master 2025-05-19 22:03:54 -07:00

Conversation 0 Commits 336 Files changed 788 +29865 -3717

Failure commented 2025-05-19 22:03:15 -07:00

Owner

Copy link

No description provided.

Failure added 336 commits 2025-05-19 22:03:32 -07:00

Fix Kolodin, Triumph Caster missing targets cbf0944a0c

[DSC] Implement Star Athlete 30aba52687

[DSK] Implement Trial of Agony f16f9ac797

[DSK] remove unnecessary commented out lines from set file 3a81c7848c

[DSK] Implement Keys to the House 5e8c63ad2c

[DSK] Implement Marina Vendrell ec639d1172

[DSK] update full art basic art setting ac34d97987

[ACR] Implement Havi, the All-Father 46aa2a043d

[WHO] Implement Strax, Sontaran Nurse 11f47dbf16

[WHO] Implement Ryan Sinclair 5aca79ffb1

[WHO] Implement Blink 3267723986

[WHO] Implement Nyssa of Traken b35185872d

[WHO] Implement Sycorax Commander dfd3e5e10d

[WHO] Implement The Master, Mesmerist 876a07caf7

fix text: Excavation b4e7e872ab

Fix Sigurd, Jarl of Ravensthorpe last ability trigger ... b2d8c12ca3

* Didn't trigger on entering sagas
* Was checking for P1P1 counters

Fix Eye of Singularity ... 6992facc4b

* Fixed target was using dynamic zcc for permanents instead of the permanent itself

[TDM] fix Stadium Headliner ... 52330046f8

* fix rules text
* fix damage source value

[BLC] Implement Sword of the Squeak 4bbd5db74b

[PIP] Implement Three Dog, Galaxy News DJ 2d74f18a40

[PIP] Implement Preston Garvey, Minuteman 5dcbd6d318

[CLU] Implement Frenzied Gorespawn 9d0e6c3e11

[CLU] Implement Herald of Ilharg 827ef33729

[TDM] fix Molten Exhale ... e993d4c296

* fix behold ability having no effects
* fixes #13564

Spell Abilities respect ruleAtTop boolean b0b508fd27

Fix bestow tokens trying to attach ... aeded36c09

* Bestowed token copies set attached to a permanent now get created as just creatures
* Fixes #13559

GUI, game: fixed that attacking creature draws a wrong colored arrow after blocked creature removed (must be gray, close #11894) db9bdc05c2

Can block any number of creatures - fixed that it can be broken with some of "can block an additional creature" effects 49c28458ec

[M3C] Implement Exterminator Magmarch caa4e432ea

[TDM] various text fixes 0b5144d0d2

fix test failure 3281f214ab

[TDC] various text fixes 0013e075be

[FDN] various text fixes 33012783a6

refactor all cards with affinity errata 0d10708635

fix test failure 272292317a

Fix problem with trying to distribute negative combat damage 7a3a86017c

Update RetroCardRenderer ... e9b6712915

* adjusted values for better scaling
* fix artifact background overriding card color

[AER] update revolt wording and simplify implementations 6bfeea47c9

miscellaneous text fixes 951f804110

Fix Jaya, Fiery Negotiator Emblem ... bcfc84f360

* Trigger checking wrong zone

[M3C] Implement Rampant Frogantua 8f472a13b8

[M3C] Implement Overclocked Electromancer 8115de2bac

[M3C] Implement Tempt with Mayhem 195717576b

fix verify failure ee4e0de63f

Fix Rhet-Tomb Mystic color typo. ... 99850c7442

Fixes #13582

Fix retro card P/T text ... 5e07c2d603

* damage text formats properly
* boosted/reduced p/t changes colors appropriately

Tombstone Stairwell - fixed that it doesn't destroy tokens on leaves the battlefield 4941a0dd8f

tests: added test and todo for Devoted Druid bug (related to #13583) d0fd0c4023

[DSC] Implement Barbflare Gremlin 51b24a7b8a

[DSC] Implement Demonic Covenant 563e7fb712

[DSC] Implement Soaring Lightbringer 8181b50c8b

[DSC] Implement Ancient Cellarspawn efc95e1636

[DSC] Implement Into the Pit 253f6c10e4

[DSC] Implement Sadistic Shell Game 1943249628

[PIP] Implement Vault 11: Voter's Dilemma 6a710cf77f

[PIP] Implement Vault 13: Dweller's Journey dbd02a1db5

fix verify failure c3a5040a1e

[ACR] Implement Altair Ibn-La'Ahad 0dd2451ac0

[ACR] Implement Jacob Frye 6ccd9dc330

[ACR] Implement Fall of the First Civilization 61a7707ba0

[ACR] Implement Shay Cormac 16d605e51c

[ACR] Implement Monastery Raid 94499dd5f4

[MKC] Implement Mob Verdict bdee9a4604

[WHO] Implement Trial of a Time Lord 176137d95c

[WHO] Implement The Day of the Doctor 06cffc7dd0

[WHO] Implement The Caves of Androzani 5b4cc9d569

[WHO] Implemented Hunted by The Family 42b2c91809

[TDC] fix Arbor Adherent counting its own toughness 0fdd167ba2

[WHO] Implement The War Games 3138dc4b1e

[WHO] Implement Vislor Turlough 67baf777ce

[WHO] Implement Midnight Crusader Shuttle d17e5f11ad

fix Bull-Rush Bruiser effect duration 0d60fd3ab4

fix Frodo, Determined Hero filter de718d9bbb

Implement [40K] The Red Terror bc2ba3e4eb

[FIC] Implement Tifa, Martial Artist 5b687c344e

fix Contractual Safeguard filter 1b9bbb0e5b

[WHO] Implement Idris, Soul of the TARDIS b1839d47be

fix Repentance damage source 531246ad7f

fix and test [C21] Incarnation Technique ... 7cbd396e39

Incarnation Technique was not processing trigger properly inbetween the mill and return.

part of #13601

Implement [DSK] Valgavoth, Terror Eater (#13593) 507991b9e2

[WHO] Implement Day of the Moon 550562b1a9

[WHO] Implement The Master, Gallifrey's End e4b61b1499

fix verify failure 61d95a1785

Rework cards which exile cards and add suspend to them (Ready for review) (#13600) ... 264eb58644

* rework effects which exile cards and give suspend

* fix test failure

* remove extra zone change

* [WHO] Implement The Wedding of River Song

* [WHO] Implement The Eleventh Doctor

* [WHO] Implement The Parting of the Ways

refactor: removed useless getNumberOfTargets from Target (replaced with getMinNumberOfTargets) 00dc6f4742

AI: improved performance and server stability in games with "choose name" effects (related to #11285) 99ca1e6029

server: fixed game freeze on leaving player before finish target selection (example: Nethergoyf, close #13567, related to #11285) 62aa310a4f

other: reworked target selection (now it use same logic and methods in all places), fixed AI and selection freezes in some use cases (related to #13606, #11285) a53eb66b58

Implement [40K] Lucius the Eternal f90350c0c5

[FIN] Implement Zenos yae Galvus / Shinryu, Transcendent Rival ada8211b4b

[40K] add all variants daf390d632

[WHO] Implement Barbara Wright (#13602) ... 5a7d6805e0

* [WHO] Implement Barbara Wright

* add test

* add more tests

* update reminder text

[WHO] Implement The Face of Boe 7b6eb50a54

[WHO] Implement The Seventh Doctor dd82d4933a

[WHO] Implement The Toymaker's Trap 94c1213925

update read ahead reminder text 5eb188185c

[WHO] Implement The Master, Formed Anew e47a881f05

[WHO] Implement Genesis of the Daleks (closes #11442) 1eecde5003

Implement [FIC] Hildibrand Manderville 826830b905

[FIN] Implement Emet-Selch, Unsundered / Hades, Sorcerer of Eld (#13439) 145c88ac90

[FIN] Implement spoilers (#13616) ... 52bb919cd4

* [FIN] Implement Commune with Beavers

* [FIN] Implement Adventurer's Inn

* [FIN] Implement Job Select keyword ability

* [FIN] Implement White Mage's Staff

* [FIN] Implement Black Mage's Rod

* [FIN] Implement Ultimecia, Time Sorceress / Ultimecia, Omnipotent

[FIN] Implement Shantotto, Tactician Magician bad7aa5798

fix verify failure 54d7401bd6

[FIN] Implement Cid, Timeless Artificer 6533e2b03c

[FIN] Implement A Realm Reborn 06cb7221c6

fix Overwhelming Surge filter (#13614) f07cc4a7f2

update gen-card.pl to support adding multiple versions of a card to a set a9f9407fc2

[FIN] update spoiler and reprints 8d8d666688

[FIC] update spoiler and reprints 45343fab81

[FIN] Implement Tifa Lockhart f626e101a8

[FIN] Implement Summon: Primal Odin 5f920163ae

[FIN] Implement Summon: Bahamut 74685887c3

[FIN] Implement Dragoon's Wyvern 2372b9b439

[FIN] Implement Malboro 05f641342e

fix verify failure 8e9f4f1417

[FIN] update spoiler 03725340b1

[FIN] Implement Starting Town bdb52e9b41

[FIN] Implement Town Greeter 00408e72a9

[FIN] Implement Cloud, Midgar Mercenary 1054423bf2

[FIN] Implement The Crystal's Chosen fab125ac97

[FIN] Implement Zanarkand, Ancient Metropolis 1a62ea36bb

[FIN] Implement Jidoor, Aristocratic Capital 4ac05f4b90

[FIN] Implement Vanille, Cheerful l'Cie / Fang, Fearless l'Cie / Ragnarok, Divine Deliverance 9cff375406

[FIN] Implement Fire Magic 6e124806db

[FIN] Implement Ice Magic 4cf14ee966

[FIN] Implement Clive, Ifrit's Dominant / Ifrit, Warden of Inferno 2267a11929

[FIN] Implement Squall, SeeD Mercenary 46dc599728

[FIN] Implement Aerith Gainsborough a6281e6d03

[FIN] Implement Firion, Wild Rose Warrior 4e7495a8f2

[FIN] Implement Absolute Virtue 791c67aae2

[FIN] Implement Terra, Magical Adept / Esper Terra 9eb6060df6

[FIC] Implement Sephiroth, Fallen Hero 0b49627fde

fix verify failure c4877e3d22

fix verify failure b1c22fa8cd

fix verify failure for real this time 0490a62794

rework skip 28c1480d33

[FIN] Implement Summon: Leviathan 5578b3847a

[FIN] Implement Traveling Chocobo a863837e20

[FIN] Implement Rinoa Heartilly 47720cf8be

[FIN] Implement Ardyn, the Usurper ec9a89d39a

[FIN] Implement Jill, Shiva's Dominant 21d5b668b9

[FIN] Implement Dragoon's Lance 6ccf49d4f8

[FIN] Implement Bartz and Boko e9cd1ac4a5

[FIN] Implement Summoner's Grimoire 47bd2c9646

fix verify failure f517f7cb5a

[FIN] update spoiler 77e52b6670

[FIN] Implement Valkyrie Aerial Unit 6cee555ba3

[FIN] Implement Ishgard, the Holy See 2485662bf5

[FIN] Implement Matoya, Archon Elder 242dee70f7

[WHO] various text fixes a52f1fd579

[FIN] update spoiler 0d0bcdf227

[FIN] Implement Laughing Mad a6e1d95464

[FIN] Implement White Auracite 96d4a3a927

[FIN] Implement Barret Wallace a2a8fe7307

[FIN] Implement Phoenix Down dd0a6985c3

[FIC] update spoiler and reprints 7441a7b0bb

[FIC] Implement Alphinaut Leveilleur 6f1e410b7a

[FIC] Implement Alisaie Leveilleur da57bcc08b

[FIC] Implement Chocobo Knights 779faee527

[FIC] Implement Elena, Turk Recruit 95f5355a10

[FIC] update spoiler and reprints 90a1ed3a7d

[FIC] Implement Bugenhagen, Wise Elder 616862dc56

[FIC] Implement Protection Magic 25a94f0159

[FIC] Implement Sabin, Master Monk 3d6afc02a6

[FIC] Implement Setzer, Wandering Gambler b26f224ee0

[FIC] Implement Summon: Good King Mog XII 16373fda33

[FIC] Implement Summoning Materia 168d423998

[FIC] Implement Summon: Ixion 83c0c8e782

[FIC] Implement Umaro, Raging Yeti af40403508

[FIC] Implement Red XIII, Proud Warrior a23a5481d5

fix test failure 89b720d4b1

[FIC] Implement Aerith, Last Ancient 3aebb53c74

[FIC] Implement Auron, Venerated Guardian 3cfecf27a0

[FIC] Implement Cid, Freeflier Pilot 22dea87d8f

[FIC] Implement Cyan, Vengeful Samurai 03aed4b610

[FIC] Implement Hermes, Overseer of Elpis 0100ba31f2

[FIC] Implement Krile Baldesion 3d7c610431

[FIC] Implement Lord Jyscal Guado 36ecbd8cf6

[FIC] Implement Summon: Kujata 0624a508a9

fix test failure 20572b9397

[FIC] update spoiler d5e8b43d9e

[FIC] Implement Ardbert, Warrior of Darkness 6c3783d40c

[FIC] Implement Barret, Avalanche Leader e6f0084b3b

[FIC] Implement Cait Sith, Fortune Teller 23a936f1e1

[FIC] Implement Cloud's Limit Break 97a98cd9db

[FIC] Implement Espers to Magicite f5bf294a10

[FIC] Implement SOLDIER Military Program c6b5889201

[FIC] Implement Champions from Beyond 7552d30675

[FIC] update spoiler and reprints e6f6e075ec

[FIC] Implement Lulu, Stern Guardian 235c114934

[FIC] Implement O'aka, Traveling Merchant f17de03fe2

[FIC] Implement Tataru Taru c682a08299

[FIC] Implement Summon: Magus Sisters 6de0ecae2b

[FIC] Implement Summon: Yojimbo ab9f8b8489

[FIC] Implement Thancred Waters d4c419094c

[FIC] Implement The Falcon, Airship Restored aa590b7cf8

[FIC] Implement Warring Triad 7bf4b5ff0b

[FIC] Implement Yuna's Decision 0f62f2451b

fix verify failures 373bb8e621

[FIC] Implement Avalanche of Sector 7 8e2e80927f

[FIC] Implement Eye of Nidhogg 3a9720bd7c

[FIC] Implement General Leo Cristophe 175c73f750

[FIC] Implement Heidegger, Shinra Executive b31d939db7

[FIC] Implement Helitrooper 4a9d369652

[FIC] Implement Gogo, Mysterious Mime 9d3f54b49f

[FIC] Implement Interceptor, Shadow's Hound 85f7aa0a95

[FIC] Implement Ultimate Magic: Holy dd945eaee6

[FIC] Implement Tromell, Seymour's Butler c12c363843

[FIC] Implement Sphere Grid 0a0d6db742

[FIC] Implement Shelinda, Yevon Acolyte b340f790c7

[FIC] Implement Observed Stasis 0d7e78bc54

[FIN] update spoiler 82a6f30f25

[FIN] Implement Ultima Weapon d669b77d65

fix verify failure 89b3b44fc2

fix verify failure fix failing to fix failure with verify 97f972e27e

[FIN] Implement Seymour Flux 3aef79a1c1

[FIN] Implement Lightning, Security Guard 4d7b673da7

[FIN] Implement Magitek Scythe e627c7cd89

[FIN] Implement Namazu Trader ef7a460ed1

[FIN] Implement Beatrix, Loyal Guardian b4ed7ee350

[FIN] Implement Ultimecia, Temporal Threat 41e895cfda

[FIN] Implement Xande, Dark Mage b5fe0610d9

[FIN] Implement Circle of Power 05ded6d1eb

[FIN] Implement Vincent Valentine / Galian Beast 13e633f1ca

[FIN] Implement Cecil, Dark Knight / Cecil, Redeemed Paladin (#13445) 9520a556c8

[FIN] Implement Judgment Bolt 290405652e

[FIN] Implement Deadly Embrace 029232d274

[FIN] Implement Sephiroth, Fabled SOLDIER / Sephiroth, One-Winged Angel 6cc717470a

[FIN] update spoiler e790e3aa4d

[FIN] Implement Rabanastre, Royal City 85e0d193ed

[FIN] Implement Samurai's Katana 0146f91a0b

[FIN] Implement Warrior's Sword 906a55641e

[FIN] Implement Item Shopkeep db722fe470

[FIN] Implement Undercity Dire Rat 56801634ce

[FIN] Implement Sephiroth's Intervention f9eb5ee050

[FIN] Implement Shambling Ci'eth f8054aa366

[FIN] Implement Evil Reawakened 0dc9a0d5c1

[FIN] Implement Al Bhed Salvagers 500057c322

[FIN] Implement Dreams of Laguna 4c401a369b

[FIN] Implement Fate of the Sun-Cryst a3f42e9009

[FIN] Implement Coeurl 8d212efca9

[FIN] Implement Cloudbound Moogle 1033a4b938

[FIC] add missing card 7f8817a00a

fix error e3e7f65b3c

small change ca39195433

fix new error 370e1dbeec

[FIN] Implement Choco, Seeker of Paradise 9621f730e9

[FIN] Implement Moogles' Valor ac0f23410a

GainAbilityControlledEffect now requires a filter to prevent mistakes in implementation af527810ac

[FIN] Implement Sage's Nouliths 2359b560ae

[FIN] Implement Rosa, Resolute White Mage 1fd90e0313

[FIN] Implement Shinra Reinforcements 83886b8f65

[FIN] Implement Retrieve the Esper 181a3306a6

[FIN] Implement Sahagin 34c4eebd44

[FIN] Implement The Prima Vista 58b795a6f9

[FIN] update spoiler 82bdbf2445

[FIN] Implement Kuja, Genome Sorcerer / Trance Kuja, Fate Defied and Y'shtola Rhul (#13623) ... 75f785f313

* [FIN] Implement Kuja, Genome Sorcerer / Trance Kuja, Fate Defied

* [FIN] Implement Y'shtola Rhul

* removed new effect class and condition, added hint

fix extra log message for CounterUnlessPaysEffect 3ab158fd16

fix related to af527810 2022f940fb

text fix 09d3ec060a

fix #13615 (Vampiric Embrace) ... 87ab0a3fcc

revise setTargetPointer logic of DealtDamageAttachedAndDiedTriggeredAbility

fix #13450 (Push/Pull) f60323e0fc

[FIN] update spoiler f55a6005a6

[FIN] Implement Jecht, Reluctant Guardian / Braska's Final Aeon 7844173600

[FIN] Implement Summon: Esper Ramuh 312e0193fd

[FIN] Implement Gilgamesh, Master-at-Arms 7a7e2b4e8f

[FIC] Implement Gau, Feral Youth (#13632) d6d5d7f2b3

[FIC] Implement Hraesvelgr of the First Brood (#13634) 6e0501e9b7

[FIC] Implement Yuna's Whistle 7b2a5dbd08

[FIC] Implement Yuffie, Materia Hunter a669e3e49f

[FIC] Implement Blue Mage's Cane (#13629) 0e5a366ae6

[FIC] Implement Wrecking Ball Arm c0a1b64266

[FIC] Implement Transpose 65676ff76c

[FIC] Implement Siegfried, Famed Swordsman 679d82873b

[FIN] update spoiler 602d26543b

[FIN] Implement Capital City 5156612704

[FIN] Implement Relm's Sketching 98b1e9a82b

[FIN] Implement Auron's Inspiration dfd570de8a

[FIN] Implement Triple Triad fc7bcdf30c

fix verify failure 4851a07599

remove verify skips 80d62727e1

other: reworked target selection: (#13638) ... 133e4fe425

- WIP: AI and multi targets, human and X=0 use cases, human and impossible targets use cases;
- improved stability and shared logic (related to #13606, #11134, #11666, continue from a53eb66b58, close #13617, close #13613);
- improved test logs and debug info to show more target info on errors;
- improved test framework to support multiple addTarget calls;
- improved test framework to find bad commands order for targets (related to #11666);
- fixed game freezes on auto-choice usages with disconnected or under control players (related to #11285);
- gui, game: fixed that player doesn't mark avatar as selected/green in "up to" targeting;
- gui, game: fixed small font in some popup messages on big screens (related to #969);
- gui, game: added min targets info for target selection dialog;
- for devs: added new cheat option to call and test any game dialog (define own dialogs, targets, etc in HumanDialogsTester);
- for devs: now tests require complete an any or up to target selection by addTarget + TestPlayer.TARGET_SKIP or setChoice + TestPlayer.CHOICE_SKIP (if not all max/possible targets used);
- for devs: added detail targets info for activate/trigger/cast, can be useful to debug unit tests, auto-choose or AI (see DebugUtil.GAME_SHOW_CHOOSE_TARGET_LOGS)

[FIN] update spoiler fd1fb53b9a

[FIN] Implement Suplex f93ff5be68

[FIN] Implement Phantom Train f166dc0044

[FIC] Implement Dancer's Chakrams (#13625) 6af198836b

refactor: combined announceX methods in one, improved X message and selection for AI (part of #10330) 66db821437

other: added announceX testable dialogs in cheat menu (part of #10330) fa20361e2e

implement [FIN] Vivi Ornitier ; limit mana computation for "only once per turn" abilities (#13639) ... a9af84f533

fixes #10930

implement [FIN] Freya Crescent 7b9103ce71

[FIN] update spoiler 2ea3278bdd

[FIN] Implement Instant Ramen 94e579543c

[FIN] fix Ragnarok, Divine Deliverance not being a meld card 2f266f6f07

[FIN] Implement Paladin's Arms b5df714b5c

[FIN] Implement Machinist's Arsenal 16291b52b1

[FIN] Implement Summon: Knights of Round 4f4ac436fe

[FIN] Implement Summon: Primal Garuda bb302c0943

fix error 254daea2e8

fix test failures 748c428202

fix verify failure d9cbd428ee

[FIN] update spoiler 1dd348b18b

[FIN] Implement Summon: Anima 4771452ebb

[FIN] Implement Sazh Katzroy 864b5ad50f

add temporary verify skip 0a6a52a0dc

fix Pit of Offerings targeting a35302983c

[FIN] update spoiler c1dfa892b7

[FIN] Implement Buster Sword c939bb38dc

[FIN] Implement Reno and Rude 5c92028e0b

[FIN] Implement Nibelheim Aflame 47be558108

Merge pull request #13645 from balazskristof/fix-pit-of-offerings-targeting ... 06242496d7

Fix Pit of Offerings targeting

GUI, game: added source info in "choose number/amount" dialogs, added auto-choose for single possible value (part of #13638); e320bf241c

other: added getAmount testable dialogs in cheat menu (part of #13638) 832ff8a4ac

clean tmp verify skip d83a595e9b

[FIN] Implement PuPu UFO 00f989f560

[FIN] Implement Poison the Waters ce835282bb

[FIN] Implement Self Destruct d5dc914dd6

[FIN] Implement Yuna, Hope of Spira 90a483d779

[FIN] Implement Galuf's Final Act 88d7c880f9

fix [DFT] Oildeep Gearhulk ... 5eb4bb0112

fixes #13649

Gavi, Nest Warden - fixed game error on usage 655625d695

[FIN] Implement Quistis Trepe 1c8c61c32d

[FIN] Implement Kain, Traitorous Dragoon 25954d172a

[FIN] Implement Serah Farron / Crystallized Serah a93026b770

[FIN] Implement Ultima, Origin of Oblivion fcdf4093fd

[FIC] Implement Vincent, Vengeful Atoner 199315e48b

[FIC] Implement Kimahri, Valiant Guardian 5ab2a26a66

[FIC] Implement Summoner's Sending 2a6a652269

Add hint to Zedruu the Greathearted 3225fb00d9

fix verify failure 93f4b95f8a

remove temporary skip for missing booster data 95fc3f5ff9

Bane's Invoker add missing Target 5048260aa1

Fix {Q} abilties working while summoning sick 95146840f2

[FIN] Implement The Emperor of Palamecia / The Lord Master of Hell 61b2cfddb5

[FIN] update spoiler 7cc09c4084

[FIN] Implement You're Not Alone c6fca7f0cd

[FIN] Implement Ice Flan 1f45444534

Failure merged commit 9a2382cd2c into master 2025-05-19 22:03:54 -07:00

Failure referenced this pull request from a commit 2025-05-19 22:03:57 -07:00

Merge pull request 'master' (#26) from External/mage:master into master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Failure/foul-magics!26

No description provided.