Ingmar Goudt
96d026e4af
remove explicit null checks, match(..) checks on null itself by instanceof calls
2021-04-28 20:53:50 +02:00
Evan Kranzler
05a7c83a77
if you're having text problems I feel bad for you son, I've got 99 problems and they're all text-related and I've only dealt with a small amount of them
2021-04-18 18:17:38 -04:00
Evan Kranzler
326c17fe4d
[STX] various text fixes
2021-04-17 18:22:43 -04:00
Oleg Agafonov
fbb08ab1a8
Devs: added todo with mana calculation freezes (Cascading Cataracts)
2021-04-02 11:32:35 +04:00
Evan Kranzler
2a42bec1f2
simplified various cards to use isInstantOrSorcery method
2021-03-22 20:01:20 -04:00
Oleg Agafonov
b6cb5cef9c
Refactor: removed default comment headers
2021-02-21 08:15:16 +04:00
Oleg Agafonov
dc0a29007c
Commanders improves:
...
* [KHM] fixed that some effects can't find mdf commanders on battlefield (example: Fierce Guardianship, #7504 );
* Oathbreaker: fixed that some cards that refer to commander can affects signature spells too;
2021-02-05 17:19:30 +04:00
Evan Kranzler
e18e3c79d4
[KHM] Implemented Glittering Frost
2021-01-13 18:02:25 -05:00
Oleg Agafonov
347a3b1e1a
* Jeweled Lotus - fixed that mana can't be used to cast commanders without normal mana ( #7272 );
2020-12-22 23:22:41 +04:00
Oleg Agafonov
4d362d7edc
* Copy spells - improved combo support with other abilities like Kicker or Entwine ( #7192 ):
...
* Now ZCC of copied spells syncs with source card or coping spell (allows to keep ability settings that depends on ZCC);
* Fixed bug that allows to lost kicked status in copied spells after counter the original spell or moves the original card (see #7192 );
* Test framework: improved support of targeting copy or non copy spells on stack;
2020-12-15 20:06:53 +04:00
Oleg Agafonov
35f5a8257b
Refactor: replaced sourceId by source and introduced source param in some methods (part 2);
2020-12-13 02:01:49 +04:00
Oleg Agafonov
db239a1055
Refactor: replaced sourceId by source and introduced source param in some methods;
2020-12-12 20:23:19 +04:00
LevelX2
d51acbf090
* Removed unused imports.
2020-08-22 11:51:34 +02:00
LevelX2
c48331f216
* Doubling Cube - Added support for possible mana calculation (related to #6698 ).
2020-08-18 00:22:53 +02:00
LevelX2
768f1bec4f
* Fixed available mana calculation for Cryptic Trilobite and Titans' Nest. Added some improvements for available mana calculation of conditional mana.
2020-08-16 01:16:52 +02:00
LevelX2
27b5c920f7
* Offering - Fixed handling of hybrid mana in casting costs of offered creatures ( fixes #6961 ).
2020-08-14 10:25:47 +02:00
LevelX2
457557852e
* Benthic Explorer - Fixed mana type calculation.
...
* DynamicManaEffect - Fixed mana type calculation.
Some code clean up.
2020-08-07 17:15:06 +02:00
Oleg Agafonov
83f7ae377a
Refactored restore state code, added additional error check for mana undo param;
2020-08-06 22:17:37 +04:00
Oleg Agafonov
3430013f8d
* Server: fixed that too much permanents or mana sources on battlefield can crush or slow down the server ( #6938 );
2020-08-04 05:36:43 +04:00
LevelX2
cbc1c02cde
* Fixed bug that caused some tests to fail introduced with 67dd45c1c7.
2020-08-03 08:32:26 +02:00
LevelX2
67dd45c1c7
* Added getProducableManaTypes method for mana effects to handle Squandered Resources or Reflecting Pool like abilities.
...
* Fixes to Soldevi Adnate, Skirge Familiar, Mana Web.
2020-08-02 10:51:22 +02:00
LevelX2
06968ad921
* Fixed a problem of available mana generation caused by order of usage of mana sourced with costs (example Coal Golem and then Dromar's Attendant - related to #6698 ).
2020-07-30 23:37:04 +02:00
LevelX2
b5c93cf2da
* Fixed available mana generation of Druids Repository, Workhouse, Iceberg, Krak Clan Ironworks, Rasputin Dreamweaver and Sirk Prospector ( #6698 ).
2020-07-28 01:03:33 +02:00
LevelX2
82a9726a35
* Fixed available mana generation of Virdian Joiner ( #6698 ).
2020-07-27 23:50:07 +02:00
LevelX2
4d43914673
* Morselhoarder - Fixed calculation of available mana and some cleanup to other mana abilities ( #6698 ).
2020-07-24 16:41:36 +02:00
LevelX2
653a2dd7b2
* Available mana calculation - Fixed a problem with repeatable mana converting abilities (e.g. Farrelite Priest) that were only considered once ( #6698 ).
2020-07-24 12:06:14 +02:00
LevelX2
3a82840e66
* Fixed some more available mana calculation problems. Mana of the pool is now taken into account (e.g. Coal Golem problem). Crucible of the Spirit Dragon - Conditional mana curretnly not handled correctly in available mana calculation. Crystalline Crawler works now.Related to #6698 .
2020-07-16 22:37:51 +02:00
LevelX2
7ad7d5f03d
* Fixed available mana generation for Caged Sun and storage lands (e.g. Calciform Pools) related to #6698 .
2020-07-16 12:44:01 +02:00
LevelX2
31163eec6d
* Fixed that mana sources that produce any mana type that other sources produce (e.g. Reflecting Pool) could erroneously produce colorless mana from mana sources that could only produce any color mana ( fixes #6814 ).
2020-07-12 08:50:56 +02:00
Oleg Agafonov
219ab89bcc
Fixed test
2020-07-11 21:03:32 +04:00
LevelX2
81e5650972
* Fixed calcultion of available mana for Goblin Clearcutter, Seton Krosan Protector, Urza, Lord High Artificer, Heritage Druid, Birchlore Ranger and Grand architect.
2020-07-11 16:43:38 +02:00
LevelX2
89249888b5
* Added handling of triggered mana to available mana calculation ( fixes #585 ).
2020-07-11 00:53:47 +02:00
arcox
9c7982e8f6
Update *.sh and *.java files to use Unix line endings
2020-07-09 13:07:26 -04:00
LevelX2
68f4d67600
* Fixed a problem with mana sources that blocked casting spells because their available mana calculation caused return of no available mana (Chrome Mox, Mox Amber #6698 ).
2020-07-03 15:31:16 +02:00
Oleg Agafonov
c2e7b02e13
Reworked and improved special mana payment abilities (convoke, delve, assist, improvise):
...
* now it can be used to calc and find available mana and playable abilities;
* now tests and AI can use that abilities;
* now it follows mtg's rules and restrictions for mana activation order (rule 601.2f, see #768 );
2020-06-19 13:09:45 +04:00
LevelX2
3c43e544b0
* Fixed a bug that for mana abilities with multiple net mana entries wrongly no available mana was calculated ( fixes #6617 ).
2020-06-14 16:29:05 +02:00
Evan Kranzler
5af57d29e8
changed BasicManaAbility to only be used for basic mana abilities
2020-04-24 20:39:08 -04:00
Oleg Agafonov
169d9bf761
* Non basic mana abilities - fixed rollback errors in AI games ( #6300 );
2020-02-25 12:41:45 +04:00
Ingmar Goudt
ae7919cd07
program towards Interface rather than implementations
2020-02-10 10:40:06 +01:00
Oleg Agafonov
5adab75324
Revert "format: organize imports"
2020-02-05 02:17:00 +04:00
Leandro Doctors
8a0a9acff7
format: organize imports
2020-02-04 16:21:48 -03:00
jeffwadsworth
292a0a2912
- Fixed #6157
2020-01-08 16:47:05 -06:00
Evan Kranzler
9e7fcd33cd
fixed some import errors
2020-01-06 20:21:10 -05:00
Evan Kranzler
9c3b923b3f
refactored ControllerPredicate
2020-01-06 20:04:56 -05:00
Evan Kranzler
9a603fbaab
replaced StaticValue with singletons
2020-01-05 11:33:21 -05:00
Oleg Agafonov
dceb93e7a6
Additional fixes for getNetMana from #6132 (final)
2020-01-03 06:27:39 +04:00
Oleg Agafonov
62636b5071
Additional fixes for getNetMana from #6132
2020-01-02 23:33:20 +04:00
Oleg Agafonov
60781604f3
Merge branch 'master' into fix-tapped-for-mana-event
2019-12-31 12:12:25 +01:00
ssouders412
2d3247d732
Updated pronouns to reflect current rules and oracle text
...
Replaced all instances of "her or she", "him or her", and "his or her", with "they", "them", and "their", or sometimes "that player". Updated verbs where appropriate.
2019-12-06 14:29:36 -05:00
Iain Monro
48fbd30f2d
#5935 Fix and standardise firing of TAPPED_FOR_MANA event
2019-08-16 15:26:40 +01:00