Susucre
754b382e78
implement [MH3] Nethergoyf, refactor targets usages by game param ( #12267 )
2024-05-21 13:34:38 +02:00
xenohedron
9b3ff32a33
Rework sacrifice effects to support "can't be sacrificed" ( #11587 )
...
* add TargetSacrifice and canBeSacrificed
* SacrificeTargetCost refactor, now uses TargetSacrifice, constructors simplified, subclasses aligned
* fix text errors introduced by refactor
* refactor SacrificeEffect, SacrificeAllEffect, SacrificeOpponentsEffect
* cleanup keyword abilities involving sacrifice
* fix a bunch of custom effect classes involving sacrifice
* fix test choices
* update Assault Suit implementation
* fix filter check arguments
* add documentation to refactored common classes
* [CLB] Implement Jon Irenicus, Shattered One
* implement "{this} can't be sacrificed"
* add tests for Assault Suit and Jon Irenicus
* refactor out PlayerToRightGainsControlOfSourceEffect
* implement [LTC] Hithlain Rope
* add choose hint to all TargetSacrifice
---------
Co-authored-by: Evan Kranzler <theelk801@gmail.com>
Co-authored-by: PurpleCrowbar <26198472+PurpleCrowbar@users.noreply.github.com>
2023-12-31 14:10:37 -05:00
Susucre
f75b1c9f0a
Code cleanup: protect all copy constructors ( #10750 )
...
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
2023-08-04 19:34:58 -04:00
Oleg Agafonov
ce3cf742c9
Blast-Furnace Hellkite - fixed game error on offering an artifact lands and treasures ( #9940 , #10218 )
2023-06-11 11:05:06 +04:00
Evan Kranzler
4bdd1cb2e3
[BRC] Implemented Blast-Furnace Hellkite
2022-10-29 10:34:40 -04:00
Alex Vasile
55a6acba22
Refactor: Significant speed-up for ManaOptions ( #9233 )
2022-10-04 00:08:20 -04:00
Evan Kranzler
80e11b2052
(WIP) Replacing blocking/blocked by predicates ( #8729 )
...
* replaced blocking/blocked by predicates
* added test for knight of dusk (currently fails)
* added source parameter to filters and everything else that needs it
* some changes to various predicates
* test fix
* small changes to filter code
* merge fix
* fixed a test failure
* small change to Karn, Scion of Urza
* removed sourceId from filter methods and other similar places
* added new getobject method to fix some test failures
* a few more fixes
* fixed merge conflicts
* merge fix
2022-03-23 18:45:02 -04:00
Oleg Agafonov
e02089464f
* Offering ability - fixed rollback error on usage with lands;
2020-12-20 16:12:40 +04:00
Oleg Agafonov
db239a1055
Refactor: replaced sourceId by source and introduced source param in some methods;
2020-12-12 20:23:19 +04:00
LevelX2
d51acbf090
* Removed unused imports.
2020-08-22 11:51:34 +02:00
LevelX2
27b5c920f7
* Offering - Fixed handling of hybrid mana in casting costs of offered creatures ( fixes #6961 ).
2020-08-14 10:25:47 +02:00
LevelX2
3e498e23e6
* Offering ability - Fixed use in available mana calculation (related to #6698 ).
2020-08-12 16:26:22 +02:00
LevelX2
2f77d1d14c
* Fixed that Offering ability did not work from command zone ( fixes #4909 ).
2020-07-06 15:15:02 +02:00
Oleg Agafonov
5adab75324
Revert "format: organize imports"
2020-02-05 02:17:00 +04:00
Leandro Doctors
8a0a9acff7
format: organize imports
2020-02-04 16:21:48 -03:00
Evan Kranzler
86906ec25f
refactored all instances of SubtypePredicate
2020-01-06 16:48:00 -05:00
LevelX2
133cc7342d
* Fixed a problem with check playable methods causing e.g. endless loop if Shared Fate was on the battlefield.
2019-12-25 16:01:02 +01:00
Oleg Agafonov
d0c8d6a707
Fixed NPE errors for some cards ( #5471 )
2019-01-08 07:00:14 +04:00
LevelX2
4c17a13bce
[GRN] Added Thief of Sanity.
2018-09-22 16:43:15 +02:00
igoudt
9f06046f22
add isOwned and isControlled methods. remove some null-checks, remove some unnecessary casts
2018-07-04 14:24:11 +02:00
GrayedFox
3953f3dbdd
remove all MIT copyright notices from files
2018-06-02 17:59:49 +02:00
igoudt
c44c301f5b
subtypes #1
2017-05-20 22:41:25 +02:00
LevelX2
962f05bbcb
* Offering - Fixed that offering could not be activated as instant, cancel during offering mana payment now restores also the sacrificed permanent.
2017-03-12 11:29:53 +01:00
vraskulin
f60ebfbb1f
All 1-character strings converted to primitives
...
"b" + "r" now changed to 'b' + 'w'. It's more straight-forward, and may cause perfomance improvements - character primitives allocation is faster and less expensive than string creation.
2017-02-06 14:32:51 +03:00
Fenhl
430ae503c7
Change all line endings to LF
2016-04-14 16:18:01 +00:00
poixen
46eb6c0525
Restructured Mage module
2015-11-29 21:56:49 +01:00
