Commit graph

1725 commits

Author SHA1 Message Date
Alex W. Jackson
c8c663b976 Distinguish "blocks or becomes blocked" triggered abilities from "blocks or becomes blocked by a creature". Fixes #9347 2022-09-25 02:54:43 -04:00
Alex W. Jackson
0b200748e5 Fix #9560 and replace various custom effects with GainControlAllEffect 2022-09-24 00:39:48 -04:00
Evan Kranzler
b0ebf4ad5b [NCC] various text fixes 2022-09-22 22:29:39 -04:00
Alex Vasile
fd16f2a16b
[NCC] Implement several cards (#9328)
Many associated refactors too. See full PR for detail.
2022-09-22 21:38:29 -04:00
Alex W. Jackson
3996127032
Fix copying fused spells; also fixes #9545 (#9546) 2022-09-22 01:59:21 -04:00
Alex W. Jackson
12a20d07f4 Add choose hints to abilities with sacrifice costs where the target and the permanent to sacrifice might be ambiguous (A-D) 2022-09-20 09:17:14 -04:00
Alex W. Jackson
2b652f6695 De-duplicate Splice code; add choose hints to all targeted Splice cards 2022-09-18 13:03:26 -04:00
Evan Kranzler
7e55f25d31 [40K] Implemented Necron Deathmark 2022-09-18 11:58:16 -04:00
Evan Kranzler
69c15762a5 Fact or Fiction effects reverted to asking for hand pile rather than graveyard pile (closes #9531) 2022-09-18 11:52:29 -04:00
Alex W. Jackson
639277402d Fix #8485 2022-09-17 09:27:49 -04:00
Evan Kranzler
a31644789c [DMU] various text fixes 2022-09-14 18:29:34 -04:00
Alex W. Jackson
efa7b485b0 Remove unneeded parameter from StackObjectCopyApplier.getNextNewTargetType (all users were using an Iterator or a fixed return value) 2022-09-14 03:23:21 -04:00
Alex W. Jackson
7c2f76b46b Remove custom multitarget handling from ReturnToHandTargetEffect (use EachTargetPointer instead) 2022-09-12 08:54:45 -04:00
Alex W. Jackson
dc33531792 Fix #4368 2022-09-12 06:56:07 -04:00
PurpleCrowbar
46cc674a8e
[DMC] Implement Sivitri, Dragon Master (#9506)
* [DMC] Implement Sivitri, Dragon Master
* Generalised CantAttackYouUnlessPayAllEffect
2022-09-11 23:18:25 -04:00
Daniel Bomar
90496c56f4
[DMU] Implemented Tyrannical Pitlord (#9498) 2022-09-10 19:54:46 -04:00
Alex W. Jackson
5bfbeff87d Fix Render Silent and remove some unnecessary custom effects I noticed via the previous commit 2022-09-09 15:41:37 -04:00
Alex Vasile
092f3c3fe1
Simplified effects by removing unnecessary getText instances. (#9374) 2022-09-09 12:02:22 -04:00
Daniel Bomar
48df6902e1
[40K] Fixed Abaddon the Despoiler and enabled test (fixes #9490) 2022-09-08 11:35:42 -05:00
Alex W. Jackson
2f93647196 Fix IllegalArgumentException on Volcano Hellion echo trigger 2022-09-07 23:15:18 -04:00
Alex W. Jackson
e310ede837 Replace many custom effects with ExileUntilSourceLeavesEffect 2022-09-06 06:50:01 -04:00
Daniel Bomar
a5621cf247
[DMU] Implemented Anointed Peacekeeper (#9478) 2022-09-05 21:49:10 -04:00
Alex W. Jackson
b5b4b38cc6 Fix ShuffleIntoLibraryTargetEffect to support multiple target cards with possibly different owners 2022-09-05 19:44:09 -04:00
Evan Kranzler
02968c9cc1
[DMU] Implemented Sphinx of Clear Skies (#9474)
* create common class for effects similar to Fact or Fiction

* [DMU] Implemented Sphinx of Clear Skies

* change text generation to staticText
2022-09-05 16:14:16 -04:00
Alex Vasile
138fa46824 Fixed text generation for LoseLifeOpponentsEffect 2022-09-05 14:26:36 -04:00
Alex W. Jackson
e3b8a813e5 Remove custom multitarget handling from DestroyTargetEffect (use EachTargetPointer instead) 2022-09-04 07:04:46 -04:00
Alex W. Jackson
addfd5166e Add new methods to Target and TargetPointer to help generate card rules text. Currently only used by ExileUntilSourceLeavesEffect 2022-09-04 05:15:12 -04:00
Alex W. Jackson
c6e1ce6697 Remove custom multitarget handling from ExileTargetEffect (use EachTargetPointer instead) 2022-09-03 22:59:19 -04:00
Alex Vasile
07a142c9e8
Refactor: Add proper support for modifying and querying base P/T (#9409) 2022-09-01 19:57:30 -04:00
Evan Kranzler
06d7b508dc [DMU] Implemented Academy Loremaster 2022-08-29 20:09:16 -04:00
Evan Kranzler
2e94364b2a [DMU] Implemented Urborg Lhurgoyf 2022-08-29 20:02:30 -04:00
Alex Vasile
0a96201b6a Simplified Mirri and Crawlspace by making their identical effects a common effect that is shared between them 2022-08-22 21:39:28 -04:00
Daniel Bomar
7f439e23ab
[DMU] Implemented Tori D'Avenant, Fury Rider 2022-08-22 18:24:07 -05:00
Daniel Bomar
aea8c82728
[DMU] Implemented Phoenix Chick (#9397)
* [DMU] Implemented Phoenix Chick

* ReturnSourceFromGraveyardToBattlefieldWithCounterEffect - Fix constructor

* Revert back to using setText() to set staticText

* Make setText() return a String
2022-08-22 10:36:48 -05:00
Alex Vasile
3c0951c350 Enabled assertAllCommandsUsed by default and fixed remaining tests 2022-08-20 07:36:32 -04:00
Evan Kranzler
5e656b8da5
[DMU] Implemented Impede Momentum (#9383) 2022-08-18 20:38:54 -04:00
Alex Vasile
ebdb6b53a4
Replace Overriden getTriggerPhrase() with setTriggerPhrase() usage (#9343) 2022-08-08 23:28:46 -04:00
Alex W. Jackson
7233061ae3
Remove lockedIn parameter from BoostTargetEffect. Fixes #9329 (#9334) 2022-08-02 02:40:59 -04:00
Jeff Wadsworth
90e888fe13 - Fixed #9326 2022-07-27 08:59:31 -05:00
Alex Vasile
c34c6a59df
Test for Copied Gilded Drake reverting control when killed (#9198) 2022-07-27 08:05:10 -04:00
Alex W. Jackson
516ac042a2 Fix BecomesBlockedAttachedTriggeredAbility (#9325) 2022-07-27 00:42:32 -04:00
Alex Vasile
4b511775db Further optimization of BecomesAllBasicsControlledEffect by making static the basic mana abilities used for checking 2022-07-26 10:12:32 -04:00
PurpleCrowbar
e67f6df0d6 [CMD] Fixed Ruhan of the Fomori and cards with similar effects. Closes #9096 2022-07-26 01:08:32 +01:00
Alex Vasile
513085bbcc Fixed Banishing Light-type effects to not exile creatures if the source permanent is not on the battlefield when the effect resolves. Closes #8899. 2022-07-17 21:08:09 -04:00
Alex Vasile
9715021a35 Fixed GoadAllEffect from affecting creatures that ETB after it resolves. Closes #9227. 2022-07-17 19:41:45 -04:00
Alex Vasile
8c22db650a [CLB] Fixed connive fizzling on stack when permanent that connived leaves the battlefield. Closes #9252. 2022-07-17 18:24:35 -04:00
Alex Vasile
df39503a0b
Reduce CPU cost of BecomesAllBasicsControlledEffect. (#9263) 2022-07-12 21:16:55 -04:00
Alex Vasile
f6ff32e38b
[AER] Inspiring Statuary display fix (#9214) 2022-07-08 21:37:31 -04:00
Alex Vasile
a8a16968d3
[AKH] Fix game slowdown from Cascading Cataracts. Closes #7649. (#9068) 2022-07-04 22:20:54 -04:00
Alex Vasile
78f3547644
Added common interface to conditional effects (#9208) 2022-07-04 20:28:54 -04:00