Commit graph

19 commits

Author SHA1 Message Date
Mike Simons
8d08f005af Fix various hints and warnings on many set & block classes (via IntelliJ IDEA linting):
- replacing hard coded strings of set codes with reference to 'mage.sets.<set>.getInstance().getCode()' allows for set class names to no longer show as unreferenced & adds for more consistence between other block units
- various protected variables were able to be changed to private to clean up additional warnings
- some JavaDoc comments were generating warnings due to missing documentation
- removed some unused imports and unused variables
- there were multiple conditional logic checks for 'rarity != Rarity.LAND' within an if block where the outer condition was 'if rarity == Rarity.COMMON' rendering the inner condition always true and thus redundant
- a few ExpansionSet.buildDate parameters wer using octal values (eg. '03' instead of '3') which triggered some warnings
- added a booster generation test for WarOfTheSparks to make sure every booster contains a planeswalker
- added a booster generation test for ModernHorizons to make sure every booster contains a snow land
- booster generation test for Battlbond set referenced the Coldsnap set class instead of Battlebond
2019-07-18 23:28:48 -04:00
Quercitron
992470e1ea Fix that MaxCardNumberInBooster filter is applied incorrectly and only part of the commons is used for booster generation in the Core Set 2019, Dragon's Maze and Fate Reforged sets 2018-07-08 17:23:44 +03:00
GrayedFox
3953f3dbdd
remove all MIT copyright notices from files 2018-06-02 17:59:49 +02:00
Evan Kranzler
92a6bd4748 Changed all set classes to final 2018-05-21 11:20:15 -04:00
Evan Kranzler
c78477756c fixed set file formatting 2017-09-26 10:38:48 -04:00
LevelX2
cd6c7623ed * Added missing imports, imports reorg. 2017-07-23 16:29:29 +02:00
fireshoes
55b433ae36 [AKH] Added 3/27 spoilers to mtg-cards-data.txt. Implemented several of the new cards. 2017-03-28 22:25:29 -05:00
vraskulin
d93061c0bc Equals should be compared with == but not equals() 2017-03-22 14:50:50 +03:00
ingmargoudt
234cfe9519 rewrote singleton to enum where applicable 2017-03-14 16:32:47 +01:00
fireshoes
89dd981075 Merge 2016-10-17 23:45:47 -05:00
JOAC69
59f88047e4 Modify cards 2016-10-04 20:06:28 -05:00
Fenhl
430ae503c7 Change all line endings to LF 2016-04-14 16:18:01 +00:00
Simown
84d2353819 Fix for Random booster draft iterates endless while booster generation (#1136) 2015-07-26 12:45:14 +01:00
LevelX2
b4636b2ce1 * Rework of booster generation to reduce DB load while starting a tournament. 2015-02-10 00:51:36 +01:00
LevelX2
abc441a4ba * Added rough Vintage Masters bonus card booster generation. 2014-06-25 12:29:32 +02:00
North
0bb110be45 [refactor] moved enums from Constants class 2013-06-16 12:28:10 +03:00
North
4d16535709 removed unused metadata from ExpansionSet 2013-06-16 09:52:29 +03:00
LevelX2
a157849e16 Changed bosster generation to generate special land card that's in dragon's maze booster. 2013-04-27 18:56:39 +02:00
LevelX2
2fc53fa71e Added Commander and Dragon's Maze set objects to MAGE. 2013-04-10 16:55:31 +02:00