Commit graph

568 commits

Author SHA1 Message Date
jmlundeen
b32a786236 add verify checks for Double Faced Cards having abilities on main card
* add booleans to card scanner, restricting to checking cards by name and set. Reduces duplication of verify checks across sets.
2025-11-27 09:39:46 -06:00
Jmlundeen
69e20b1061
Merge pull request #14061
* move setPT to Card

* Create DoubleFacedCard and DoubleFacedCardHalf to share code between …

* Create Transforming Double Face Card class

* allow putting either permanent side of a double faced card to the bat…

* refactor exile and return transforming card

* update ModalDoubleFacedCard references to DoubleFacedCard where relev…

* update for GUI

* refactor a disturb card

* refactor more disturb cards for test coverage

* refactor a transform card

* refactor more transform cards for test coverage

* fix Archangel Avacyn

* fix cantPlayTDFCBackSide inconsistency

* fix Double Faced Cards having triggers and static abilities when tran…

* fix Double Faced Cards card view erroring when flipping in client

* fix test_Copy_AsSpell_Backside inconsistency

* enable Spider-Man MDFC

* convert TDFC with saga as the front and add card references to Transf…

* refactor More Than Meets the Eye Card

* refactor a battle

* refactor a craft card

* update comment on PeterParkerTest

* Merge branch 'master' into rework-dfc

* fix Saga TDFC Azusa's Many Journeys

* fix double faced cards adding permanent triggers / effects to game

* move permanents entering map into Battlefield

* convert Room cards for new Permanent structure

* fix disturb not exiling

* Merge branch 'master' into rework-dfc

* fix Eddie Brock Power/Toughness

* fix Miles Morales ability on main card

* fix verify conditions for siege and day/night cards

* change room characteristics to text effect to match game rules

* update verify test to skip DoubleFacedCard in missing card test

* accidentally removed transform condition

* Merge branch 'master' into rework-dfc

* fix verify

* CardUtil - remove unnecessary line from castSingle method
2025-11-27 09:24:03 -06:00
xenohedron
934d8e13f5 various text fixes 2025-11-22 20:44:33 -05:00
xenohedron
589a02ae85 fix verify 2025-11-22 20:17:57 -05:00
Steven Knipe
965bf8bea3 Fix Earthbend target for verify check 2025-11-18 23:01:41 -08:00
xenohedron
46452b252e verify fix 2025-11-18 21:14:39 -05:00
theelk801
790361f59f [TLA] various text fixes 2025-11-18 09:21:40 -05:00
ReSech
eb69df1623
FULL_ART Card and Check Fixes (#14004)
* Fix SLD Lands and SLC Full Art

* Update FULL_ART cards in SPM

* Update FULL_ART in SLD

* More SLD FULL_ART

* update test_checkWrongFullArtAndRetro
2025-11-08 15:26:13 -05:00
theelk801
0168db7a57 temporary verify fix 2025-11-03 20:30:22 -05:00
theelk801
401e09830d fix verify failures 2025-09-05 21:01:40 -04:00
theelk801
7b9a72f758 fix verify failure 2025-08-30 20:26:18 -04:00
ReSech
0adbc7c0c3
tests: added verify tests for retro and full art images (#13912)
* Add promoTypes and isTextless fields to MtgJsonCard; enhance VerifyCardDataTest for full art validation

* whitespace fixes

* Add null check

* Split Retro and FullArt to seperate Test

* Refactor VerifyCardDataTest to consolidate full art setting checks for poster promoType and textless cards

* Add validation for full art lands in VerifyCardDataTest

* Remove duplicate checks in checkWrongCardsDataInSets and add "not use" checks
2025-08-30 13:47:51 +04:00
theelk801
168e2a27ec fix verify failure 2025-08-15 16:58:14 -04:00
Oleg Agafonov
aa1915cd13 deck: added old promo sets with boosters: Renaissance and Rinascimento (close #13906); 2025-08-15 08:17:26 +04:00
theelk801
355e8c15bc remove temporary verify skip 2025-08-14 14:34:09 -04:00
theelk801
a00010a582 fix verify failure 2025-08-12 18:47:43 -04:00
ssk97
100fff9c6a
improve and enable checkMissTargeted verify test (#13647)
* Add per-ability verify test

* Add check that the word target appears equally in both reference and card text
2025-07-25 23:44:28 -07:00
theelk801
22b096cd04 fix verify failure 2025-07-24 16:56:50 -04:00
theelk801
5b87fffc2e [EOE] various text fixes 2025-07-21 17:26:24 -04:00
theelk801
33b8e6fcaa rework verify skip for double-faced omen cards 2025-07-20 11:51:54 -04:00
theelk801
ffca1032ff make a verify variable static 2025-07-19 08:34:14 -04:00
theelk801
e56960c2ed fix verify failure 2025-07-18 21:20:14 -04:00
Oleg Agafonov
dcaa0b9834 tests: added verify tests for emblems (class naming and package, constructor, image data, related to #13853) 2025-07-17 09:31:39 +04:00
theelk801
476680f5d6 temporary verify fix 2025-07-14 20:44:45 -04:00
theelk801
69e6b718ec remove skip, fix error with CreaturesYouControlCount (#13855) 2025-07-14 19:48:27 -04:00
theelk801
8284523be0 temporarily disable test until fixed (#13855) 2025-07-14 19:35:09 -04:00
theelk801
ac361ffb97 [EOE] some text fixes 2025-07-12 12:21:29 -04:00
theelk801
e03a164bb3 add verify check for "custom" subtypes that become official 2025-07-01 17:18:05 -04:00
theelk801
5bf332ba80 remove temporary verify skip 2025-06-25 11:13:27 -04:00
theelk801
abd251cb6e add temporary verify skip 2025-06-20 22:56:38 -04:00
Steven Knipe
fbdff2e49c Fix checking all sets' text 2025-06-17 23:39:18 -07:00
ssk97
9ce5dd212a
Adding targets (Part 1/3) (#13680)
Adds target and/or target adjuster to cards whose abilities have the word "target", cards A-G.
Creates SourceDealsNoncombatDamageToOpponentTriggeredAbility and DefineByTriggerTargetAdjuster
2025-06-17 22:35:49 -07:00
Oleg Agafonov
bcac563272 tests: improved bad conditions test (related to #13752) 2025-06-14 18:09:19 +04:00
Oleg Agafonov
fe18aa9f4a tests: added verify test for bad conditions with NPE on empty source param (disabled by default, related to #13752) 2025-06-14 17:43:52 +04:00
xenohedron
76c0124052 tests: enable properties for verify check parameters 2025-06-14 00:34:32 -04:00
Oleg Agafonov
d465c9fb82 GUI, deck: improved bracket level calculations (added all infinite combos list and spellbook downloader, part of #13341) 2025-06-06 18:56:03 +04:00
theelk801
02b649f180 [BLC] various text fixes 2025-06-02 16:52:09 -04:00
theelk801
fe4d6d3197 [BLB] various text fixes 2025-06-02 16:30:11 -04:00
theelk801
699b8d59dc more text fixes (DRC is now 100%) 2025-06-01 21:19:16 -04:00
theelk801
5e83c3c3f0 various text fixes 2025-06-01 17:10:15 -04:00
theelk801
6415a493ff [FDN] a few text fixes 2025-06-01 10:30:16 -04:00
theelk801
1ab9eeaad8 [J25] various text fixes 2025-06-01 10:29:05 -04:00
Oleg Agafonov
71b0613355 tests: added verify check for wrong target tags usage, improved work with tagged targets (related to 8b2a81cb42) 2025-06-01 08:54:24 +04:00
xenohedron
99189ea7a3 text fixes [ODY] [TOR] [JUD] [ONS] [LGN] [SCG] 2025-05-31 22:09:52 -04:00
Oleg Agafonov
3d45a24959
Draft Cubes rework (better cube from deck, dynamic data, better errors processing, actual MTGO Vintage Cube) (#13705)
- GUI, table: added dynamic data support for Cube Types (no more depends on server's config names, part of #12050);
- server: replace multiple MTGO Vintage Cubes by single cube, updated to April 2025 (part of #12050);
- server: fixed table freeze on starting error (related to #11285);
- GUI, table: added better support of Cube From Deck (client/server side errors, additional info about loaded cards, etc);
2025-05-31 20:15:31 +04:00
theelk801
a9cd45c84e [FIN] more text fixes 2025-05-31 10:09:59 -04:00
theelk801
a27302654c [FIC] more text fixes 2025-05-31 09:51:19 -04:00
theelk801
a61851db09 [FCA] a few text fixes 2025-05-30 22:20:13 -04:00
theelk801
1051ccbe9d [FIC] various text fixes 2025-05-30 22:20:13 -04:00
theelk801
9ef2aac469 [FIN] various text fixes 2025-05-30 22:20:12 -04:00