xenohedron
81f97c3b0e
fix more text
2023-11-25 02:59:06 -05:00
xenohedron
109547a1ad
lots of text fixes
2023-11-23 01:54:51 -05:00
xenohedron
1816c8ad73
many the text fixes
2023-11-19 21:37:37 -05:00
xenohedron
e122e9d512
various and sundry text fixes
2023-11-04 18:41:56 -04:00
xenohedron
daecbe2071
fix #11385 - triggers once per turn
...
even if another effect would cause additional triggers
2023-11-03 20:52:36 -04:00
xenohedron
ebf71941a9
cleanup EntersBattlefieldAllTriggeredAbility and subclasses ( #11372 )
...
* comment out rule override to use generated text instead
* new ETB Opponent trigger class
* text improvements
* update ETB cast trigger
* remove controlledtext parameter
* more text improvements
* more fixes
* lots of other fixes
* most of the remaining fixes
* fix halana text
* fix smoke shroud text
* improve text gen
* remove rule param from constructors
* minor adjustments
* whenever a player puts
* final fixes
* standardize when/whenever phrase generation
2023-10-31 21:00:45 -04:00
Susucre
5996cfbce2
[MIR] Implement Teferi's Imp ( #11326 )
2023-10-22 14:34:45 +02:00
xenohedron
b3bc6b94aa
improve text generation
2023-10-15 23:43:10 -04:00
xenohedron
bd7ae640c5
fix some effects to use DoIfCostPaid
2023-10-09 23:52:57 -04:00
xenohedron
4e561b6254
text generation improvements ( #11203 )
...
* update ETB trigger effect text gen
* set replace for common abilities
* fix remaining
* rename method, cleanup
* more fixes, better logic
2023-09-25 21:51:51 -04:00
Oleg Agafonov
be4bff6097
game: fixed wrong usage of batch events (related to #10870 )
2023-09-13 04:42:46 +04:00
PurpleCrowbar
692c55e3e1
Do this only once each turn - fixed wrong triggers after optional usage (example: Ondu Spiritdancer, see #11106 ) ( #11107 )
...
* Fix Ondu Spiritdancer. Closes #11106
* Add tests for "Do this only once each turn"
* Add test for Ondu Spiritdancer
2023-09-06 22:12:03 +04:00
xenohedron
1903f90b3a
better text generation, a couple more individual fixes
2023-08-30 23:25:10 -04:00
xenohedron
fa72e243e9
Text generation improvements for triggered abilities ( #10638 )
2023-07-17 20:03:01 -04:00
xenohedron
a7f78e8190
Clean up triggered ability text generation ( #10627 )
...
* move "or battle" to its own class
* move "or planeswalker" to its own class
* remove strange way of setting custom text
* finally remove getTriggerPhrase
* copy constructor visibility
* fix Vraska
2023-07-15 16:49:40 -04:00
Susucre
2188c690c6
[LTR] Implement Eomer, Marshal of Rohan ( #10617 )
...
Also, small refactor adding EachTurn to the name of both `setTriggersOnce` and `setDoOnlyOnce`.
2023-07-14 21:32:00 -04:00
xenohedron
72ebe2b1f1
minor code cleanup triggered abilities
2023-07-14 20:30:09 -04:00
xenohedron
5c8b5f23bb
Fix text [CHK] [BOK] [SOK] ( #10355 )
...
* Fix text: duplicate ("you control") in Champion ability
* New static filter "artifacts and enchantments"
* Text fixes [CHK] [BOK] [SOK]
* Fix Genju text without breaking the effect this time
2023-06-02 12:33:48 +03:00
xenohedron
7b9243f640
Add string rule logic to TriggeredAbilityImpl ( #10370 )
...
* Add string rule logic to TriggeredAbilityImpl
* Fix string logic in TriggeredAbilityImpl
* Revert adjustment that fixes some problems but causes others
2023-06-02 11:31:15 +03:00
xenohedron
35bb7d513b
Another batch of text fixes ( #10317 )
...
* Fix text: Blind Hunter
* Fix text: cards with bloodrush ability
* Fix text: populate ability
* Fix Goblin Pyromancer to boost all
* Fix text: Wellwisher; Kamahl, Fist of Krosa; Snapping Thragg
* Fix text: "you may prevent"
* Fix text: Elvish Guidance, Elvish Pathcutter
* Fix text: [search library for cards named]
2023-05-07 13:30:55 -04:00
theelk801
ff115cad48
[ONE] various text fixes
2023-04-24 22:26:34 -04:00
Oleg Agafonov
409f4eb36c
Merge pull request #9814 from Merlingilb/add-set-expansion-star-wars-rise-of-skywalker
...
Added set expansion star wars "rise of skywalker"
2023-03-04 16:48:38 +04:00
PurpleCrowbar
2b77d53f81
Fix doOnlyOnce clause on triggered abilities
2023-03-01 10:06:43 +00:00
Daniel Eberhard
cfad8d5078
Added card "Allegiant General Pryde" and its abilities and effects
2022-12-14 05:29:43 +01:00
Alex W. Jackson
ff777c5687
[STX] Simplify Strict Proctor trigger check
2022-11-05 04:49:15 -04:00
Alex Vasile
ebdb6b53a4
Replace Overriden getTriggerPhrase() with setTriggerPhrase() usage ( #9343 )
2022-08-08 23:28:46 -04:00
Alex Vasile
015cdf3136
Revert "Added missing fields to many copy constructors. ( #8957 )" ( #8999 )
...
This reverts commit 82708e4273
2022-05-25 12:57:24 -06:00
Alex Vasile
82708e4273
Added missing fields to many copy constructors. ( #8957 )
2022-05-25 09:51:18 -06:00
Evan Kranzler
0b50f15923
[SNC] Implemented Riveteers Ascendancy
2022-04-22 09:17:09 -04:00
Evan Kranzler
80e11b2052
(WIP) Replacing blocking/blocked by predicates ( #8729 )
...
* replaced blocking/blocked by predicates
* added test for knight of dusk (currently fails)
* added source parameter to filters and everything else that needs it
* some changes to various predicates
* test fix
* small changes to filter code
* merge fix
* fixed a test failure
* small change to Karn, Scion of Urza
* removed sourceId from filter methods and other similar places
* added new getobject method to fix some test failures
* a few more fixes
* fixed merge conflicts
* merge fix
2022-03-23 18:45:02 -04:00
Evan Kranzler
caa1b7a8d7
[ZEN] various text fixes
2022-03-08 20:59:01 -05:00
Evan Kranzler
c8cdc0a502
[CON] various text fixes
2022-03-06 18:07:25 -05:00
Oleg Agafonov
83017e3c51
Devs: added docs and todo about short living LKI, LKI and current problems;
2021-09-05 18:49:44 +04:00
Evan Kranzler
bbcccf4b58
[AFC] Implemented Galea, Kindler of Hope
2021-08-27 09:08:20 -04:00
Evan Kranzler
b1bbe96536
fixed an error
2021-08-21 17:13:03 -04:00
Evan Kranzler
0bd402876d
[AFC] Implemented Nihiloor
2021-08-21 16:35:09 -04:00
Evan Kranzler
ca80806400
Reworking triggered ability text generation to allow for ability words and flavor words to be added more easily ( #8010 )
...
* refactor all instances of getRule in triggered abilities using new getTriggerPrefix method
* updated triggered ability rules generation
* renamed method
* fixed a test failure
* some more refactoring
* simplified some instances of ability word usage
2021-07-15 07:46:38 -04:00
Evan Kranzler
572104b8fc
Reworking card types in preparation for implementing Grist, the Hunger Tide ( #7899 )
...
Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2021-07-09 07:28:43 +04:00
Ingmar Goudt
96d026e4af
remove explicit null checks, match(..) checks on null itself by instanceof calls
2021-04-28 20:53:50 +02:00
Evan Kranzler
cae1b271c2
[STX] some final text fixes
2021-04-18 15:09:18 -04:00
Evan Kranzler
f9467d5142
[STX] Implemented Strict Proctor
2021-04-16 18:48:40 -04:00
Evan Kranzler
6ff3ca5c1e
[STX] Implemented Dramatic Finale
2021-04-08 18:56:18 -04:00
Evan Kranzler
f9dfb56d4e
[KHM] more text fixes
2021-01-31 11:28:44 -05:00
LevelX2
2ce90b1e0a
* Fixed that the dies trigger of Ashen Rider also triggers if Ashen Rider is copied by other creatures (e.g. Volrath the Shapestealer) ( fixes #7107 ).
2020-12-23 18:02:00 +01:00
LevelX2
2fec825523
* Some standardisation of dies trigger handling ( fixes #7063 Midnight Reaper triggers when dies face down).
2020-09-18 16:15:21 +02:00
Oleg Agafonov
61bfdf8108
Tests: added verify check for wrong optional settings on DoIfCostPaid usage;
2020-08-14 16:22:34 +04:00
jeffwadsworth
bfb7a1a24d
- Fixed #6838
2020-07-14 15:49:30 -05:00
LevelX2
32ce1d85e9
* Fix of some problems of zone change related triggered abilities that had not been correctly implemented ( fixes #6586 ).
2020-05-29 14:41:24 +02:00
Oleg Agafonov
5adab75324
Revert "format: organize imports"
2020-02-05 02:17:00 +04:00
Leandro Doctors
8a0a9acff7
format: organize imports
2020-02-04 16:21:48 -03:00
