Commit graph

16 commits

Author SHA1 Message Date
ssk97
d806a6a3be
Counter text improvements (plus a Magus Lucea Kane gameplay fix) (#11503)
* Improve text generation for some counter abilities

* Magus Lucea Kane must apply to permanent spells (bugfix, related to #11440)

* Further improve text generation of counter text

* Text improvements to a couple cards

* Graft text improvements

* Further remove unused variable

* Be consistent on Backup ability setup, revert Thalia's Lieutenant (filter reuse means it doesn't work)

* Thalia's Lieutenant original text was slightly wrong, fixed
2023-12-03 21:42:16 -05:00
ssk97
bea33c7493
Costs Tag Tracking part 2: Tag system and X values, reworked deep copy code (#11406)
* Implement Costs Tag Map system

* Use Costs Tag Map system to store X value for spells, abilities, and resolving permanents

* Store Bestow without target's tags
Change functions for getting tags and storing the tags of a new permanent

* Create and use deep copy function in CardUtil, add Copyable<T> to many classes

* Fix Hall Of the Bandit Lord infinite loop

* Add additional comments

* Don't store null/empty costs tags maps (saves memory)

* Fix two more Watchers with Ability variable

* Add check for exact collection types during deep copy

* Use generics instead of pure type erasure during deep copy

* convert more code to using deep copy helper, everything use Object copier, add EnumMap

* fix documentation

* Don't need the separate null checks anymore (handled in deepCopyObject)

* Minor cleanup
2023-11-16 23:12:32 +04:00
Susucre
f75b1c9f0a
Code cleanup: protect all copy constructors (#10750)
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
2023-08-04 19:34:58 -04:00
Alex W. Jackson
332db3aecb Fix #9649 and clean up counter effect text generation 2022-10-14 00:41:02 -04:00
Oleg Agafonov
5adab75324
Revert "format: organize imports" 2020-02-05 02:17:00 +04:00
Leandro Doctors
8a0a9acff7 format: organize imports 2020-02-04 16:21:48 -03:00
GrayedFox
3953f3dbdd
remove all MIT copyright notices from files 2018-06-02 17:59:49 +02:00
LevelX2
17fbee2400 * Fixed a bug that adding counters with Skyship Plunder or Maulfist Revolution did not trigger counter added events. 2017-01-13 22:40:37 +01:00
vraskulin
01bb9572e9 Refactoring
See github line by line comments in 'File changed'
2016-12-29 15:38:22 +03:00
LevelX2
eb0ae55257 * Fixed a problem with "put into the graveyard from anywhere triggers" that checked wrongly the state of the source object on the battlefield if went to graveyard itself. 2015-12-24 17:58:04 +01:00
LoneFox
07f7f38843 Fix a bogus warning when removing all counters of one type from a permanent 2015-12-15 14:29:14 +02:00
LevelX2
595a55b7c5 Revert "Fixed package declarations for moved Mage package."
This reverts commit 06199eeca3.
2015-12-01 22:33:59 +01:00
poixen
db2af7000e Merge pull request #1399 from poixen/counters
Added unit tests and javadoc for Counter class.
2015-12-01 20:04:15 +01:00
emerald000
06199eeca3 Fixed package declarations for moved Mage package. 2015-12-01 06:07:01 -05:00
poixen
ad0fb6b7eb Added unit tests and javadoc for Counter class. 2015-11-30 21:44:57 +01:00
poixen
46eb6c0525 Restructured Mage module 2015-11-29 21:56:49 +01:00
Renamed from Mage/src/mage/counters/Counter.java (Browse further)