Evan Kranzler
3feb2017d3
removed unnecessary overrides of adjustTargets and adjustCosts
2021-03-23 20:43:16 -04:00
Oleg Agafonov
a1da5ef437
* GUI: new reworked GUI and card render engine, card icons and dozens of other fixes (see full list in related PR);
2021-01-30 16:38:55 +04:00
Evan Kranzler
a535cb5adc
Refactoring methods which add counters to track which player adds the counters (ready for review) ( #7448 )
...
* added parameter for player adding counters to players
* added parameter for player adding counters to cards/permanents
* updated methods to use new parameter
* fixed a few initial errors
* refactored instances of cards that add counters by a player other than the controller
* fixed some instances of incorrect arguments
* refactored abilities that trigger off of a particular player adding counters
* a few more cards that were missed
* [KHM] Implemented Vorinclex, Monstrous Raider
* added test for Vorinclex, Monstrous Raider
* fixed a test failure
2021-01-26 19:06:13 -05:00
Oleg Agafonov
6dcbcbe962
Tyvar Kell and gain ability fixes:
...
* GainAbilityTargetEffect - reworked to support static/dynamic targets, added support of spells (card + related permanent);
* SpellCastControllerTriggeredAbility - now it can setup the target to a card instead a spell;
* Added checks/errors on wrong ability adding code (example: if you add permanent's ability by game state instead permanent's method);
* Tyvar Kell Emblem now use a standard code;
* Test framework: added additional logs for some errors;
2021-01-12 04:41:35 +04:00
LevelX2
c67ce93ec4
* Fixed some problems with color changes of cards and spells - e.g. Painter's Servant ( fixes #7325 fixes #6487 ).
2021-01-08 11:03:39 +01:00
Oleg Agafonov
4d362d7edc
* Copy spells - improved combo support with other abilities like Kicker or Entwine ( #7192 ):
...
* Now ZCC of copied spells syncs with source card or coping spell (allows to keep ability settings that depends on ZCC);
* Fixed bug that allows to lost kicked status in copied spells after counter the original spell or moves the original card (see #7192 );
* Test framework: improved support of targeting copy or non copy spells on stack;
2020-12-15 20:06:53 +04:00
Oleg Agafonov
db239a1055
Refactor: replaced sourceId by source and introduced source param in some methods;
2020-12-12 20:23:19 +04:00
Oleg Agafonov
4893c5b1ac
[ZNR] Improved modal double faces cards in GUI ( #7012 )
2020-11-01 10:03:09 +01:00
Oleg Agafonov
e4c8ba046a
[ZNR] Improved modal double faces cards implementation and more tests ( #7012 )
2020-11-01 10:03:09 +01:00
Oleg Agafonov
c60bf3ccef
[ZNR] Added images download for modal double faces cards ( #7012 )
2020-11-01 10:03:09 +01:00
Oleg Agafonov
8ac78b4b9e
Added modal double faces cards implementation (MDF cards, #7012 )
2020-11-01 10:03:09 +01:00
Evan Kranzler
9baaa8d214
[ZNR] added small additional fix for mdfc testing
2020-09-17 13:12:10 -04:00
Oleg Agafonov
7a1795660a
Fixed missing copy fields in CardImpl (morph, modaldfc, art; related to rollback);
2020-09-04 01:29:31 +04:00
Evan Kranzler
42e38a4e8a
some more changes to modal DFC implementation
2020-09-03 14:06:11 -04:00
Oleg Agafonov
4e174e25be
Merge fix
2020-08-22 19:21:25 +04:00
Oleg Agafonov
1b430e5d99
Added verify test to check missing second face cards in sets, fixed missing cards;
2020-08-22 18:48:15 +04:00
LevelX2
8105d8b26c
* Improved handling of asThoughtAs approval by abilities that allows a clear and easy assignment of the approving effect.
2020-08-21 14:58:22 +02:00
Oleg Agafonov
83f7ae377a
Refactored restore state code, added additional error check for mana undo param;
2020-08-06 22:17:37 +04:00
LevelX2
b0cd69bb08
* Fixed missing imports of aad36dda19 commit.
2020-07-15 00:48:19 +02:00
LevelX2
aad36dda19
* Fixed possible problem with setting of the spellAbility during card copies (related to eecaa232f5).
2020-07-14 23:18:47 +02:00
LevelX2
49ab4e0992
* Fixed possible problem with setting of the spellAbility during card copies (related to eecaa232f5).
2020-07-14 23:06:03 +02:00
LevelX2
eecaa232f5
* Fixed a problem where for copies of cards/permanent the included spell ability was not correctly copied and the copied card had the spell ability twice. That could cause in some rare cases problems with spell ids of copies (this fixes #6824 ) or did allow on the other side some unproper handling of things (Animate Dead).
2020-07-14 21:28:45 +02:00
Oleg Agafonov
6dccaee9a4
Ghostfire Blade - fixed that it can't be played without full available mana ( #6698 );
2020-07-02 20:37:59 +04:00
Oleg Agafonov
e95ae2675b
Fixed different ZCC in split card's parts (flashback fix, see 95075cf33e);
...
Improve moveToZone code and fixed some cards with wrong commands queue (e.g. directly removes card from zone and then calls moveToZone again);
2020-06-04 23:47:50 +04:00
Oleg Agafonov
cce467a5ec
Additional fix and simplified for playable abilities (see comments b94344341b)
2020-06-04 03:21:18 +04:00
Oleg Agafonov
8af43dc13a
Ability refactor: new code to search abilities in cards and permanents;
2020-05-28 22:34:27 +04:00
Samuel Sandeen
d56f6b991b
Fix Sevinne's Reclamation. ( #6275 )
...
This also handles the rather unique case caused by Sevinne's Reclamation where the original spell resolves before the copy of it.
Also fixes a couple typos.
2020-02-10 08:18:12 -05:00
Oleg Agafonov
5adab75324
Revert "format: organize imports"
2020-02-05 02:17:00 +04:00
Leandro Doctors
8a0a9acff7
format: organize imports
2020-02-04 16:21:48 -03:00
Oleg Agafonov
9110f70e2d
Fixed NPE errors in deck editor;
2020-01-05 02:03:01 +04:00
LevelX2
8854871c15
* Fixed problems of Yixlid Jailer that removed abilities from cards in graveyard permanently ( fixes #1147 ).
2020-01-03 15:23:52 +01:00
Patrick Hulin
383069f5eb
Merge branch 'master' of https://github.com/magefree/mage into adventures
2019-12-11 22:15:38 -05:00
Oleg Agafonov
6b5a9846b9
Fixed rules generation
2019-12-11 04:40:07 +04:00
Patrick Hulin
19a9d98287
Adventures basically working.
...
No graphics yet.
2019-12-09 12:46:43 -05:00
Oleg Agafonov
7e08b3c3d5
Test framework: added support to create custom instant/sorcery;
2019-06-26 21:40:17 +04:00
Oleg Agafonov
ffbd5d373b
* Planeswalker abilities - fixed that plus cost's counters is not affected by replacement effects ( #5802 , example combo: Planeswalker + Pir, Imaginative Rascal + Doubling Season);
2019-05-17 16:10:34 +04:00
Evan Kranzler
785917deb6
Implemented Chandra, Fire Artisan
2019-04-10 16:14:34 -04:00
Ingmar Goudt
72c8c267a1
move Google Guava to mage-root pom in dependencyManagement, so other modules can use it
2019-03-18 15:48:35 +01:00
Ingmar Goudt
8319fbf9ad
replace public fields with encapsulation
2019-03-03 09:51:14 +01:00
Oleg Agafonov
7e4767fd30
Hints: removed duplicated hints from popup;
2019-02-09 12:28:29 +04:00
Oleg Agafonov
f341d35ece
Hints: disable card hints in m15 render mode;
2019-02-09 12:00:24 +04:00
Oleg Agafonov
1b32793388
Added restrict effect hints to permanents;
2019-02-08 03:08:28 +04:00
Oleg Agafonov
2a63314714
Added condition hints for cards
2019-02-05 02:43:13 +04:00
Oleg Agafonov
13ed3c6dbd
Added static and colored hints for cards
2019-02-04 18:48:45 +04:00
Evan Kranzler
3483b3a181
Merge branch 'targetAdjustment' into master
2019-01-12 14:42:58 -05:00
Oleg Agafonov
02b7e2cf10
Refactor: extract card names compare logic (is empty name, is same name)
...
Fixed last broken tests
2018-12-07 00:26:50 +04:00
Evan Kranzler
9d9c7b0242
added cost adjustment framework
2018-09-30 20:12:07 -04:00
Evan Kranzler
f6ed3a4d19
updated target adjusters D through G
2018-09-26 22:13:35 -04:00
Evan Kranzler
b833fc7f77
replaced various single-use adjusters
2018-09-17 14:13:52 -04:00
Evan Kranzler
42417b6711
replaced verse counter adjustment
2018-09-17 13:40:27 -04:00