Commit graph

971 commits

Author SHA1 Message Date
Susucre
0dceeb78bd implement [EOE] Kav Landseeker; fix & test Meandering Towershell along the way 2025-07-11 20:40:59 +02:00
theelk801
8aef6e5a7b fix PlayLandOrCastSpellTriggeredAbility text 2025-07-10 11:56:25 -04:00
theelk801
0513012606 [EOE] Implement The Endstone 2025-07-10 09:55:51 -04:00
ssk97
7d7e517084
More target adding, reattach improves (#13807)
* Add Target to Provoke, Soulshift, remove from AttachableToRestrictedAbility

* Add Target to CurseOfInertia, FarrelsMantle, Incendiary, JubilantMascot, MantleOfTheAncients, MuseVessel, SoulSeizer. Fix DreamEater text.

* Fix CardImpl.cantBeAttachedBy to not early return with Protection abilities

* Improve tests
2025-07-01 22:08:27 -07:00
xenohedron
c07837f743 a couple text fixes 2025-06-21 19:18:31 -04:00
ssk97
5db4beac6c
Adding targets (Part 3/3) (#13769)
Adds target and/or target adjuster to cards whose abilities have the word "target", cards S-Z.
Add `spellCast` value to `CastSpellPaidBySourceTriggeredAbility`.
2025-06-20 18:58:13 -07:00
theelk801
9744819551 finish removing all filter constructors from TargetCreaturePermanent 2025-06-20 08:29:54 -04:00
theelk801
96b39c1210 replace some instances of EntersBattlefieldControlledTriggeredAbility with EntersBattlefieldAllTriggeredAbility 2025-06-19 11:10:14 -04:00
ssk97
219cc53cf4
Adding targets (Part 2/3) (#13765)
Adds target and/or target adjuster to cards whose abilities have the word "target", cards H-R.
fix EffectKeyValue text, NestOfScarabs
Add X value to effects for CycleTriggeredAbility, use with ValorsFlagship and SharkTyphoon, add test
2025-06-18 21:14:16 -07:00
theelk801
7be454fb92 some text fixes 2025-06-18 16:40:18 -04:00
theelk801
d2b507650b replace all instances of ConditionalActivatedAbility with ActivateIfConditionActivatedAbility 2025-06-18 16:06:13 -04:00
theelk801
f89efd226a add ConditionalActivatedAbility code to ActivateIfConditionActivatedAbility 2025-06-18 15:43:31 -04:00
theelk801
fd371c8932 remove timing argument from ActivateIfConditionActivatedAbility 2025-06-18 13:52:48 -04:00
ssk97
1fe0d92c86
Attacks player with creatures triggered ability, Implement [BLC] Echoing Assault (#13764)
Create AttacksPlayerWithCreaturesTriggeredAbility, and tests for that ability via Soaring Lightbringer.
Implement Echoing Assault.
2025-06-18 05:54:36 -07:00
ssk97
9ce5dd212a
Adding targets (Part 1/3) (#13680)
Adds target and/or target adjuster to cards whose abilities have the word "target", cards A-G.
Creates SourceDealsNoncombatDamageToOpponentTriggeredAbility and DefineByTriggerTargetAdjuster
2025-06-17 22:35:49 -07:00
theelk801
6d3bd7a19f refactor: remove OnEventTriggeredAbility 2025-06-15 15:28:08 -04:00
theelk801
d43e96eaf2 some more text fixes 2025-06-14 11:38:00 -04:00
theelk801
96cc1e40ee fix text for enchantments that turn into creatures permanently 2025-06-14 10:16:01 -04:00
xenohedron
24f030fa71
fix #13523 (trigger on becomes the target of recast spell) (#13740)
move findTargetingStackObject from CardUtil to Game, so saved data can be cleared with short living lki

add test cases
2025-06-14 00:09:40 -04:00
theelk801
58b5bb76f9 various text fixes 2025-06-13 13:44:33 -04:00
theelk801
79a2f80563 listening to Pet Sounds on repeat while I refactor ConditionalInterveningIfTriggeredAbility 2025-06-12 19:56:43 -04:00
theelk801
cc2d234d58 oh boy here I go refactoring ConditionalInterveningIfTriggeredAbility again 2025-06-10 11:30:43 -04:00
Evan Kranzler
0e179ccc1f
Refactor SourceHasCounterCondition to be an IntCompareCondition (#13724)
* refactor SourceHasCounterCondition to be an IntCompareCondition

* add comment for arguments
2025-06-07 21:03:21 -04:00
theelk801
d952e3b2ce refactor more cards using ConditionalInterveningIfTriggeredAbility 2025-06-05 12:13:59 -04:00
theelk801
1cb421ece7 [CLB] Implement Commander Liara Portyr 2025-06-03 07:22:51 -04:00
theelk801
cb7620860b [FIC] Implement Urianger Augurelt 2025-06-02 12:06:21 -04:00
theelk801
699b8d59dc more text fixes (DRC is now 100%) 2025-06-01 21:19:16 -04:00
theelk801
5e83c3c3f0 various text fixes 2025-06-01 17:10:15 -04:00
ssk97
3223d99b2a
refactor: remove notTarget targets from abilities (#13651)
Adds OneShotNonTargetEffect and PutCountersTargetCost
Fixes the target timing of spells/abilities, as non-targets should be chosen on resolution.
2025-05-31 20:36:15 -07:00
xenohedron
566839ceeb refactor cards to new common class
"When a [] enters, you may return this card from your graveyard to the battlefield enchanting that creature"
2025-05-31 22:09:52 -04:00
theelk801
a9cd45c84e [FIN] more text fixes 2025-05-31 10:09:59 -04:00
theelk801
a27302654c [FIC] more text fixes 2025-05-31 09:51:19 -04:00
theelk801
1051ccbe9d [FIC] various text fixes 2025-05-30 22:20:13 -04:00
theelk801
9ef2aac469 [FIN] various text fixes 2025-05-30 22:20:12 -04:00
Evan Kranzler
9e2a1a59e0
[FIC] Implement G'raha Tia, Scion Reborn, rework DoIfCostPaid and "do only once" effects (#13660)
* rework effects with DoIfCostPaid and "do this only once each turn"

* [FIC] Implement G'raha Tia, Scion Reborn

* [FIC] Implement Emet Selch of the Third Seat

* rework Emet-Selch

* add test

* add static methods to handle whether ability was used this turn
2025-05-30 21:28:11 -04:00
Susucre
ba395c8385
implement [FIC] Edgar, Master Machinist (#13676) 2025-05-30 15:11:43 +02:00
theelk801
7abb712a03 [FIC] Implement Yuna, Grand Summoner 2025-05-29 10:15:18 -04:00
theelk801
7d40adf33a [FIN] Implement Torgal, A Fine Hound 2025-05-29 09:34:16 -04:00
xenohedron
77830dd24a
Merge pull request #13683 from magefree/from-card
Update effects that find a permanent from a card put to battlefield
2025-05-29 01:00:56 -04:00
theelk801
6fc8ed3043 [FIN] Implement Summon: Fenrir 2025-05-28 14:43:06 -04:00
xenohedron
e3b82def84 update cards to use new method 2025-05-26 17:20:02 -04:00
xenohedron
535543860f refactor: introduce new helper method
to find permanent from card after moved to battlefield
2025-05-26 17:20:02 -04:00
theelk801
c26968b111 [FIC] fix missing filter in Tidus, Yuna's Guardian 2025-05-23 08:53:40 -04:00
Evan Kranzler
450a4befaf
[FIC] Implement Tidus, Yuna's Guardian (#13555)
* [FIC] Implement Tidus, Yuna's Guardian

* merge fix
2025-05-23 08:33:50 -04:00
Evan Kranzler
8f83a807f5
Remove ConditionalTriggeredAbility and add trigger condition into triggered abilities (#13656)
* remove ConditionalTriggeredAbility

* a few small fixes

* merge fix

* simplify phrase handling

* add documentation

* a few text fixes

* update wording
2025-05-23 07:03:14 -04:00
theelk801
b8ffd6dcdc [FIC] Implement Wakka, Devoted Guardian 2025-05-22 20:41:22 -04:00
theelk801
04e96bfa97 [FIN] Implement Sidequest: Play Blitzball / World Champion, Celestial Weapon 2025-05-20 20:16:15 -04:00
theelk801
199315e48b [FIC] Implement Vincent, Vengeful Atoner 2025-05-18 15:59:51 -04:00
Oleg Agafonov
e320bf241c GUI, game: added source info in "choose number/amount" dialogs, added auto-choose for single possible value (part of #13638); 2025-05-17 21:18:45 +04:00
xenohedron
87ab0a3fcc fix #13615 (Vampiric Embrace)
revise setTargetPointer logic of DealtDamageAttachedAndDiedTriggeredAbility
2025-05-14 23:33:07 -04:00