Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

tests: added verify test for bad conditions with NPE on empty source param (disabled by default, related to #13752)

Browse source
This commit is contained in:
Oleg Agafonov 2025-06-14 17:43:26 +04:00
parent d7bc249bfd
commit fe18aa9f4a
1 changed files with 41 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

41
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -16,6 +16,7 @@ import mage.abilities.dynamicvalue.DynamicValue;
import mage.abilities.effects.Effect; import mage.abilities.effects.Effect;
import mage.abilities.effects.common.ExileUntilSourceLeavesEffect; import mage.abilities.effects.common.ExileUntilSourceLeavesEffect;
import mage.abilities.effects.common.FightTargetsEffect; import mage.abilities.effects.common.FightTargetsEffect;
import mage.abilities.effects.common.InfoEffect;
import mage.abilities.effects.common.counter.ProliferateEffect; import mage.abilities.effects.common.counter.ProliferateEffect;
import mage.abilities.effects.keyword.ScryEffect; import mage.abilities.effects.keyword.ScryEffect;
import mage.abilities.hint.common.CitysBlessingHint; import mage.abilities.hint.common.CitysBlessingHint;
@ -36,6 +37,7 @@ import mage.constants.*;
import mage.filter.Filter; import mage.filter.Filter;
import mage.filter.predicate.Predicate; import mage.filter.predicate.Predicate;
import mage.filter.predicate.Predicates; import mage.filter.predicate.Predicates;
import mage.game.FakeGame;
import mage.game.Game; import mage.game.Game;
import mage.game.command.Dungeon; import mage.game.command.Dungeon;
import mage.game.command.Plane; import mage.game.command.Plane;
@ -1695,6 +1697,45 @@ public class VerifyCardDataTest {
} }
} }
@Test
@Ignore // experimental test to find potentially fail conditions with NPE see https://github.com/magefree/mage/issues/13752
public void test_checkBadConditions() {
// all conditions in AsThoughEffect must be compatible with empty source param (e.g. must be able to use inside ConditionalAsThoughEffect)
// see AsThoughEffectType.needAffectedAbility ?
// 450+ failed conditions
Collection<String> errorsList = new ArrayList<>();
Game fakeGame = new FakeGame();
Ability fakeAbility = new SimpleStaticAbility(new InfoEffect("fake"));
// TODO: add classes support (see example with tokens and default constructor)?
Reflections reflections = new Reflections("mage.");
Set<Class<?>> conditionEnums = reflections.getSubTypesOf(Condition.class)
.stream()
.filter(Class::isEnum)
.sorted(Comparator.comparing(Class::toString))
.collect(Collectors.toCollection(LinkedHashSet::new));
for (Class<?> enumClass : conditionEnums) {
for (Object enumItem : enumClass.getEnumConstants()) {
try {
((Condition) enumItem).apply(fakeGame, fakeAbility);
((Condition) enumItem).apply(fakeGame, null);
} catch (Exception e) {
if (e.toString().contains("watchers")) {
// ignore miss watcher errors cause it's fake game
continue;
}
e.printStackTrace();
errorsList.add("Error: condition must support empty and non-empty source params: " + enumClass.getName());
}
}
}
printMessages(errorsList);
if (!errorsList.isEmpty()) {
Assert.fail("Found conditions errors: " + errorsList.size());
}
}
private void check(Card card, int cardIndex) { private void check(Card card, int cardIndex) {
MtgJsonCard ref = MtgJsonService.cardFromSet(card.getExpansionSetCode(), card.getName(), card.getCardNumber()); MtgJsonCard ref = MtgJsonService.cardFromSet(card.getExpansionSetCode(), card.getName(), card.getCardNumber());
if (ref != null) { if (ref != null) {