Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Improve text generation for some common draw, discard and mill effects

Browse source
This commit is contained in:
Alex W. Jackson 2022-10-08 20:48:59 -04:00
parent 15fe971a36
commit fd281ca483
8 changed files with 37 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Mage/src/main/java/mage/abilities/effects/common/MillCardsControllerEffect.java
View file

@ -25,6 +25,7 @@ public class MillCardsControllerEffect extends OneShotEffect {
public MillCardsControllerEffect(DynamicValue numberCards) {
super(Outcome.Discard);
this.numberCards = numberCards;
setText();
}
public MillCardsControllerEffect(final MillCardsControllerEffect effect) {
@ -45,12 +46,16 @@ public class MillCardsControllerEffect extends OneShotEffect {
).isEmpty();
}
@Override
public String getText(Mode mode) {
if (numberCards instanceof StaticValue) {
return "mill " + (((StaticValue) numberCards).getValue() > 1 ?
CardUtil.numberToText(numberCards.toString()) + " cards" : "a card");
private void setText() {
StringBuilder sb = new StringBuilder("mill ");
String value = numberCards.toString();
sb.append(CardUtil.numberToText(value, "a"));
sb.append(value.equals("1") ? " card" : " cards");
String message = numberCards.getMessage();
if (!message.isEmpty()) {
sb.append(value.equals("X") ? ", where X is " : " for each ");
sb.append(message);
}
return "mill X cards, where X is " + numberCards.getMessage();
staticText = sb.toString();
}
}