Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Code cleanup: protect all copy constructors (#10750)

Browse source 
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
This commit is contained in:
Susucre 2023-08-05 01:34:58 +02:00 • committed by GitHub
parent b04b13d530
commit f75b1c9f0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1565 changed files with 2412 additions and 2731 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Mage/src/main/java/mage/game/turn/Step.java
View file

@ -3,6 +3,7 @@ package mage.game.turn;
import java.io.Serializable;
import java.util.UUID;
import mage.constants.PhaseStep;
import mage.game.Game;
import mage.game.events.GameEvent;
@ -10,7 +11,7 @@ import mage.game.events.GameEvent.EventType;
/**
* Game's step
*
* <p>
* Warning, don't use a changeable data in step's implementations
* TODO: implement copyable<> interface and copy usage in GameState
*
@ -36,7 +37,7 @@ public abstract class Step implements Serializable {
this.hasPriority = hasPriority;
}
public Step(final Step step) {
protected Step(final Step step) {
this.type = step.type;
this.hasPriority = step.hasPriority;
this.stepEvent = step.stepEvent;