Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Code cleanup: protect all copy constructors (#10750)

Browse source 
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
This commit is contained in:
Susucre 2023-08-05 01:34:58 +02:00 • committed by GitHub
parent b04b13d530
commit f75b1c9f0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1565 changed files with 2412 additions and 2731 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Mage/src/main/java/mage/game/permanent/Battlefield.java
View file

@ -22,7 +22,7 @@ public class Battlefield implements Serializable {
public Battlefield() {
}
public Battlefield(final Battlefield battlefield) {
protected Battlefield(final Battlefield battlefield) {
for (Entry<UUID, Permanent> entry : battlefield.field.entrySet()) {
field.put(entry.getKey(), entry.getValue().copy());
}
@ -158,8 +158,8 @@ public class Battlefield implements Serializable {
* If you are working with cards and want to know if it is on the battlefield then use game.getState().getZone() instead.
* Note that the card ID and permanant ID may be different (e.g. MDFC puts a half card on the battlefield, not the main card).
*
* @param key the UUID of a permanent to be retrieved
* @return the permanent matching the passed in UUID
* @param key the UUID of a permanent to be retrieved
* @return the permanent matching the passed in UUID
*/
public Permanent getPermanent(UUID key) {
return field.get(key);
@ -172,8 +172,8 @@ public class Battlefield implements Serializable {
/**
* Check whether the battlefield contains a permanent with the passed in UUID.
*
* @param key the UUID whose existence we're checking for among permanents on the battlefield
* @return whether the passed in UUID matches a permanent on the battlefield
* @param key the UUID whose existence we're checking for among permanents on the battlefield
* @return whether the passed in UUID matches a permanent on the battlefield
*/
public boolean containsPermanent(UUID key) {
return field.containsKey(key);