Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Code cleanup: protect all copy constructors (#10750)

Browse source 
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
This commit is contained in:
Susucre 2023-08-05 01:34:58 +02:00 • committed by GitHub
parent b04b13d530
commit f75b1c9f0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1565 changed files with 2412 additions and 2731 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Mage/src/main/java/mage/game/LookedAt.java
View file

@ -13,20 +13,20 @@ import java.util.Map;
import java.util.UUID;
/**
*
* @author nantuko
*/
public class LookedAt extends HashMap<String, Cards> implements Serializable, Copyable<LookedAt> {
public LookedAt() { }
public LookedAt() {
}
public LookedAt(final LookedAt lookedAt) {
for (Map.Entry<String, Cards> entry: lookedAt.entrySet()) {
protected LookedAt(final LookedAt lookedAt) {
for (Map.Entry<String, Cards> entry : lookedAt.entrySet()) {
this.put(entry.getKey(), entry.getValue().copy());
}
}
public void add(String name, Card card) {
public void add(String name, Card card) {
this.createLookedAt(name).add(card);
}
@ -47,7 +47,7 @@ public class LookedAt extends HashMap<String, Cards> implements Serializable, Co
}
public Card getCard(UUID cardId, Game game) {
for (Cards cards: this.values()) {
for (Cards cards : this.values()) {
if (cards.contains(cardId))
return game.getCard(cardId);
}