Code cleanup: protect all copy constructors (#10750)

* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
This commit is contained in:
Susucre 2023-08-05 01:34:58 +02:00 committed by GitHub
parent b04b13d530
commit f75b1c9f0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1565 changed files with 2412 additions and 2731 deletions

View file

@ -14,59 +14,59 @@ import mage.target.Target;
import mage.target.TargetPermanent;
/**
* Exploit is the signature ability of the blue-black Silumgar clan. When a creature with exploit
* Exploit is the signature ability of the blue-black Silumgar clan. When a creature with exploit
* enters the battlefield, you may sacrifice a creature you control.
*
* But you're not just sacrificing your loyal minions for fun. Each creature with exploit has
* <p>
* But you're not just sacrificing your loyal minions for fun. Each creature with exploit has
* another ability that gives you a benefit when it "exploits a creature." This means when you
* sacrifice a creature because of its exploit ability. That ability doesn't trigger if you
* sacrifice a creature because of its exploit ability. That ability doesn't trigger if you
* sacrifice a creature for any other reason, including the exploit ability of a different creature.
*
* <p>
* You can sacrifice any creature you control when the exploit ability resolves, including the creature
* with exploit itself. You don't have to sacrifice a creature if you don't want to. If you do, you choose
* which one as the exploit ability resolves. To get the most out of your minions, look for creatures
* with abilities that give you an added benefit when they die.
*
*
* @author LevelX2
*/
public class ExploitAbility extends EntersBattlefieldTriggeredAbility {
public ExploitAbility() {
super(new ExploitEffect(), true);
}
public ExploitAbility(final ExploitAbility ability) {
protected ExploitAbility(final ExploitAbility ability) {
super(ability);
}
@Override
public ExploitAbility copy() {
return new ExploitAbility(this);
}
}
@Override
public String getRule() {
return "Exploit <i>(When this creature enters the battlefield, you may sacrifice a creature.)</i>";
}
}
class ExploitEffect extends OneShotEffect {
public ExploitEffect() {
super(Outcome.Detriment);
this.staticText = "you may sacrifice a creature";
}
public ExploitEffect(final ExploitEffect effect) {
protected ExploitEffect(final ExploitEffect effect) {
super(effect);
}
@Override
public ExploitEffect copy() {
return new ExploitEffect(this);
}
@Override
public boolean apply(Game game, Ability source) {
Player controller = game.getPlayer(source.getControllerId());
@ -75,14 +75,14 @@ class ExploitEffect extends OneShotEffect {
if (target.canChoose(controller.getId(), source, game)) {
controller.chooseTarget(Outcome.Sacrifice, target, source, game);
Permanent permanent = game.getPermanent(target.getFirstTarget());
if (permanent != null ) {
if (permanent != null) {
if (permanent.sacrifice(source, game)) {
game.fireEvent(GameEvent.getEvent(GameEvent.EventType.EXPLOITED_CREATURE, permanent.getId(), source, controller.getId()));
}
}
}
}
return true;
}
}
return false;
}
}