Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Code cleanup: protect all copy constructors (#10750)

Browse source 
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
This commit is contained in:
Susucre 2023-08-05 01:34:58 +02:00 • committed by GitHub
parent b04b13d530
commit f75b1c9f0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1565 changed files with 2412 additions and 2731 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Mage/src/main/java/mage/abilities/effects/common/SacrificeSourceUnlessPaysEffect.java
View file

@ -32,7 +32,7 @@ public class SacrificeSourceUnlessPaysEffect extends OneShotEffect {
this.genericMana = genericMana;
}
public SacrificeSourceUnlessPaysEffect(final SacrificeSourceUnlessPaysEffect effect) {
protected SacrificeSourceUnlessPaysEffect(final SacrificeSourceUnlessPaysEffect effect) {
super(effect);
if (effect.cost != null) {
this.cost = effect.cost.copy();
@ -61,9 +61,8 @@ public class SacrificeSourceUnlessPaysEffect extends OneShotEffect {
if (costToPay instanceof ManaCost) {
message += "Pay " + costValueMessage;
logMessage += "pay " + costValueMessage;
}
else if (costValueMessage.length() > 1) {
message += costValueMessage.substring(0,1).toUpperCase() + costValueMessage.substring(1);
} else if (costValueMessage.length() > 1) {
message += costValueMessage.substring(0, 1).toUpperCase() + costValueMessage.substring(1);
logMessage += costValueMessage;
}
message += '?';