Code cleanup: protect all copy constructors (#10750)

* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
This commit is contained in:
Susucre 2023-08-05 01:34:58 +02:00 committed by GitHub
parent b04b13d530
commit f75b1c9f0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1565 changed files with 2412 additions and 2731 deletions

View file

@ -3,6 +3,7 @@
package mage.abilities.effects.common;
import java.util.UUID;
import mage.constants.Outcome;
import mage.abilities.Ability;
import mage.abilities.SpecialAction;
@ -10,7 +11,6 @@ import mage.abilities.effects.OneShotEffect;
import mage.game.Game;
/**
*
* @author BetaSteward_at_googlemail.com
*/
public class RemoveSpecialActionEffect extends OneShotEffect {
@ -22,7 +22,7 @@ public class RemoveSpecialActionEffect extends OneShotEffect {
this.actionId = actionId;
}
public RemoveSpecialActionEffect(final RemoveSpecialActionEffect effect) {
protected RemoveSpecialActionEffect(final RemoveSpecialActionEffect effect) {
super(effect);
this.actionId = effect.actionId;
}
@ -34,7 +34,7 @@ public class RemoveSpecialActionEffect extends OneShotEffect {
@Override
public boolean apply(Game game, Ability source) {
for (SpecialAction action: game.getState().getSpecialActions()) {
for (SpecialAction action : game.getState().getSpecialActions()) {
if (action.getId().equals(actionId)) {
game.getState().getSpecialActions().remove(action);
break;