Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Code cleanup: protect all copy constructors (#10750)

Browse source 
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
This commit is contained in:
Susucre 2023-08-05 01:34:58 +02:00 • committed by GitHub
parent b04b13d530
commit f75b1c9f0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1565 changed files with 2412 additions and 2731 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Mage/src/main/java/mage/abilities/effects/common/FightTargetsEffect.java
View file

@ -27,7 +27,7 @@ public class FightTargetsEffect extends OneShotEffect {
this.showEffectHint = showEffectHint;
}
public FightTargetsEffect(final FightTargetsEffect effect) {
protected FightTargetsEffect(final FightTargetsEffect effect) {
super(effect);
this.showEffectHint = effect.showEffectHint;
}
@ -81,11 +81,11 @@ public class FightTargetsEffect extends OneShotEffect {
if (staticText != null && !staticText.isEmpty()) {
return staticText;
}
Target target=mode.getTargets().get(1);
StringBuilder sb=new StringBuilder("target ");
Target target = mode.getTargets().get(1);
StringBuilder sb = new StringBuilder("target ");
sb.append(mode.getTargets().get(0).getTargetName());
sb.append(" fights ");
if(!target.getTargetName().contains("other")){
if (!target.getTargetName().contains("other")) {
sb.append("target ");
}
sb.append(target.getTargetName());