Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Code cleanup: protect all copy constructors (#10750)

Browse source 
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
This commit is contained in:
Susucre 2023-08-05 01:34:58 +02:00 • committed by GitHub
parent b04b13d530
commit f75b1c9f0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1565 changed files with 2412 additions and 2731 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Mage/src/main/java/mage/abilities/effects/RequirementEffect.java
View file

@ -2,6 +2,7 @@
package mage.abilities.effects;
import java.util.UUID;
import mage.abilities.Ability;
import mage.constants.Duration;
import mage.constants.EffectType;
@ -10,7 +11,6 @@ import mage.game.Game;
import mage.game.permanent.Permanent;
/**
*
* @author BetaSteward_at_googlemail.com
*/
public abstract class RequirementEffect extends ContinuousEffectImpl {
@ -22,10 +22,9 @@ public abstract class RequirementEffect extends ContinuousEffectImpl {
}
/**
*
* @param duration
* @param playerRelated defines a requirement that is more related to a
* player than a single creature
* player than a single creature
*/
public RequirementEffect(Duration duration, boolean playerRelated) {
super(duration, Outcome.Detriment);
@ -33,7 +32,7 @@ public abstract class RequirementEffect extends ContinuousEffectImpl {
this.playerRelated = playerRelated;
}
public RequirementEffect(final RequirementEffect effect) {
protected RequirementEffect(final RequirementEffect effect) {
super(effect);
this.playerRelated = effect.playerRelated;
}
@ -52,7 +51,7 @@ public abstract class RequirementEffect extends ContinuousEffectImpl {
public boolean mustBlockAny(Game game) {
return false;
}
public boolean mustBlockAllAttackers(Game game) {
return false;
}