Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Code cleanup: protect all copy constructors (#10750)

Browse source 
* apply regex to change public copy constructors to protected
* cleanup code using now protected constructors
* fix manaBuilder weird casting of Mana into ConditionalMana
This commit is contained in:
Susucre 2023-08-05 01:34:58 +02:00 • committed by GitHub
parent b04b13d530
commit f75b1c9f0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1565 changed files with 2412 additions and 2731 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Mage/src/main/java/mage/abilities/effects/ContinuousRuleModifyingEffectImpl.java
View file

@ -10,7 +10,6 @@ import mage.game.Game;
import mage.game.events.GameEvent;
/**
*
* @author LevelX2
*/
public abstract class ContinuousRuleModifyingEffectImpl extends ContinuousEffectImpl implements ContinuousRuleModifyingEffect {
@ -35,16 +34,15 @@ public abstract class ContinuousRuleModifyingEffectImpl extends ContinuousEffect
}
/**
*
* @param duration
* @param outcome
* @param messageToUser - Every time the effect replaces an event, the user
* gets a message in a dialog window. Don't set it to true if the event
* happens regularly or very often. The message itself can be changed by
* overriding the getInfoMessage method.
* @param messageToLog - Every time the effect replaces an event, a message
* is posted to the game log. The message can be changed by overriding the
* getInfoMessage method.
* gets a message in a dialog window. Don't set it to true if the event
* happens regularly or very often. The message itself can be changed by
* overriding the getInfoMessage method.
* @param messageToLog - Every time the effect replaces an event, a message
* is posted to the game log. The message can be changed by overriding the
* getInfoMessage method.
*/
public ContinuousRuleModifyingEffectImpl(Duration duration, Outcome outcome, boolean messageToUser, boolean messageToLog) {
super(duration, outcome);
@ -54,7 +52,7 @@ public abstract class ContinuousRuleModifyingEffectImpl extends ContinuousEffect
this.messageToGameLog = messageToLog;
}
public ContinuousRuleModifyingEffectImpl(final ContinuousRuleModifyingEffectImpl effect) {
protected ContinuousRuleModifyingEffectImpl(final ContinuousRuleModifyingEffectImpl effect) {
super(effect);
this.infoMessage = effect.infoMessage;
this.messageToUser = effect.messageToUser;