Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

All 1-character strings converted to primitives

Browse source 
"b" + "r" now changed to 'b' + 'w'.  It's more straight-forward, and may cause perfomance improvements - character primitives allocation is faster and less expensive than string creation.
This commit is contained in:
vraskulin 2017-01-27 15:57:10 +03:00
parent 31589778ca
commit f60ebfbb1f
451 changed files with 989 additions and 978 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Mage/src/main/java/mage/abilities/effects/common/combat/CanAttackAsThoughItDidntHaveDefenderAllEffect.java
View file

@ -86,7 +86,7 @@ public class CanAttackAsThoughItDidntHaveDefenderAllEffect extends AsThoughEffec
} else {
sb.append(duration.toString());
}
sb.append(" ");
sb.append(' ');
}
sb.append("as though they didn't have defender");
return sb.toString();

4
Mage/src/main/java/mage/abilities/effects/common/combat/CantAttackAnyPlayerAllEffect.java
View file

@ -49,11 +49,11 @@ public class CantAttackAnyPlayerAllEffect extends RestrictionEffect {
this.filter = filter;
StringBuilder sb = new StringBuilder(filter.getMessage()).append(" can't attack");
if (!duration.toString().isEmpty()) {
sb.append(" ");
sb.append(' ');
if (duration.equals(Duration.EndOfTurn)) {
sb.append(" this turn");
} else {
sb.append(" ").append(duration.toString());
sb.append(' ').append(duration.toString());
}
}
staticText = sb.toString();

4
Mage/src/main/java/mage/abilities/effects/common/combat/CantAttackBlockAllEffect.java
View file

@ -47,11 +47,11 @@ public class CantAttackBlockAllEffect extends RestrictionEffect {
this.filter = filter;
StringBuilder sb = new StringBuilder(filter.getMessage()).append(" can't attack or block");
if (!duration.toString().isEmpty()) {
sb.append(" ");
sb.append(' ');
if (duration.equals(Duration.EndOfTurn)) {
sb.append(" this turn");
} else {
sb.append(" ").append(duration.toString());
sb.append(' ').append(duration.toString());
}
}
staticText = sb.toString();

2
Mage/src/main/java/mage/abilities/effects/common/combat/CantBeBlockedTargetEffect.java
View file

@ -88,7 +88,7 @@ public class CantBeBlockedTargetEffect extends RestrictionEffect {
}
}
if (target.getMaxNumberOfTargets() > 1) {
sb.append(CardUtil.numberToText(target.getMaxNumberOfTargets())).append(" ");
sb.append(CardUtil.numberToText(target.getMaxNumberOfTargets())).append(' ');
}
sb.append("target ").append(mode.getTargets().get(0).getTargetName());
if (target.getMaxNumberOfTargets() > 1) {

4
Mage/src/main/java/mage/abilities/effects/common/combat/CantBlockAttachedEffect.java
View file

@ -62,10 +62,10 @@ public class CantBlockAttachedEffect extends RestrictionEffect {
sb.append("Equipped creature can't block");
}
if (!filter.getMessage().equals("creature")) {
sb.append(" ").append(filter.getMessage());
sb.append(' ').append(filter.getMessage());
}
if (!duration.toString().isEmpty()) {
sb.append(" ").append(duration.toString());
sb.append(' ').append(duration.toString());
}
staticText = sb.toString();
}

10
Mage/src/main/java/mage/abilities/effects/common/combat/CantBlockTargetEffect.java
View file

@ -75,17 +75,17 @@ public class CantBlockTargetEffect extends RestrictionEffect {
}
StringBuilder sb = new StringBuilder();
Target target = mode.getTargets().get(0);
if (target.getMaxNumberOfTargets() == Integer.MAX_VALUE) {
sb.append("any number of ");
} else if (target.getMaxNumberOfTargets() > 1) {
if (target.getMaxNumberOfTargets() == Integer.MAX_VALUE) {
sb.append("any number of ");
} else if (target.getMaxNumberOfTargets() > 1) {
if (target.getMaxNumberOfTargets() != target.getNumberOfTargets()) {
sb.append("up to ");
}
sb.append(CardUtil.numberToText(target.getMaxNumberOfTargets())).append(" ");
sb.append(CardUtil.numberToText(target.getMaxNumberOfTargets())).append(' ');
}
sb.append("target ").append(mode.getTargets().get(0).getTargetName());
if (target.getMaxNumberOfTargets() > 1) {
sb.append("s");
sb.append('s');
}
sb.append(" can't block");